[Design] A couple fixes for 7.10#78801
Merged
cchaos merged 5 commits intoelastic:masterfrom Sep 30, 2020
Merged
Conversation
Dosant
approved these changes
Sep 29, 2020
Contributor
Dosant
left a comment
There was a problem hiding this comment.
AppArch/drilldowns panel changes LGTM.
Thank you 🚀
Contributor
|
These are nice! To test alerting with TLS |
Contributor
Author
|
Sweet, thanks @mdefazio ! |
ryankeairns
approved these changes
Sep 29, 2020
Contributor
ryankeairns
left a comment
There was a problem hiding this comment.
Great batch of fixes! Thanks for tracking and addressing them all.
Contributor
💚 Build SucceededMetrics [docs]async chunks size
page load bundle size
To update your PR or re-run it, just comment with: |
cjcenizal
approved these changes
Sep 29, 2020
Contributor
cjcenizal
left a comment
There was a problem hiding this comment.
Watcher code LGTM, didn't test locally.
pgayvallet
approved these changes
Sep 30, 2020
ThomThomson
approved these changes
Sep 30, 2020
Contributor
ThomThomson
left a comment
There was a problem hiding this comment.
Tested locally in Chrome & Firefox - everything works well! LGTM
cchaos
added a commit
to cchaos/kibana
that referenced
this pull request
Sep 30, 2020
* A few header and KQL bar fixes * More fixes (alerts, modals) * Fixing bottom padding for advanced settings bottom bar * One more alerts responsive fix * Snaps
phillipb
added a commit
to phillipb/kibana
that referenced
this pull request
Sep 30, 2020
…aly-detection-partition-field * 'master' of github.com:elastic/kibana: (37 commits) Fixes for the Ticket 78375 (elastic#79004) [Security] Alert Telemetry for the Security app (elastic#77200) [Search bar] Remove duplicate `popoverProps` (elastic#79025) [Security Solution][Detections] Add rule overrides for single event EQL rules (elastic#78876) [SECURITY_SOLUTION][ENDPOINT] Improve Endpoint Host data generator to also integrate with Ingest (elastic#74305) remove file accidentally checked in (elastic#79005) [ML] DF Analytics creation wizard: replace select input with job type cards with icons (elastic#78872) [Design] A couple fixes for 7.10 (elastic#78801) Fix KQL autocomplete value suggestions (elastic#78676) [Security Solution][Resolver] New mock with cursor (elastic#78863) Embeddables: basic documentation (elastic#78900) [security solution] only import beat_schema when needed (elastic#78708) [Reporting] API Integration tests: fix flaky tests for Spaces CSV formatting (elastic#78849) [Actions] Adds a "Test Connector" button on the Connectors List to make discovery of the Test tab easier (elastic#78746) [Discover] Fix functional time picker test permissions (elastic#78564) [ML] Fixing module datafeed overrides (elastic#78925) Adds some missing licenses to the CSV export (elastic#78719) [dev/cli] ensure plugins/ and all watch source dirs exist (elastic#78973) [Lens] Stop using scripted metric to collect telemetry (elastic#78687) [Lens] fix wrong message in fields accordion (elastic#78924) ...
cchaos
added a commit
that referenced
this pull request
Sep 30, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Header
1. Fixed placement of mobile search button
2. Fixed search popover from scrolling away with the page
KQL Bar
3. Fixed responsive size of date picker
4. Fixed suggestion popover from overlapping the header
Discover
5. Fixed spacing in save popover
Other responsive fixes
6. Drilldowns flyout
7. Alerts action menu
I don't have an after, because I don't know how to setup the TLS 🤷. But this is what it was before and I just removed the responsive layout.
Management
8. Fix padding for bottom bar in Advanced Settings
The EuiBottomBar adds padding to the body element, but the way the Management layout is setup, this didn't actually add any affordance for the bottom bar, so I had to add a custom body class and padding via CSS.
Checklist
Delete any items that are not applicable to this PR.