chore(NA): include hjson as a prod dependency#78941
Merged
mistic merged 2 commits intoelastic:masterfrom Sep 30, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
pheyos
reviewed
Sep 30, 2020
Member
There was a problem hiding this comment.
There's also a "@types/hjson": "^2.4.2", entry in the dev dependencies. Do we need to move this one to production as well?
Edit: @tylersmalley clarified on slack that the types shouldn't be in prod.
Member
|
Latest 8.0.0. snapshot doesn't start due to this. |
Member
|
@pheyos looks like only the |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💛 Build succeeded, but was flaky
Test FailuresChrome X-Pack UI Functional Tests.x-pack/test/functional_with_es_ssl/apps/triggers_actions_ui/alerts·ts.Actions and Triggers app alerts should delete all selectionStandard OutStack TraceMetrics [docs]distributable file count
History
To update your PR or re-run it, just comment with: |
Contributor
Author
|
7.x: bdc5bf8 |
mistic
added a commit
to mistic/kibana
that referenced
this pull request
Sep 30, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mistic
added a commit
that referenced
this pull request
Sep 30, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 30, 2020
* master: (97 commits) [Actions] Adds a "Test Connector" button on the Connectors List to make discovery of the Test tab easier (elastic#78746) [Discover] Fix functional time picker test permissions (elastic#78564) [ML] Fixing module datafeed overrides (elastic#78925) Adds some missing licenses to the CSV export (elastic#78719) [dev/cli] ensure plugins/ and all watch source dirs exist (elastic#78973) [Lens] Stop using scripted metric to collect telemetry (elastic#78687) [Lens] fix wrong message in fields accordion (elastic#78924) [Enterprise Search][App Search] Credentials Logic updates (elastic#78644) [Monitoring] Disk usage alerting (elastic#75419) [SECURITY_SOLUTION] Trusted apps list expand/collapse details (elastic#78601) Update content on interstitial page (elastic#78881) chore(NA): include hjson as a prod dependency (elastic#78941) Fix empty meta fields input in Advanced Settings (elastic#78576) [Lens] Maintain order of operations in dimension panel (elastic#78864) Fix plugin doc title (elastic#78880) load apm-rum agent lazily (elastic#78760) [ML] Skip full ML access permission test Optimize charts plugin (elastic#78922) ui_actions service initial docs (elastic#78902) skip failing suite (elastic#78942) ...
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #78546
hjsonshould now be a prod dependency.