Fix empty meta fields input in Advanced Settings #78576
Fix empty meta fields input in Advanced Settings #78576kertal merged 4 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
flash1293
left a comment
There was a problem hiding this comment.
Tested and this LGTM. Note that if an advanced setting is already saved with the empty string array, this won't fix it - it's just about newly edited settings.
I checked current settings of type array and I don't think it's a valid use case to have a single empty string value for them: context:tieBreakerFields, defaultColumns, metaFields, securitySolution:defaultIndex, xpackDashboardMode:roles
This is a good point, adding this to the description of the PR, thx!
thx for the investigation! |
|
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]async chunks size
History
To update your PR or re-run it, just comment with: |
* master: (97 commits) [Actions] Adds a "Test Connector" button on the Connectors List to make discovery of the Test tab easier (elastic#78746) [Discover] Fix functional time picker test permissions (elastic#78564) [ML] Fixing module datafeed overrides (elastic#78925) Adds some missing licenses to the CSV export (elastic#78719) [dev/cli] ensure plugins/ and all watch source dirs exist (elastic#78973) [Lens] Stop using scripted metric to collect telemetry (elastic#78687) [Lens] fix wrong message in fields accordion (elastic#78924) [Enterprise Search][App Search] Credentials Logic updates (elastic#78644) [Monitoring] Disk usage alerting (elastic#75419) [SECURITY_SOLUTION] Trusted apps list expand/collapse details (elastic#78601) Update content on interstitial page (elastic#78881) chore(NA): include hjson as a prod dependency (elastic#78941) Fix empty meta fields input in Advanced Settings (elastic#78576) [Lens] Maintain order of operations in dimension panel (elastic#78864) Fix plugin doc title (elastic#78880) load apm-rum agent lazily (elastic#78760) [ML] Skip full ML access permission test Optimize charts plugin (elastic#78922) ui_actions service initial docs (elastic#78902) skip failing suite (elastic#78942) ...
Summary
The advanced settings input array input converted an empty field to an array with a single element
['']. This led to the following in Discover:
2. Have a look at Discover, there's a unknown field nowThis PR converts an empty input to an empty array, so this is fixed.
Note: if an advanced setting is already saved with the empty string array, this won't fix it - it has to be manually changed by editing the setting
Fixes #58446
Checklist