[ES-ARCHIVER] Fix bug when query flag is empty#77983
Merged
cnasikas merged 1 commit intoelastic:masterfrom Sep 22, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
dgieselaar
reviewed
Sep 21, 2020
| const query = flags.query; | ||
| let parsedQuery; | ||
| if (typeof query === 'string') { | ||
| if (typeof query === 'string' && query.length > 0) { |
Contributor
There was a problem hiding this comment.
This can perhaps be simplified to if (!query) {}, but I also like the explicitness of what you have.
Member
Author
There was a problem hiding this comment.
Thanks! I can change it to your proposal. It's up to you :)
dgieselaar
approved these changes
Sep 21, 2020
Contributor
dgieselaar
left a comment
There was a problem hiding this comment.
LGTM, will defer to ops for a final decision ofc.
Contributor
💚 Build SucceededBuild metrics
To update your PR or re-run it, just comment with: |
jbudz
approved these changes
Sep 21, 2020
cnasikas
added a commit
to cnasikas/kibana
that referenced
this pull request
Sep 22, 2020
cnasikas
added a commit
that referenced
this pull request
Sep 22, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 22, 2020
* master: (45 commits) [CSM] Use stacked chart for page views (elastic#78042) [Enterprise Search] Fix various plugin states when app has error connecting to Enterprise Search (elastic#78091) Remove service map beta badge (elastic#78039) [Enterprise Search] Rename "telemetry" to "stats" (elastic#78124) [Alerting] optimize calculation of unmuted alert instances (elastic#78021) call .destroy on ace when react component unmounts (elastic#78132) [Ingest Manager] Fix agent action acknowledgement (elastic#78089) [Upgrade Assistant] Rename "telemetry" to "stats" (elastic#78127) [Security Solution] Refactor Hosts Kpi to use Search Strategy (elastic#77606) Bump backport to 5.6.0 (elastic#78097) [Actions] adds a Test Connector tab in the Connectors list (elastic#77365) [Uptime] Improve ping chart axis (elastic#77992) [TSVB] Fields dropdowns are not populated if one of the indices is missing (elastic#77363) [UiActions] Remove duplicate apply filter action (elastic#77485) [APM] Use transaction metrics for transaction error rate (elastic#78009) [ES-ARCHIVER] Fix bug when query flag is empty (elastic#77983) Edit UI text strings in Integrations and Fleet tabs (elastic#75837) [baseline capture] switch to large workers (elastic#78109) [SECURITY_SOLUTION] list UI is backwards compatible (elastic#77956) [Mappings editor] Add support for point field type (elastic#77543) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug where you get an error if you do not pass the
queryflag. This is happening because thequeryflag, if not provided, defaults to an empty string andtypeof query === 'stringis alwaystrue.Steps to reproduce:
node scripts/es_archiver save your_name ".kibana"Error:
--query should be valid JSONChecklist
Delete any items that are not applicable to this PR.
For maintainers