[TSVB] Fields dropdowns are not populated if one of the indices is missing by DianaDerevyankina · Pull Request #77363 · elastic/kibana

DianaDerevyankina · 2020-09-14T15:21:37Z

Summary

It's a fix for the issue of not populated dropdown fields when comma-separated index patterns contain a missing index

If one or some of the index patterns are missing, the time field dropdown shows fields for the other existent index patterns

Visualization with the time field chosen:

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

sulemanof · 2020-09-15T13:32:21Z

src/plugins/vis_type_timeseries/server/lib/get_fields.ts

+  let indexPatternString = indexPattern;
+
+  if (!indexPatternString) {
+    const index = await reqFacade.getUiSettingsService().get('defaultIndex');


This will return a default index id, e.x. ff959d40-b880-11e8-a6d9-e546fe2bba5f.
To receive an index title, you should get an actual index via saveObjectsClient service as in getIndexPatternObject helper

You could literally go with

if (!indexPatternString) { const object = await getIndexPatternObject(reqFacade, indexPattern); indexPatternString = object.indexPatternString; }

or you could use the data plugin indexPatternsService, where there are getDefaut function to retrieve the default index directly. I think this is a better variant.

sulemanof

Tested and works well! LGTM
Left a comment about translation.
Could you please add more PR description ?

sulemanof · 2020-09-17T10:46:14Z

src/plugins/vis_type_timeseries/public/application/components/visualization.js

  const error = _.get(visData, `${model.id}.error`);
+  if (_.get(error, 'error.type') === 'index_not_found_exception') {
+    const index = _.get(error, 'error.index');
+    error.message = `Index "${index}" is missing`;


Would be great to use translations here:

Suggested change

error.message = `Index "${index}" is missing`;

error.message = i18n.translate('visTypeTimeseries.error.missingIndexErrorMessage', {

defaultMessage: 'Index {index} is missing',

values: { index }

});

Sure, updated the PR and its description

stratoula

LGTM, tested in chrome

# Conflicts: # src/plugins/vis_type_timeseries/server/plugin.ts

sulemanof

Tested again after resolving the merge conflict. LGTM 👍

elasticmachine · 2020-09-18T10:44:47Z

Pinging @elastic/kibana-app (Team:KibanaApp)

DianaDerevyankina · 2020-09-21T08:13:41Z

@elasticmachine merge upstream

kibanamachine · 2020-09-21T09:48:31Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 39c5c20

Build metrics

✅ unchanged

History

💚 Build #75469 succeeded 5ff70cd
💚 Build #75152 succeeded 3524b27
💚 Build #74849 succeeded 89de6fa
💚 Build #74303 succeeded 031e90b
💔 Build #74177 failed 14cd01c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

stratoula

Reviewed again, LGTM

alexwizp

LGTM! Thank you

lizozom

LGTM

Linking the docs on allow_no_indices for reference on what this parameter does.

…ssing (elastic#77363) * Fields dropdowns are not populated if one of the indices is missing * Fix tests and accept api changes * Add indexPatternsService to get default index pattern * Replace simple error message string with i18n translation * Remove unnecessary displaying error code Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…ssing (#77363) (#78123) * Fields dropdowns are not populated if one of the indices is missing * Fix tests and accept api changes * Add indexPatternsService to get default index pattern * Replace simple error message string with i18n translation * Remove unnecessary displaying error code Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (45 commits) [CSM] Use stacked chart for page views (elastic#78042) [Enterprise Search] Fix various plugin states when app has error connecting to Enterprise Search (elastic#78091) Remove service map beta badge (elastic#78039) [Enterprise Search] Rename "telemetry" to "stats" (elastic#78124) [Alerting] optimize calculation of unmuted alert instances (elastic#78021) call .destroy on ace when react component unmounts (elastic#78132) [Ingest Manager] Fix agent action acknowledgement (elastic#78089) [Upgrade Assistant] Rename "telemetry" to "stats" (elastic#78127) [Security Solution] Refactor Hosts Kpi to use Search Strategy (elastic#77606) Bump backport to 5.6.0 (elastic#78097) [Actions] adds a Test Connector tab in the Connectors list (elastic#77365) [Uptime] Improve ping chart axis (elastic#77992) [TSVB] Fields dropdowns are not populated if one of the indices is missing (elastic#77363) [UiActions] Remove duplicate apply filter action (elastic#77485) [APM] Use transaction metrics for transaction error rate (elastic#78009) [ES-ARCHIVER] Fix bug when query flag is empty (elastic#77983) Edit UI text strings in Integrations and Fleet tabs (elastic#75837) [baseline capture] switch to large workers (elastic#78109) [SECURITY_SOLUTION] list UI is backwards compatible (elastic#77956) [Mappings editor] Add support for point field type (elastic#77543) ...

Fields dropdowns are not populated if one of the indices is missing

14cd01c

DianaDerevyankina added Feature:TSVB TSVB (Time Series Visual Builder) v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 14, 2020

DianaDerevyankina requested a review from sulemanof September 14, 2020 15:21

DianaDerevyankina self-assigned this Sep 14, 2020

DianaDerevyankina changed the title ~~Fields dropdowns are not populated if one of the indices is missing~~ [TSVB] Fields dropdowns are not populated if one of the indices is missing Sep 14, 2020

DianaDerevyankina added 2 commits September 14, 2020 22:47

Merge branch 'DianaDerevyankina' into Diana/73987

5cc1b79

Fix tests and accept api changes

031e90b

sulemanof reviewed Sep 15, 2020

View reviewed changes

DianaDerevyankina added 2 commits September 16, 2020 18:16

Merge branch 'DianaDerevyankina' into Diana/73987

1c0b314

Add indexPatternsService to get default index pattern

89de6fa

sulemanof approved these changes Sep 17, 2020

View reviewed changes

DianaDerevyankina added 2 commits September 17, 2020 14:03

Merge branch 'DianaDerevyankina' into Diana/73987

91e9e5d

Replace simple error message string with i18n translation

3524b27

DianaDerevyankina requested a review from stratoula September 17, 2020 14:04

stratoula approved these changes Sep 18, 2020

View reviewed changes

DianaDerevyankina added 2 commits September 18, 2020 10:47

Merge branch 'DianaDerevyankina' into Diana/73987

557776e

# Conflicts: # src/plugins/vis_type_timeseries/server/plugin.ts

Remove unnecessary displaying error code

5ff70cd

sulemanof marked this pull request as ready for review September 18, 2020 10:43

sulemanof requested a review from a team September 18, 2020 10:43

sulemanof requested a review from a team as a code owner September 18, 2020 10:43

sulemanof approved these changes Sep 18, 2020

View reviewed changes

DianaDerevyankina added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Sep 18, 2020

Merge branch 'master' into Diana/73987

39c5c20

stratoula approved these changes Sep 21, 2020

View reviewed changes

alexwizp approved these changes Sep 21, 2020

View reviewed changes

lizozom approved these changes Sep 22, 2020

View reviewed changes

DianaDerevyankina merged commit ed7a630 into elastic:master Sep 22, 2020

DianaDerevyankina mentioned this pull request Sep 22, 2020

[7.x] [TSVB] Fields dropdowns are not populated if one of the indices is missing (#77363) #78123

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TSVB] Fields dropdowns are not populated if one of the indices is missing#77363

[TSVB] Fields dropdowns are not populated if one of the indices is missing#77363
DianaDerevyankina merged 10 commits intoelastic:masterfrom
DianaDerevyankina:Diana/73987

DianaDerevyankina commented Sep 14, 2020 •

edited

Loading

Uh oh!

sulemanof Sep 15, 2020

Uh oh!

sulemanof left a comment

Uh oh!

sulemanof Sep 17, 2020

Uh oh!

DianaDerevyankina Sep 17, 2020

Uh oh!

stratoula left a comment

Uh oh!

sulemanof left a comment

Uh oh!

elasticmachine commented Sep 18, 2020

Uh oh!

DianaDerevyankina commented Sep 21, 2020

Uh oh!

kibanamachine commented Sep 21, 2020

Uh oh!

stratoula left a comment

Uh oh!

alexwizp left a comment

Uh oh!

lizozom left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

-    error.message = `Index "${index}" is missing`;
+    error.message = i18n.translate('visTypeTimeseries.error.missingIndexErrorMessage', {
+      defaultMessage: 'Index {index} is missing',
+      values: { index }
+    });

Conversation

DianaDerevyankina commented Sep 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

It's a fix for the issue of not populated dropdown fields when comma-separated index patterns contain a missing index

Checklist

For maintainers

Uh oh!

sulemanof Sep 15, 2020

Choose a reason for hiding this comment

Uh oh!

sulemanof left a comment

Choose a reason for hiding this comment

Uh oh!

sulemanof Sep 17, 2020

Choose a reason for hiding this comment

Uh oh!

DianaDerevyankina Sep 17, 2020

Choose a reason for hiding this comment

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

sulemanof left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Sep 18, 2020

Uh oh!

DianaDerevyankina commented Sep 21, 2020

Uh oh!

kibanamachine commented Sep 21, 2020

💚 Build Succeeded

Build metrics

History

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

alexwizp left a comment

Choose a reason for hiding this comment

Uh oh!

lizozom left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

DianaDerevyankina commented Sep 14, 2020 •

edited

Loading