[discuss][UiActions] Remove duplicate apply filter action? #77485
Merged
Dosant merged 3 commits intoelastic:masterfrom Sep 22, 2020
Merged
[discuss][UiActions] Remove duplicate apply filter action? #77485Dosant merged 3 commits intoelastic:masterfrom
Dosant merged 3 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
streamich
approved these changes
Sep 16, 2020
Contributor
Author
|
@ppisljar, I'll wait for you to confirm before merging, |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
page load bundle size
History
To update your PR or re-run it, just comment with: |
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Sep 22, 2020
Removing unused action
Dosant
added a commit
that referenced
this pull request
Sep 22, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 22, 2020
* master: (45 commits) [CSM] Use stacked chart for page views (elastic#78042) [Enterprise Search] Fix various plugin states when app has error connecting to Enterprise Search (elastic#78091) Remove service map beta badge (elastic#78039) [Enterprise Search] Rename "telemetry" to "stats" (elastic#78124) [Alerting] optimize calculation of unmuted alert instances (elastic#78021) call .destroy on ace when react component unmounts (elastic#78132) [Ingest Manager] Fix agent action acknowledgement (elastic#78089) [Upgrade Assistant] Rename "telemetry" to "stats" (elastic#78127) [Security Solution] Refactor Hosts Kpi to use Search Strategy (elastic#77606) Bump backport to 5.6.0 (elastic#78097) [Actions] adds a Test Connector tab in the Connectors list (elastic#77365) [Uptime] Improve ping chart axis (elastic#77992) [TSVB] Fields dropdowns are not populated if one of the indices is missing (elastic#77363) [UiActions] Remove duplicate apply filter action (elastic#77485) [APM] Use transaction metrics for transaction error rate (elastic#78009) [ES-ARCHIVER] Fix bug when query flag is empty (elastic#77983) Edit UI text strings in Integrations and Fleet tabs (elastic#75837) [baseline capture] switch to large workers (elastic#78109) [SECURITY_SOLUTION] list UI is backwards compatible (elastic#77956) [Mappings editor] Add support for point field type (elastic#77543) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I noticed that there are 2 different
applyFilterActions:Looks like 2nd one is not used. Probably usage was dropped somewhere along NP refactoring's and all apply filter functionality is based on 1st action.
@ppisljar explained the idea behind first:
This idea makes sense, but it is not how it is implemented now.
Since these two actions were confusing there are two options:
Because 2nd action is not used, there seem to be no real use case for it now and to make it work some additional work is needed, I'd propose to just remove it for now and get back to this pattern latter.