[TSVB] Show tooltip on external pointer events by sulemanof · Pull Request #77306 · elastic/kibana

sulemanof · 2020-09-14T10:11:11Z

Summary

Show tooltip on external pointer events in TSVB chart.

Fixes #76954

The regression was caused by this change in elastic-charts.

But with the change, TSVB charts do not work the same way as in 7.8:

prior to 7.9 only the Vertical cursor parallel to x axis where shown in external chart
now the whole tooltip is visible:

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

For maintainers

This was checked for breaking API changes and was labeled appropriately

sulemanof · 2020-09-14T10:28:04Z

I would kindly ask @markov00 & @nickofthyme to assist here.
Is there any way to achieve the same behavior as in previous kibana versions?

nickofthyme · 2020-09-14T14:09:47Z

Looking to see if this changed on our side.

nickofthyme · 2020-09-14T14:35:23Z

@sulemanof Yeah looks like the visible: false doesn't show any tooltip rather that showing the highlighted geometry.

Let me put up a PR to fix that.

nickofthyme · 2020-10-06T16:57:34Z

@elasticmachine merge upstream

nickofthyme

@sulemanof sorry for the delay, this should be good to go with the changes from elastic/elastic-charts#817.

nickofthyme · 2020-10-06T17:00:34Z

src/plugins/vis_type_timeseries/public/application/visualizations/views/timeseries/index.js

          type: tooltipMode === 'show_focused' ? TooltipType.Follow : TooltipType.VerticalCursor,
          headerFormatter: tooltipFormatter,
        }}
+        externalPointerEvents={{ tooltip: { visible: true } }}


This option now only controls the tooltip visibility. The crosshair is always shown when using dispatchExternalPointerEvent.

Suggested change

externalPointerEvents={{ tooltip: { visible: true } }}

externalPointerEvents={{ tooltip: { visible: false } }}

…ltip

nickofthyme

LGTM, works as expected.

kibanamachine · 2020-10-07T14:29:24Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 8733a43

Metrics [docs]

async chunks size

id	before	after	diff
`visTypeTimeseries`	1.8MB	1.8MB	+48.0B

History

💔 Build #80205 failed 27f8338
💚 Build #74064 succeeded 21f34e3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elasticmachine · 2020-10-07T15:11:44Z

Pinging @elastic/kibana-app (Team:KibanaApp)

stratoula

Nice! Tested it locally, regression is gone! Thanx @sulemanof and @nickofthyme for taking care of this ❤️

* Show external pointer events in TSVB * Disable tooltip visibility Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

timroes · 2020-10-08T08:27:38Z

@sulemanof @nickofthyme do we have the appropriate elastic charts version on 7.9 to backport this to 7.9? If so I think this should be backported to make it into 7.9.3.

sulemanof · 2020-10-08T09:01:39Z

@sulemanof @nickofthyme do we have the appropriate elastic charts version on 7.9 to backport this to 7.9? If so I think this should be backported to make it into 7.9.3.

We don't have such a version in 7.9 unfortunately..
@nickofthyme do you have any plan to update charts version in 7.9 ?

* Show external pointer events in TSVB * Disable tooltip visibility Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* master: (217 commits) Fix dashboard "snapshot share" is not sharing panel state in view mode (elastic#79837) fix can't edit a scripted field with special char (elastic#79842) [ML] clear selection action (elastic#79834) [TSVB] Show tooltip on external pointer events (elastic#77306) Fixes bug where the same index was being passed in (elastic#79949) Adds date time query and return fields for timestamps and overrides (elastic#79911) [Security Solution][Detections] Reverts rules table tag filter to use AND operator (elastic#79920) add the correct class to truncate the names (elastic#79921) [kbn/optimizer] report limits with ci metrics (elastic#78205) [release notes] extract "dev docs" comment too (elastic#79351) Revert "skips test failing promotion (elastic#79777)" (elastic#79904) share tslib across bundles (elastic#79915) remove entire suite as partial skips aren't doing the trick skip flaky suite (elastic#78689) Skip failing suite (elastic#79522) skip flaky suite (elastic#79910) [es/mappings] remove doc_values from text fields (elastic#79869) remove skipped snapshots skip flaky tests (elastic#79891) chore(NA): add missing branches into backportrc configuration file (elastic#79848) ...

nickofthyme · 2020-10-08T16:13:42Z

@sulemanof created backport with cherry-pick'd fix in @elastic/charts@19.8.3 #80016

* [TSVB] Show tooltip on external pointer events (#77306) * Show external pointer events in TSVB * Disable tooltip visibility Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * update elastic/charts to v19.8.3 Co-authored-by: Daniil Suleiman <31325372+sulemanof@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

Show external pointer events in TSVB

21f34e3

sulemanof changed the title ~~[TSVB] Show external pointer events~~ [TSVB] Show tooltip on external pointer events Sep 14, 2020

sulemanof requested review from markov00 and nickofthyme September 14, 2020 10:27

nickofthyme mentioned this pull request Sep 14, 2020

fix: show crosshairs for external pointer events elastic/elastic-charts#817

Merged

3 tasks

Merge branch 'master' into fix/sync_tsvb_tooltip

27f8338

nickofthyme reviewed Oct 6, 2020

View reviewed changes

sulemanof added 2 commits October 7, 2020 15:16

Merge remote-tracking branch 'upstream/master' into fix/sync_tsvb_too…

d7742be

…ltip

Disable tooltip visibility

8733a43

sulemanof added bug Fixes for quality problems that affect the customer experience Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v7.10.0 v7.11.0 v8.0.0 labels Oct 7, 2020

nickofthyme approved these changes Oct 7, 2020

View reviewed changes

sulemanof requested a review from stratoula October 7, 2020 15:11

sulemanof marked this pull request as ready for review October 7, 2020 15:11

sulemanof requested a review from a team October 7, 2020 15:11

stratoula approved these changes Oct 7, 2020

View reviewed changes

sulemanof merged commit 7c1e809 into elastic:master Oct 8, 2020

sulemanof deleted the fix/sync_tsvb_tooltip branch October 8, 2020 07:58

sulemanof mentioned this pull request Oct 8, 2020

[7.x] [TSVB] Show tooltip on external pointer events (#77306) #79968

Merged

sulemanof mentioned this pull request Oct 8, 2020

[7.10] [TSVB] Show tooltip on external pointer events (#77306) #79969

Merged

nickofthyme mentioned this pull request Oct 8, 2020

[7.9] [TSVB] Show tooltip on external pointer events (#77306) #80016

Merged

sulemanof added v7.9.3 backported labels Oct 9, 2020

fdartayre mentioned this pull request Nov 2, 2020

Vertical cursor is not displayed across Timelion visualizations of a dashboad #82250

Closed

wylieconlon mentioned this pull request Jan 26, 2021

[TSVB] Synced tooltip is not shown in dashboard #89306

Closed

	externalPointerEvents={{ tooltip: { visible: true } }}
	externalPointerEvents={{ tooltip: { visible: false } }}

Conversation

sulemanof commented Sep 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

sulemanof commented Sep 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nickofthyme commented Sep 14, 2020

Uh oh!

nickofthyme commented Sep 14, 2020

Uh oh!

nickofthyme commented Oct 6, 2020

Uh oh!

nickofthyme left a comment

Choose a reason for hiding this comment

Uh oh!

nickofthyme Oct 6, 2020

Choose a reason for hiding this comment

Uh oh!

nickofthyme left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Oct 7, 2020

💚 Build Succeeded

Metrics [docs]

async chunks size

History

Uh oh!

elasticmachine commented Oct 7, 2020

Uh oh!

stratoula left a comment

Choose a reason for hiding this comment

Uh oh!

timroes commented Oct 8, 2020

Uh oh!

sulemanof commented Oct 8, 2020

Uh oh!

nickofthyme commented Oct 8, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sulemanof commented Sep 14, 2020 •

edited

Loading

sulemanof commented Sep 14, 2020 •

edited

Loading