[kbn/optimizer] report limits with ci metrics by spalger · Pull Request #78205 · elastic/kibana

spalger · 2020-09-22T19:35:50Z

In an attempt to prevent bundles from unexpectedly growing in size we would like to implement hard limits on the size of bundles. To assist in that effort we're going to start by giving every bundle a 5kb budget for increasing, and will work to clamp down the limit over time. Ideally we will get to a point where all page load bundles are less than 200kb.

To accomplish this we have a limits.yml file that describes the max size in bytes for each bundle. These limits are sent to the ci-stats service when metrics are reported along with the current size, allowing the service to set a failed commit status on the PR as well as report the remaining budget for each bundle so we can track this stat over time as well.

The limits file can be validate locally by running

node scripts/build_kibana_platform_plugins --validate-limits

The limits file can also be regenerated locally by running

node scripts/build_kibana_platform_plugins --update-limits

which runs a build locally and writes the sizes + 5kb to limits.yml

vars/githubPr.groovy

spalger · 2020-10-01T22:57:07Z

Example comment from CI with failures:

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 4f6a5ee0bc327ee0afe0bc97d88e0b864f0a0de0
Pipeline Steps (look for red circles / failed steps)
Interpreting CI Failures

Metrics [docs]

@kbn/optimizer bundle module count

id	value	diff	baseline
`timelion`	103	+1	102

async chunks size

id	value	diff	baseline
`enterpriseSearch`	430.1KB	+1.0B	430.1KB
`timelion`	455.5KB	+1.0B	455.5KB
total		+2.0B

distributable file count

id	value	diff	baseline
`default`	45873	+43	45830
`oss`	26589	+36	26553

page load bundle size

id	value	diff	baseline	errors
`beatsManagement`	439.8KB	+723.0B	439.1KB
`ingestManager`	510.5KB	+723.0B	509.8KB
`timelion`	23.1KB	+8.5KB	14.6KB	❌ 3.6KB over limit
`upgradeAssistant`	64.8KB	+1.0B	64.8KB
total		+9.9KB

History

💔 Build #78496 failed d7e3a9627df1cc44a754392ad8b409c79d4c10da
💔 Build #77220 failed 74511eb8049ce0074f41d6329b908bf2eef13d61
💔 Build #77192 failed 9648b73a6cd8ce6a04dcbc80a34751a080c434ed
💚 Build #77187 succeeded 30f41a9bc2de5df53d5bf0b827021a5f4b025652
💚 Build #77181 succeeded d0fcd8ac859a6b0763901d8c52f4d18fd5d0bd20

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elasticmachine · 2020-10-01T23:31:51Z

Pinging @elastic/kibana-operations (Team:Operations)

brianseeders · 2020-10-02T16:37:45Z

@kibanamachine merge upstream

…dle-metric-limits

spalger · 2020-10-05T19:51:47Z

@elasticmachine merge upstream

…dle-metric-limits

packages/kbn-optimizer/src/limits.ts

tylersmalley · 2020-10-07T15:29:38Z

packages/kbn-optimizer/src/optimizer/get_output_stats.ts

+    }
+
+    const ext = Path.extname(filename);
+    if (IGNORED_EXTNAME.includes(ext)) {


Would it be better to specifically include js instead of maintain an ignore list?

The files aren't just js files, they include images, fonts, etc, so I think the ignore list is more appropriate.

tylersmalley

LGTM

tylersmalley · 2020-10-07T15:33:39Z

@elasticmachine merge upstream

Failure caused by #79725

…dle-metric-limits

…ibana into implement/bundle-metric-limits

kibanamachine · 2020-10-07T22:40:40Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 1b303f6

Metrics [docs]

✅ unchanged

History

💔 Build #80491 failed 0db8476
💔 Build #80142 failed a4f6fd7
💚 Build #79948 succeeded 1a5b08f
💔 Build #79864 failed c323ffb459f89215db16ae0f66ae14eddcc18985
💔 Build #79829 failed 0d579ca

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [kbn/optimizer] report limits with ci metrics (#78205) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * update bundle limits for 7.x branch Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* [kbn/optimizer] report limits with ci metrics (#78205) Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com> * update bundle limits for 7.10 Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* master: (217 commits) Fix dashboard "snapshot share" is not sharing panel state in view mode (elastic#79837) fix can't edit a scripted field with special char (elastic#79842) [ML] clear selection action (elastic#79834) [TSVB] Show tooltip on external pointer events (elastic#77306) Fixes bug where the same index was being passed in (elastic#79949) Adds date time query and return fields for timestamps and overrides (elastic#79911) [Security Solution][Detections] Reverts rules table tag filter to use AND operator (elastic#79920) add the correct class to truncate the names (elastic#79921) [kbn/optimizer] report limits with ci metrics (elastic#78205) [release notes] extract "dev docs" comment too (elastic#79351) Revert "skips test failing promotion (elastic#79777)" (elastic#79904) share tslib across bundles (elastic#79915) remove entire suite as partial skips aren't doing the trick skip flaky suite (elastic#78689) Skip failing suite (elastic#79522) skip flaky suite (elastic#79910) [es/mappings] remove doc_values from text fields (elastic#79869) remove skipped snapshots skip flaky tests (elastic#79891) chore(NA): add missing branches into backportrc configuration file (elastic#79848) ...

spalger added Team:Operations Kibana-Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 22, 2020

spalger force-pushed the implement/bundle-metric-limits branch 5 times, most recently from 1724549 to d0fcd8a Compare September 25, 2020 03:24

spalger commented Sep 25, 2020

View reviewed changes

vars/githubPr.groovy Outdated Show resolved Hide resolved

spalger force-pushed the implement/bundle-metric-limits branch from d7e3a96 to 4f6a5ee Compare October 1, 2020 00:30

spalger mentioned this pull request Oct 1, 2020

Upgraded EUI to v29.3.0 #78870

Merged

spalger force-pushed the implement/bundle-metric-limits branch from 4f6a5ee to e55a260 Compare October 1, 2020 21:48

spalger force-pushed the implement/bundle-metric-limits branch from e55a260 to 5e091e4 Compare October 1, 2020 23:00

spalger marked this pull request as ready for review October 1, 2020 23:31

spalger requested a review from a team as a code owner October 1, 2020 23:31

elastic deleted a comment from kibanamachine Oct 2, 2020

spalger force-pushed the implement/bundle-metric-limits branch from 5602d8d to daf6578 Compare October 4, 2020 08:17

[kbn/optimizer] report limits with ci metrics

087c85f

spalger force-pushed the implement/bundle-metric-limits branch from daf6578 to 087c85f Compare October 4, 2020 08:20

spalger added 3 commits October 5, 2020 11:54

Merge branch 'master' of github.com:elastic/kibana into implement/bun…

c81f8a8

…dle-metric-limits

update limits with latest values from master

fb920aa

remove extra Bundle field in limits file

0d579ca

spalger added 2 commits October 5, 2020 15:19

update bundle limits with lastest from master

0ac0ca9

Merge branch 'master' of github.com:elastic/kibana into implement/bun…

6861c4a

…dle-metric-limits

spalger added 3 commits October 5, 2020 15:54

add the ability to generate limits.yml from a local build

e86c16d

Merge branch 'master' of github.com:elastic/kibana into implement/bun…

df9bd72

…dle-metric-limits

update limits.yml

1a5b08f

spalger force-pushed the implement/bundle-metric-limits branch from c323ffb to 1a5b08f Compare October 5, 2020 23:06

spalger added 2 commits October 6, 2020 07:46

Merge branch 'master' of github.com:elastic/kibana into implement/bun…

19c50c2

…dle-metric-limits

update limits with most recent build numbers

a4f6fd7

tylersmalley reviewed Oct 7, 2020

View reviewed changes

packages/kbn-optimizer/src/limits.ts Outdated Show resolved Hide resolved

tylersmalley reviewed Oct 7, 2020

View reviewed changes

tylersmalley approved these changes Oct 7, 2020

View reviewed changes

kibanamachine and others added 5 commits October 7, 2020 11:33

Merge branch 'master' into implement/bundle-metric-limits

74036bc

Merge branch 'master' into implement/bundle-metric-limits

0db8476

Merge branch 'master' of github.com:elastic/kibana into implement/bun…

6050a43

…dle-metric-limits

raise the default budget to prevent breaking master once this is merged

a4e4946

Merge branch 'implement/bundle-metric-limits' of github.com:spalger/k…

1b303f6

…ibana into implement/bundle-metric-limits

spalger merged commit fd066f7 into elastic:master Oct 7, 2020

spalger deleted the implement/bundle-metric-limits branch October 7, 2020 22:43

spalger added the v7.11.0 label Oct 7, 2020

spalger mentioned this pull request Oct 7, 2020

[7.x] [kbn/optimizer] report limits with ci metrics (#78205) #79950

Merged

spalger mentioned this pull request Oct 7, 2020

[7.10] [kbn/optimizer] report limits with ci metrics (#78205) #79951

Merged

Conversation

spalger commented Sep 22, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

spalger commented Oct 1, 2020

💔 Build Failed

Metrics [docs]

@kbn/optimizer bundle module count

async chunks size

distributable file count

page load bundle size

History

Uh oh!

elasticmachine commented Oct 1, 2020

Uh oh!

brianseeders commented Oct 2, 2020

Uh oh!

spalger commented Oct 5, 2020

Uh oh!

Uh oh!

tylersmalley Oct 7, 2020

Choose a reason for hiding this comment

Uh oh!

spalger Oct 7, 2020

Choose a reason for hiding this comment

Uh oh!

tylersmalley left a comment

Choose a reason for hiding this comment

Uh oh!

tylersmalley commented Oct 7, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kibanamachine commented Oct 7, 2020

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

spalger commented Sep 22, 2020 •

edited

Loading

tylersmalley commented Oct 7, 2020 •

edited

Loading