Fix dashboard "snapshot share" is not sharing panel state in view mode#79837
Merged
Dosant merged 1 commit intoelastic:masterfrom Oct 8, 2020
Merged
Fix dashboard "snapshot share" is not sharing panel state in view mode#79837Dosant merged 1 commit intoelastic:masterfrom
Dosant merged 1 commit intoelastic:masterfrom
Conversation
flash1293
approved these changes
Oct 7, 2020
Contributor
flash1293
left a comment
There was a problem hiding this comment.
Tested in Chrome and works as expected, thanks for the fix!
ThomThomson
approved these changes
Oct 7, 2020
Contributor
There was a problem hiding this comment.
Code and behaviours LGTM!
A bit of trivia to be aware of: seems like after loading a snapshot link in view mode, panels are removed from the url - therefore reloading the page will load up the latest version of the saved object.
I would honestly be in favor of totally removing this feature after #71499, but will definitely need more discussion.
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
Oct 8, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Oct 8, 2020
* master: (217 commits) Fix dashboard "snapshot share" is not sharing panel state in view mode (elastic#79837) fix can't edit a scripted field with special char (elastic#79842) [ML] clear selection action (elastic#79834) [TSVB] Show tooltip on external pointer events (elastic#77306) Fixes bug where the same index was being passed in (elastic#79949) Adds date time query and return fields for timestamps and overrides (elastic#79911) [Security Solution][Detections] Reverts rules table tag filter to use AND operator (elastic#79920) add the correct class to truncate the names (elastic#79921) [kbn/optimizer] report limits with ci metrics (elastic#78205) [release notes] extract "dev docs" comment too (elastic#79351) Revert "skips test failing promotion (elastic#79777)" (elastic#79904) share tslib across bundles (elastic#79915) remove entire suite as partial skips aren't doing the trick skip flaky suite (elastic#78689) Skip failing suite (elastic#79522) skip flaky suite (elastic#79910) [es/mappings] remove doc_values from text fields (elastic#79869) remove skipped snapshots skip flaky tests (elastic#79891) chore(NA): add missing branches into backportrc configuration file (elastic#79848) ...
Dosant
added a commit
that referenced
this pull request
Oct 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #66875
I know this might all change soon because of #71499, but still think worth a quick fix