Skip to content

fix: show crosshairs for external pointer events#817

Merged
nickofthyme merged 2 commits intoelastic:masterfrom
nickofthyme:ext-crosshairs
Sep 15, 2020
Merged

fix: show crosshairs for external pointer events#817
nickofthyme merged 2 commits intoelastic:masterfrom
nickofthyme:ext-crosshairs

Conversation

@nickofthyme
Copy link
Copy Markdown
Collaborator

@nickofthyme nickofthyme commented Sep 14, 2020 •
edited
Loading

Summary

Fixes #816
Related to elastic/kibana#77306

If a dispatchExternalPointerEvent is used, the crosshairs now show for the respective pointer value.

externalPointerEvents.tooltip.visible now only controls the tooltip visibility.

To disable crosshairs, don't use dispatchExternalPointerEvent at all.

Checklist

  • Any consumer-facing exports were added to src/index.ts (and stories only import from ../src except for test data & storybook)
  • Proper documentation or storybook story was added for features that require explanation or tutorials
  • Unit tests were updated or added to match the most common scenarios

@nickofthyme nickofthyme added :interactions Interactions related issue regression labels Sep 14, 2020
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 14, 2020

Codecov Report

Merging #817 into master will increase coverage by 0.44%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #817      +/-   ##
==========================================
+ Coverage   74.15%   74.59%   +0.44%     
==========================================
  Files         273      288      +15     
  Lines        9379     9665     +286     
  Branches     2029     2072      +43     
==========================================
+ Hits         6955     7210     +255     
- Misses       2416     2441      +25     
- Partials        8       14       +6
Flag Coverage Δ
#unittests 74.16% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/chart_types/xy_chart/renderer/dom/crosshair.tsx 80.00% <100.00%> (+0.75%) ⬆️
src/mocks/store/store.ts 92.59% <0.00%> (ø)
src/mocks/series/series.ts 88.13% <0.00%> (ø)
src/mocks/series/series_identifiers.ts 100.00% <0.00%> (ø)
src/mocks/specs/index.ts 100.00% <0.00%> (ø)
src/mocks/geometries.ts 86.84% <0.00%> (ø)
src/mocks/theme.ts 100.00% <0.00%> (ø)
src/mocks/series/data.ts 100.00% <0.00%> (ø)
src/mocks/series/index.ts 100.00% <0.00%> (ø)
src/mocks/specs/specs.ts 82.75% <0.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7bb4eb...7de1409. Read the comment docs.

@monfera monfera changed the title feat: show crosshair for external pointer events feat: show crosshairs for external pointer events Sep 14, 2020
markov00
markov00 approved these changes Sep 15, 2020
View reviewed changes
Copy link
Copy Markdown
Collaborator

@markov00 markov00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickofthyme nickofthyme changed the title feat: show crosshairs for external pointer events fix: show crosshairs for external pointer events Sep 15, 2020
@nickofthyme nickofthyme merged commit f591a6a into elastic:master Sep 15, 2020
@nickofthyme nickofthyme deleted the ext-crosshairs branch September 15, 2020 13:40
markov00 pushed a commit that referenced this pull request Sep 16, 2020
@semantic-release-bot
chore(release): 21.3.0 [skip ci]
7aba794 
# [21.3.0](v21.2.0...v21.3.0) (2020-09-16)

### Bug Fixes

* legend dark mode hover color ([#820](#820)) ([5227b2e](5227b2e))

### Features

* cancel brush/click event with escape key ([#819](#819)) ([b599d13](b599d13))
* show crosshair for external pointer events ([#817](#817)) ([f591a6a](f591a6a))
@markov00
Copy link
Copy Markdown
Collaborator

markov00 commented Sep 16, 2020 •
edited by nickofthyme
Loading

🎉 This PR is included in version 22.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@markov00 markov00 added the released Issue released publicly label Sep 16, 2020
@nickofthyme nickofthyme mentioned this pull request Oct 1, 2020
Merged
1 task
nickofthyme added a commit to nickofthyme/elastic-charts that referenced this pull request Oct 8, 2020
@nickofthyme
feat: show crosshair for external pointer events (elastic#817)
25ed03a
@nickofthyme nickofthyme mentioned this pull request Oct 8, 2020
Merged
@markov00 markov00 mentioned this pull request Oct 8, 2020
Closed
nickofthyme added a commit that referenced this pull request Oct 8, 2020
@nickofthyme
fix: show crosshair for external pointer events (#817) (#863)
f253599
markov00 pushed a commit that referenced this pull request Oct 8, 2020
@semantic-release-bot
chore(release): 19.8.3 [skip ci]
1c27da7 
## [19.8.3](v19.8.2...v19.8.3) (2020-10-08)

### Bug Fixes

* show crosshair for external pointer events ([#817](#817)) ([#863](#863)) ([f253599](f253599))
@nickofthyme nickofthyme mentioned this pull request Jan 26, 2021
Closed
2 tasks
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 10, 2022
@semantic-release-bot
chore(release): 21.3.0 [skip ci]
30def62 
# [21.3.0](elastic/elastic-charts@v21.2.0...v21.3.0) (2020-09-16)

### Bug Fixes

* legend dark mode hover color ([opensearch-project#820](elastic/elastic-charts#820)) ([d30c21f](elastic/elastic-charts@d30c21f))

### Features

* cancel brush/click event with escape key ([opensearch-project#819](elastic/elastic-charts#819)) ([5a9f21f](elastic/elastic-charts@5a9f21f))
* show crosshair for external pointer events ([opensearch-project#817](elastic/elastic-charts#817)) ([1721514](elastic/elastic-charts@1721514))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markov00 markov00 markov00 approved these changes

@monfera monfera Awaiting requested review from monfera

Assignees

No one assigned

Labels

:interactions Interactions related issue regression released Issue released publicly

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Show crosshairs on external pointer events

3 participants

@nickofthyme @codecov-commenter @markov00