[Monitoring] Handle no mappings found for sort and collapse fields#77099
Merged
chrisronline merged 6 commits intoelastic:masterfrom Sep 14, 2020
Merged
[Monitoring] Handle no mappings found for sort and collapse fields#77099chrisronline merged 6 commits intoelastic:masterfrom
chrisronline merged 6 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
Contributor
Author
|
@elasticmachine merge upstream |
igoristic
approved these changes
Sep 10, 2020
Contributor
igoristic
left a comment
There was a problem hiding this comment.
Awesome work! Thanks for the fix🏅
Contributor
Author
|
@elasticmachine merge upstream |
1 similar comment
Contributor
Author
|
@elasticmachine merge upstream |
0468961 to
00b6838
Compare
Contributor
Author
|
@igoristic I changed a bit more code here so requested another review |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics@kbn/optimizer bundle module count
page load bundle size
distributable file count
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 15, 2020
* master: (25 commits) [Security Solution] Add unit tests for Network search strategy (elastic#77416) [Alerting] Improves performance of the authorization filter in AlertsClient.find by skipping KQL parsing (elastic#77040) [Ingest Manager] Add route for package installation by upload (elastic#77044) [APM-UI][E2E] filter PRs from the uptime GH team (elastic#77359) [APM] Remove useLocation and some minor route improvements (elastic#76343) [Enterprise Search] Update enterpriseSearchRequestHandler to manage range of errors + add handleAPIErrors helper (elastic#77258) [SECURITY_SOLUTION] Task/hostname policy response ux updates (elastic#76444) Move remaining uses of serviceName away from urlParams (elastic#77248) [Lens] Move configuration popover to flyout (elastic#76046) [Ingest Manager] Manually build Fleet kuery with Node arguments (elastic#76589) skip flaky suite (elastic#59975) Neutral-naming in reporting plugin (elastic#77371) [Enterprise Search] Add UserIcon styles (elastic#77385) [RUM Dashboard] Added loading state to visitor breakdown pie charts (elastic#77201) [Ingest Manager] Fix polling for new agent action (elastic#77339) Remote cluster - Functional UI test to change the superuser to a test_user with limited role (elastic#77212) Stacked headers and navigational search (elastic#72331) [ML] DF Analytics creation wizard: Fixing field loading race condition (elastic#77326) [Monitoring] Handle no mappings found for sort and collapse fields (elastic#77099) Add Lens to Recently Accessed (elastic#77249) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 15, 2020
* master: (293 commits) Fix tsvb filter ration for table (elastic#77272) [Security Solution] Add unit tests for Network search strategy (elastic#77416) [Alerting] Improves performance of the authorization filter in AlertsClient.find by skipping KQL parsing (elastic#77040) [Ingest Manager] Add route for package installation by upload (elastic#77044) [APM-UI][E2E] filter PRs from the uptime GH team (elastic#77359) [APM] Remove useLocation and some minor route improvements (elastic#76343) [Enterprise Search] Update enterpriseSearchRequestHandler to manage range of errors + add handleAPIErrors helper (elastic#77258) [SECURITY_SOLUTION] Task/hostname policy response ux updates (elastic#76444) Move remaining uses of serviceName away from urlParams (elastic#77248) [Lens] Move configuration popover to flyout (elastic#76046) [Ingest Manager] Manually build Fleet kuery with Node arguments (elastic#76589) skip flaky suite (elastic#59975) Neutral-naming in reporting plugin (elastic#77371) [Enterprise Search] Add UserIcon styles (elastic#77385) [RUM Dashboard] Added loading state to visitor breakdown pie charts (elastic#77201) [Ingest Manager] Fix polling for new agent action (elastic#77339) Remote cluster - Functional UI test to change the superuser to a test_user with limited role (elastic#77212) Stacked headers and navigational search (elastic#72331) [ML] DF Analytics creation wizard: Fixing field loading race condition (elastic#77326) [Monitoring] Handle no mappings found for sort and collapse fields (elastic#77099) ...
chrisronline
added a commit
that referenced
this pull request
Sep 15, 2020
…77099) (#77386) * Handle no mappings found for sort and collapse fields * Add comment * Fix sort usage * Ensure we query off MB for new api calls as well Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
Author
|
Backport: 7.x: b71eb50 |
This was referenced Dec 9, 2020
1 task
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #77066
In #76015, we modified a good number of queries to work off of
metricbeat-*indices, based on work done in beats, and thought we had it working perfectly for all scenarios (all data in.monitoring-*, all data inmetricbeat-*, some data in.monitoring-*and some inmetricbeat-*) but we didn't account for oldermetricbeat-*data and how that would affect our changes.With older (and current) versions of Metricbeat, it will create mappings that do not contain any of the new aliases included in elastic/beats#19747 which actually presents an issue in a couple of ways that affect us:
This exception will always happen but because the
allow_partial_search_resultsparameter for the search api in ES is true by default, we only need to worry about this when the indices do not actually exist.The good news is this only presents itself when we attempt to query against a stack products monitoring index that does not exist but it does affect the cluster overview page, as well as some listing pages too (as evident in #77066).
This PR fixes the first way elegantly by leveraging the
unmapped_typefeature - this change is OK because there is no actual data to sort so we just need the error to be suppressed.However, the second way doesn't appear to have a similar elegant solution so we went down a "hack path" for this where we
try/catchour API calls and look for a specific kind of exception. If it's present, we return an empty set instead of throwing the exception. Looking at the git history of the collapse error message, it seems it's been unchanged since field collapsing was first introduced so this check should work for all supported versions of ES.