[Monitoring] Read from metricbeat-* for ES node_stats#76015
Merged
chrisronline merged 5 commits intoelastic:masterfrom Sep 8, 2020
Merged
[Monitoring] Read from metricbeat-* for ES node_stats#76015chrisronline merged 5 commits intoelastic:masterfrom
chrisronline merged 5 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
Contributor
Author
|
@elasticmachine merge upstream |
14 tasks
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metrics
History
To update your PR or re-run it, just comment with: |
igoristic
approved these changes
Sep 8, 2020
Contributor
igoristic
left a comment
There was a problem hiding this comment.
Everything works as expected. Great job!
Contributor
Author
|
Backport: 7.x: 8bde2b3 |
This was referenced Jan 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #73864
This PR adapts the UI code to read from
metricbeat-*indices for queries against ESnode_statstype monitoring documents while preserving existing functionality. This work is based off the changes done on the beats side (elastic/beats#19747) and must be used to test this PR. This PR should work outside of the beats PR, in that existing functionality shouldn't break at all (so it's safe to merge this to master without the beats PR going into master)This is the first PR of several that will adapt the UI code to read from all monitoring document types, and as such, it comes with a little more code changes, mainly the changes necessary to ensure all queries start searching against
metricbeat-*as well as handling the fact thattypeis not aliased.To test:
elasticsearch-xpackmodule and start Metricbeat.node_statsin the response of this query:node_statsin the response to this query: