[SECURITY_SOLUTION] Task/hostname policy response ux updates#76444
Merged
kevinlog merged 6 commits intoelastic:masterfrom Sep 15, 2020
Merged
[SECURITY_SOLUTION] Task/hostname policy response ux updates#76444kevinlog merged 6 commits intoelastic:masterfrom
kevinlog merged 6 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/endpoint-management (Team:Endpoint Management) |
Contributor
Author
|
@elasticmachine merge upstream |
05fd13f to
ae5788d
Compare
parkiino
reviewed
Sep 14, 2020
| }, | ||
| { | ||
| field: 'host_status', | ||
| width: '9%', |
Contributor
There was a problem hiding this comment.
i'm guessing these hardcoded widths is to make sure the values truncate with ellipsis?
Contributor
Author
There was a problem hiding this comment.
it's do restrict some columns that we can predict won't be very long such as the Statuses since they can only have a handful of values. this frees up room for longer columns like hostname, timestamp, etc
parkiino
approved these changes
Sep 14, 2020
paul-tavares
approved these changes
Sep 14, 2020
Contributor
paul-tavares
left a comment
There was a problem hiding this comment.
Left some comments, but all are minor.
Looks good
|
|
||
| PreferenceFormattedDate.displayName = 'PreferenceFormattedDate'; | ||
|
|
||
| export const PreferenceFormattedDateFromPrimitive = ({ |
Contributor
There was a problem hiding this comment.
Since this is a new component under .../public/common, I would suggest adding some jsdocs here
Also - wondering why this was needed - <FormattedDate/> (below) did not handle this use case?
| /** | ||
| * Returns the policy response timestamp from the endpoint after a user modifies a policy. | ||
| */ | ||
| export const policyResponseTimestamp = (state: Immutable<EndpointState>) => |
Contributor
There was a problem hiding this comment.
can you add a response type to this function? Looks like its either the value of @timestamp or false/undefined? Probably should be something like: Immutable<EndpointState>['policyResponse]['@timestamp'] ??
| }, | ||
| { | ||
| field: 'metadata.Endpoint.policy.applied', | ||
| width: '15%', |
Contributor
There was a problem hiding this comment.
+100 points for use of % :)
Contributor
💛 Build succeeded, but was flaky
Test FailuresAccessibility Tests.test/accessibility/apps/discover·ts.Discover Load a new search from the panelStandard OutStack TraceBuild metricsasync chunks size
History
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 15, 2020
* master: (25 commits) [Security Solution] Add unit tests for Network search strategy (elastic#77416) [Alerting] Improves performance of the authorization filter in AlertsClient.find by skipping KQL parsing (elastic#77040) [Ingest Manager] Add route for package installation by upload (elastic#77044) [APM-UI][E2E] filter PRs from the uptime GH team (elastic#77359) [APM] Remove useLocation and some minor route improvements (elastic#76343) [Enterprise Search] Update enterpriseSearchRequestHandler to manage range of errors + add handleAPIErrors helper (elastic#77258) [SECURITY_SOLUTION] Task/hostname policy response ux updates (elastic#76444) Move remaining uses of serviceName away from urlParams (elastic#77248) [Lens] Move configuration popover to flyout (elastic#76046) [Ingest Manager] Manually build Fleet kuery with Node arguments (elastic#76589) skip flaky suite (elastic#59975) Neutral-naming in reporting plugin (elastic#77371) [Enterprise Search] Add UserIcon styles (elastic#77385) [RUM Dashboard] Added loading state to visitor breakdown pie charts (elastic#77201) [Ingest Manager] Fix polling for new agent action (elastic#77339) Remote cluster - Functional UI test to change the superuser to a test_user with limited role (elastic#77212) Stacked headers and navigational search (elastic#72331) [ML] DF Analytics creation wizard: Fixing field loading race condition (elastic#77326) [Monitoring] Handle no mappings found for sort and collapse fields (elastic#77099) Add Lens to Recently Accessed (elastic#77249) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Sep 15, 2020
* master: (293 commits) Fix tsvb filter ration for table (elastic#77272) [Security Solution] Add unit tests for Network search strategy (elastic#77416) [Alerting] Improves performance of the authorization filter in AlertsClient.find by skipping KQL parsing (elastic#77040) [Ingest Manager] Add route for package installation by upload (elastic#77044) [APM-UI][E2E] filter PRs from the uptime GH team (elastic#77359) [APM] Remove useLocation and some minor route improvements (elastic#76343) [Enterprise Search] Update enterpriseSearchRequestHandler to manage range of errors + add handleAPIErrors helper (elastic#77258) [SECURITY_SOLUTION] Task/hostname policy response ux updates (elastic#76444) Move remaining uses of serviceName away from urlParams (elastic#77248) [Lens] Move configuration popover to flyout (elastic#76046) [Ingest Manager] Manually build Fleet kuery with Node arguments (elastic#76589) skip flaky suite (elastic#59975) Neutral-naming in reporting plugin (elastic#77371) [Enterprise Search] Add UserIcon styles (elastic#77385) [RUM Dashboard] Added loading state to visitor breakdown pie charts (elastic#77201) [Ingest Manager] Fix polling for new agent action (elastic#77339) Remote cluster - Functional UI test to change the superuser to a test_user with limited role (elastic#77212) Stacked headers and navigational search (elastic#72331) [ML] DF Analytics creation wizard: Fixing field loading race condition (elastic#77326) [Monitoring] Handle no mappings found for sort and collapse fields (elastic#77099) ...
Contributor
|
Friendly reminder: Looks like this PR hasn’t been backported yet. |
kevinlog
added a commit
to kevinlog/kibana
that referenced
this pull request
Sep 17, 2020
kevinlog
added a commit
that referenced
this pull request
Sep 17, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
Delete any items that are not applicable to this PR.