Move remaining uses of serviceName away from urlParams by smith · Pull Request #77248 · elastic/kibana

smith · 2020-09-10T21:04:27Z

There were a few of these that were either missed or lost in merge conflict resolution.

I went through everything that's used as a path parameter and made sure it wasn't being used anywhere with urlParams.

Previously none of the charts were working, now they all are.

There were a few of these that were either missed or lost in merge conflict resolution. I went through everything that's used as a path parameter and made sure it wasn't being used anywhere with `urlParams`. Previously none of the charts were working, now they all are.

elasticmachine · 2020-09-10T21:04:32Z

Pinging @elastic/apm-ui (Team:apm)

sorenlouv · 2020-09-14T12:41:43Z

x-pack/plugins/apm/public/components/app/RumDashboard/CoreVitals/index.tsx

@@ -20,10 +20,11 @@ const CoreVitalsThresholds = {
 export function CoreVitals() {
  const { urlParams, uiFilters } = useUrlParams();


Should we rename this to make the distinction between path params (that we get from react-router) and query params clear?

Suggested change

const { urlParams, uiFilters } = useUrlParams();

const { queryParams, uiFilters } = useQueryParams();

I'd be fine with doing that but we would have to change it in a hell of a lot of places. I'd prefer doing that change in the next round of changes and leaving it for now.

smith · 2020-09-14T14:23:27Z

@elasticmachine merge upstream

smith · 2020-09-14T15:39:27Z

x-pack/plugins/apm/public/components/shared/DatePicker/index.tsx

 import { isEmpty, isEqual, pickBy } from 'lodash';
 import React from 'react';
-import { useHistory } from 'react-router-dom';
+import { useHistory, useLocation } from 'react-router-dom';


Replacing our useLocation here with the one from react-router-dom. This is also fixed in #76343 but CSM is not using our old location provider.

shahzad31

LGTM CSM changes

smith · 2020-09-14T19:15:53Z

retest

Looks like elastic#67791 introduced a find/replace change that broke APM's e2e tests. This reverts that change.

kibanamachine · 2020-09-15T00:31:03Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: d656820

Build metrics

async chunks size

id	value	diff	baseline
apm	4.9MB	-1.4KB	5.0MB

History

💚 Build #74269 succeeded 6cb620d
💚 Build #74184 succeeded 6cb620d
💚 Build #73868 succeeded 79e47dd

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Move remaining uses of serviceName away from urlParams There were a few of these that were either missed or lost in merge conflict resolution. I went through everything that's used as a path parameter and made sure it wasn't being used anywhere with `urlParams`. Previously none of the charts were working, now they all are. Looks like elastic#67791 introduced a find/replace change that broke APM's e2e tests. This reverts that change.

* Move remaining uses of serviceName away from urlParams There were a few of these that were either missed or lost in merge conflict resolution. I went through everything that's used as a path parameter and made sure it wasn't being used anywhere with `urlParams`. Previously none of the charts were working, now they all are. Looks like #67791 introduced a find/replace change that broke APM's e2e tests. This reverts that change.

* master: (25 commits) [Security Solution] Add unit tests for Network search strategy (elastic#77416) [Alerting] Improves performance of the authorization filter in AlertsClient.find by skipping KQL parsing (elastic#77040) [Ingest Manager] Add route for package installation by upload (elastic#77044) [APM-UI][E2E] filter PRs from the uptime GH team (elastic#77359) [APM] Remove useLocation and some minor route improvements (elastic#76343) [Enterprise Search] Update enterpriseSearchRequestHandler to manage range of errors + add handleAPIErrors helper (elastic#77258) [SECURITY_SOLUTION] Task/hostname policy response ux updates (elastic#76444) Move remaining uses of serviceName away from urlParams (elastic#77248) [Lens] Move configuration popover to flyout (elastic#76046) [Ingest Manager] Manually build Fleet kuery with Node arguments (elastic#76589) skip flaky suite (elastic#59975) Neutral-naming in reporting plugin (elastic#77371) [Enterprise Search] Add UserIcon styles (elastic#77385) [RUM Dashboard] Added loading state to visitor breakdown pie charts (elastic#77201) [Ingest Manager] Fix polling for new agent action (elastic#77339) Remote cluster - Functional UI test to change the superuser to a test_user with limited role (elastic#77212) Stacked headers and navigational search (elastic#72331) [ML] DF Analytics creation wizard: Fixing field loading race condition (elastic#77326) [Monitoring] Handle no mappings found for sort and collapse fields (elastic#77099) Add Lens to Recently Accessed (elastic#77249) ...

* master: (293 commits) Fix tsvb filter ration for table (elastic#77272) [Security Solution] Add unit tests for Network search strategy (elastic#77416) [Alerting] Improves performance of the authorization filter in AlertsClient.find by skipping KQL parsing (elastic#77040) [Ingest Manager] Add route for package installation by upload (elastic#77044) [APM-UI][E2E] filter PRs from the uptime GH team (elastic#77359) [APM] Remove useLocation and some minor route improvements (elastic#76343) [Enterprise Search] Update enterpriseSearchRequestHandler to manage range of errors + add handleAPIErrors helper (elastic#77258) [SECURITY_SOLUTION] Task/hostname policy response ux updates (elastic#76444) Move remaining uses of serviceName away from urlParams (elastic#77248) [Lens] Move configuration popover to flyout (elastic#76046) [Ingest Manager] Manually build Fleet kuery with Node arguments (elastic#76589) skip flaky suite (elastic#59975) Neutral-naming in reporting plugin (elastic#77371) [Enterprise Search] Add UserIcon styles (elastic#77385) [RUM Dashboard] Added loading state to visitor breakdown pie charts (elastic#77201) [Ingest Manager] Fix polling for new agent action (elastic#77339) Remote cluster - Functional UI test to change the superuser to a test_user with limited role (elastic#77212) Stacked headers and navigational search (elastic#72331) [ML] DF Analytics creation wizard: Fixing field loading race condition (elastic#77326) [Monitoring] Handle no mappings found for sort and collapse fields (elastic#77099) ...

smith added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.10.0 labels Sep 10, 2020

smith requested a review from a team September 10, 2020 21:04

smith requested a review from a team as a code owner September 10, 2020 21:04

botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Sep 10, 2020

sorenlouv approved these changes Sep 14, 2020

View reviewed changes

sorenlouv reviewed Sep 14, 2020

View reviewed changes

elasticmachine and others added 3 commits September 14, 2020 08:23

Merge branch 'master' into nls/missing-params

7786faf

Merge remote-tracking branch 'upstream/master' into nls/missing-params

839eb95

Use useLocation

6cb620d

smith commented Sep 14, 2020

View reviewed changes

shahzad31 approved these changes Sep 14, 2020

View reviewed changes

smith added 3 commits September 14, 2020 16:34

Fix APM e2e tests

543e00f

Looks like elastic#67791 introduced a find/replace change that broke APM's e2e tests. This reverts that change.

Remove remaining hashes

439ec17

Merge branch 'nls/feature-fix' into nls/missing-params

d656820

smith merged commit 273806b into elastic:master Sep 15, 2020

smith deleted the nls/missing-params branch September 15, 2020 00:52

smith mentioned this pull request Sep 15, 2020

Fix APM e2e tests #77415

Closed

smith mentioned this pull request Sep 15, 2020

[7.x] Move remaining uses of serviceName away from urlParams (#77248) #77428

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move remaining uses of serviceName away from urlParams#77248

Move remaining uses of serviceName away from urlParams#77248
smith merged 7 commits intoelastic:masterfrom
smith:nls/missing-params

smith commented Sep 10, 2020

Uh oh!

elasticmachine commented Sep 10, 2020

Uh oh!

sorenlouv Sep 14, 2020

Uh oh!

smith Sep 14, 2020

Uh oh!

smith commented Sep 14, 2020

Uh oh!

smith Sep 14, 2020

Uh oh!

shahzad31 left a comment

Uh oh!

smith commented Sep 14, 2020

Uh oh!

kibanamachine commented Sep 15, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		@@ -20,10 +20,11 @@ const CoreVitalsThresholds = {
		export function CoreVitals() {
		const { urlParams, uiFilters } = useUrlParams();

	const { urlParams, uiFilters } = useUrlParams();
	const { queryParams, uiFilters } = useQueryParams();

Conversation

smith commented Sep 10, 2020

Uh oh!

elasticmachine commented Sep 10, 2020

Uh oh!

sorenlouv Sep 14, 2020

Choose a reason for hiding this comment

Uh oh!

smith Sep 14, 2020

Choose a reason for hiding this comment

Uh oh!

smith commented Sep 14, 2020

Uh oh!

smith Sep 14, 2020

Choose a reason for hiding this comment

Uh oh!

shahzad31 left a comment

Choose a reason for hiding this comment

Uh oh!

smith commented Sep 14, 2020

Uh oh!

kibanamachine commented Sep 15, 2020

💚 Build Succeeded

Build metrics

async chunks size

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants