Add support for sharing saved objects to all spaces by jportner · Pull Request #76132 · elastic/kibana

jportner · 2020-08-27T18:01:02Z

Overview

Resolves #69808 and partially resolves #76992.

This PR allows saved objects to be shared to all current and future spaces. See linked issues for details. Primary changes:

Server side

Changed Saved Objects Repository and client wrappers
- Queries support "all spaces"
- Delete operation now deletes objects that are shared to multiple spaces (instead of removing the object from the current space)
- Create and BulkCreate operations now support "initial namespaces" that consumers can specify

Client side

Changed "Shared spaces" column in "Saved Objects" management table to render all spaces correctly
Changed "Share to space" flyout substantially --
- "Share options" provides choice whether to share to selected spaces or all spaces
- Privilege checks conditionally disable options based on what the user is authorized to do
- Additional UI text to allow the user to create a new space (if authorized and none exist), and to describe any hidden spaces that the object may be shared to

Screenshots

These screenshots depict different users:

"Global User" -- this user has access to all spaces
"Default + Alpha User" -- this user has access only to the Default and Alpha spaces
"Default User" -- this user has access only to the Default space

Scenario 1: sharing an object but no other spaces exist

The Global User sees additional text with a link to create a new space. The Default User does not.

Scenario 2: sharing an object after additional spaces have been created

Each user can only see spaces that they are authorized to create saved objects in.

Scenario 3: sharing an object after the object has already been shared to additional spaces

Each user can only see spaces that they are authorized to create saved objects in. The Default + Alpha User and the Default User each see an additional label with a count of hidden spaces, and they see additional text with a link explaining that they lack privileges to see those spaces.

Scenario 4: disabled options and tooltips

If a user does not have global access, they cannot A. share an object to all spaces, or B. unshare an object from all spaces. In each of these cases, UI elements are disabled, and a tooltip renders the appropriate message.

Scenario 5: "Saved Objects" management table

The table will now display an appropriate badge if an object is shared to all spaces. NOTE FOR REVIEWERS: this column is currently disabled by default, see "x-pack/plugins/spaces/public/share_saved_objects_to_space/share_saved_objects_to_space_service.ts" for details.

This method will no longer update a multi-namespace object to remove it from its current namespace. Instead, it will always delete the object, even if that object exists in multiple namespaces. Adds a new `force` option that is required if the object does exist in multiple namespaces.

This is treated as "all namespaces".

Changed how options are passed into tests and how privilege checks are tested so that tests are easier to understand and change.

Removed "Make a copy" button, made "make a copy" inline text a clickable link instead.

No functionality changes, just some refactoring.

One error message was incorrect. Converted to get rid of snapshots.

* Added new checkable card options * Added privilege checks which conditionally disable options * Added descriptive text when unknown spaces are selected

This is necessary when deleting saved objects that exist in multiple namespaces.

Could not figure out why this broke, I did not change this flyout. At any rate, clicking a different part of the radio button fixed it.

legrego

This is working beautifully! I haven't evaluated all of the functional or UI unit tests yet, but I'll leave you with what I have so far

src/core/server/saved_objects/service/lib/search_dsl/query_params.ts

src/core/server/saved_objects/service/saved_objects_client.ts

x-pack/plugins/security/server/authorization/actions/saved_object.test.ts

x-pack/plugins/spaces/public/share_saved_objects_to_space/components/no_spaces_available.tsx

.../plugins/spaces/public/share_saved_objects_to_space/components/selectable_spaces_control.tsx

x-pack/plugins/spaces/public/share_saved_objects_to_space/components/share_to_space_form.tsx

x-pack/plugins/spaces/public/share_saved_objects_to_space/components/share_to_space_flyout.tsx

.../plugins/spaces/public/share_saved_objects_to_space/components/selectable_spaces_control.tsx

x-pack/plugins/spaces/public/share_saved_objects_to_space/components/share_to_space_flyout.tsx

x-pack/plugins/spaces/public/lib/index.ts

x-pack/plugins/spaces/server/lib/utils/namespace.ts

A holdover from the legacy test suite checked to ensure that saved objects could not be created with the `namespace` or `namespaces` fields. This isn't necessary for an API integration test -- the unit test suite covers this scenario -- and it's invalid now that `namespaces` is a valid field. So I removed these test cases.

kibanamachine · 2020-10-03T21:51:00Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 3c0aa6b

Metrics [docs]

@kbn/optimizer bundle module count

id	before	after	diff
`spaces`	224	237	+13

async chunks size

id	before	after	diff
`savedObjectsManagement`	206.9KB	206.9KB	+13.0B

distributable file count

id	before	after	diff
`default`	44116	44115	-1

page load bundle size

id	before	after	diff
`core`	661.1KB	661.2KB	+96.0B
`spaces`	343.9KB	364.2KB	+20.3KB
total			+20.3KB

History

💔 Build #79305 failed 790a437
💛 Build #79043 was flaky 08eaf51
💔 Build #79011 failed c95bd93
💔 Build #78994 failed 64a5b84
💚 Build #78946 succeeded ebea8e4

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

legrego

LGTM!

* master: (128 commits) add core-js production dependency (elastic#79395) Add support for sharing saved objects to all spaces (elastic#76132) [Alerting UI] Display a banner to users when some alerts have failures, added alert statuses column and filters (elastic#79038) load js-yaml lazily (elastic#79092) skip flaky suite (elastic#77278) Fix agentPolicyUpdateEventHandler() to use app context soClient for creation of actions (elastic#79341) [Security Solution] Untitled Timeline created when first action is to add note (elastic#78988) [Security Solutions][Detection Engine] Updates the edit rules page to:wq! only have what is selected for editing (elastic#79233) Cleanup yarn.lock from duplicates (elastic#66617) [kbn/optimizer] implement more efficient auto transpilation for node (elastic#79052) [Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… (elastic#79291) [core/server/plugins] don't run discovery in dev server parent process (take 2) (elastic#79358) [babel/register] remove from build (take 2) (elastic#79379) [Security Solution] Changes rules table tag display (elastic#77102) define integrationTestRoot in config file and use to define screensho… (elastic#79247) Revert "[babel/register] remove from build (elastic#79176)" skip flaky suite (elastic#75241) [Uptime] Synthetics UI (elastic#77960) [Security Solution] [Detections] Only display actions options if user has "read" privileges (elastic#78812) [babel/register] remove from build (elastic#79176) ...

* master: (288 commits) add core-js production dependency (elastic#79395) Add support for sharing saved objects to all spaces (elastic#76132) [Alerting UI] Display a banner to users when some alerts have failures, added alert statuses column and filters (elastic#79038) load js-yaml lazily (elastic#79092) skip flaky suite (elastic#77278) Fix agentPolicyUpdateEventHandler() to use app context soClient for creation of actions (elastic#79341) [Security Solution] Untitled Timeline created when first action is to add note (elastic#78988) [Security Solutions][Detection Engine] Updates the edit rules page to only have what is selected for editing (elastic#79233) Cleanup yarn.lock from duplicates (elastic#66617) [kbn/optimizer] implement more efficient auto transpilation for node (elastic#79052) [Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… (elastic#79291) [core/server/plugins] don't run discovery in dev server parent process (take 2) (elastic#79358) [babel/register] remove from build (take 2) (elastic#79379) [Security Solution] Changes rules table tag display (elastic#77102) define integrationTestRoot in config file and use to define screensho… (elastic#79247) Revert "[babel/register] remove from build (elastic#79176)" skip flaky suite (elastic#75241) [Uptime] Synthetics UI (elastic#77960) [Security Solution] [Detections] Only display actions options if user has "read" privileges (elastic#78812) [babel/register] remove from build (elastic#79176) ...

…79411)

jportner force-pushed the issue-69808-share-to-all-spaces branch from b4dcae9 to f8cef00 Compare August 28, 2020 03:28

jportner force-pushed the issue-69808-share-to-all-spaces branch 2 times, most recently from 1d44a3e to ebaa032 Compare September 11, 2020 02:14

jportner force-pushed the issue-69808-share-to-all-spaces branch 4 times, most recently from fd152f9 to e93f563 Compare September 23, 2020 22:25

jportner linked an issue Sep 28, 2020 that may be closed by this pull request

Improve saved object Copy/Share flyouts when no spaces exist #76992

Closed

jportner force-pushed the issue-69808-share-to-all-spaces branch from e93f563 to 8ebcb3f Compare September 30, 2020 13:54

jportner removed a link to an issue Sep 30, 2020

Improve saved object Copy/Share flyouts when no spaces exist #76992

Closed

jportner mentioned this pull request Sep 30, 2020

Improve saved object Copy/Share flyouts when no spaces exist #76992

Closed

jportner added 11 commits September 30, 2020 13:33

Change SavedObjectsRepository to support '*' namespace string

d978bce

This is treated as "all namespaces".

Small refactor for SecureSavedObjectsClientWrapper unit tests

966f826

Changed how options are passed into tests and how privilege checks are tested so that tests are easier to understand and change.

Change create and bulkCreate to allow initial namespaces

69f6491

Change "share to space" initial warning callout

2e1dabb

Removed "Make a copy" button, made "make a copy" inline text a clickable link instead.

Clean up "Shared spaces" column code, add unit tests

6012e05

No functionality changes, just some refactoring.

Change "Shared spaces" column to display "All spaces" badge

87ed4e8

Clean up "Share to space" routes, add unit tests

8385cdb

No functionality changes, just some refactoring.

Remove dead code

b79aff1

Clean up saved object authorization unit tests / errors

1deac86

One error message was incorrect. Converted to get rid of snapshots.

Change "Share to space" flyout to support sharing to all spaces

a15abff

* Added new checkable card options * Added privilege checks which conditionally disable options * Added descriptive text when unknown spaces are selected

jportner force-pushed the issue-69808-share-to-all-spaces branch from 8ebcb3f to 473dc7d Compare September 30, 2020 17:44

jportner added 2 commits September 30, 2020 14:12

Change saved objects table to use force-delete

e68ecc4

This is necessary when deleting saved objects that exist in multiple namespaces.

Fix "Copy to space" functional test

f855fcd

Could not figure out why this broke, I did not change this flyout. At any rate, clicking a different part of the radio button fixed it.

jportner force-pushed the issue-69808-share-to-all-spaces branch from 473dc7d to f855fcd Compare September 30, 2020 18:12

jportner marked this pull request as ready for review September 30, 2020 18:15

jportner requested review from a team as code owners September 30, 2020 18:15

jportner added the release_note:skip Skip the PR/issue when compiling release notes label Sep 30, 2020

legrego reviewed Oct 1, 2020

View reviewed changes

jportner and others added 4 commits October 1, 2020 17:01

Changes for additional PR review feedback

ebea8e4

Address nits with SSOTAS authz

bc9a57b

Change addToNamespaces and deleteFromNamespaces authZ check

c55dca3

Don't pass start services to all share-to-space components

64a5b84

jportner commented Oct 1, 2020

View reviewed changes

x-pack/plugins/spaces/public/share_saved_objects_to_space/components/share_to_space_flyout.tsx Show resolved Hide resolved

jportner added 3 commits October 1, 2020 20:19

Fix type check

c95bd93

Merge branch 'master' into issue-69808-share-to-all-spaces

cb006b1

Fix API integration tests

08eaf51

legrego self-requested a review October 2, 2020 14:43

Merge branch 'master' into issue-69808-share-to-all-spaces

bdcf5fe

legrego reviewed Oct 2, 2020

View reviewed changes

x-pack/plugins/spaces/public/lib/index.ts Outdated Show resolved Hide resolved

x-pack/plugins/spaces/server/lib/utils/namespace.ts Outdated Show resolved Hide resolved

jportner added 4 commits October 2, 2020 15:10

More changes for PR review feedback

e0ad362

Rename initialNamespaces to namespaces

790a437

Merge branch 'master' into issue-69808-share-to-all-spaces

57ad704

legrego approved these changes Oct 4, 2020

View reviewed changes

jportner merged commit caa5da2 into elastic:master Oct 5, 2020

jportner added the backport pending label Oct 5, 2020

jportner mentioned this pull request Oct 5, 2020

[7.x] Add support for sharing saved objects to all spaces (#76132) #79411

Merged

jportner added a commit to jportner/kibana that referenced this pull request Oct 5, 2020

Add support for sharing saved objects to all spaces (elastic#76132)

b6961d8

jportner added a commit that referenced this pull request Oct 5, 2020

[7.x] Add support for sharing saved objects to all spaces (#76132) (#…

bc114ae

…79411)

jportner added backported and removed backport pending labels Oct 5, 2020

jportner mentioned this pull request Oct 6, 2020

Rename namespaces to initialNamespaces for create operations #79682

Merged

jportner deleted the issue-69808-share-to-all-spaces branch November 20, 2020 18:14

jportner mentioned this pull request Apr 29, 2022

Allow the SavedObjectsClient to work outside of a space #131254

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for sharing saved objects to all spaces#76132

Add support for sharing saved objects to all spaces#76132
jportner merged 29 commits intoelastic:masterfrom
jportner:issue-69808-share-to-all-spaces

jportner commented Aug 27, 2020 •

edited

Loading

Uh oh!

legrego left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Oct 3, 2020

Uh oh!

legrego left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

jportner commented Aug 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

Server side

Client side

Screenshots

Uh oh!

legrego left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

kibanamachine commented Oct 3, 2020

💚 Build Succeeded

Metrics [docs]

@kbn/optimizer bundle module count

async chunks size

distributable file count

page load bundle size

History

Uh oh!

legrego left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

jportner commented Aug 27, 2020 •

edited

Loading