Skip to content

define integrationTestRoot in config file and use to define screensho…#79247

Merged
LeeDr merged 4 commits intoelastic:masterfrom
LeeDr:correctWorkspacePath
Oct 2, 2020
Merged

define integrationTestRoot in config file and use to define screensho…#79247
LeeDr merged 4 commits intoelastic:masterfrom
LeeDr:correctWorkspacePath

Conversation

@LeeDr
Copy link
Copy Markdown

@LeeDr LeeDr commented Oct 2, 2020 •
edited
Loading

Summary

The prior PR ran locally but failed on Jenkins because the sibling path of the checked-out kibana repo on Jenkins isn't integration-test it's elastic+integration-test+master (which is also known as process.env.WORKSPACE).

This PR defines INTEGRATION_TEST_ROOT correctly both locally and on Jenkins.

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@LeeDr LeeDr requested review from dmlemeshko and wayneseymour and removed request for wayneseymour October 2, 2020 03:27
@LeeDr LeeDr added release_note:skip Skip the PR/issue when compiling release notes test-stack-integration v7.10.0 v8.0.0 Team:QA Platform QA t// labels Oct 2, 2020
dmlemeshko
dmlemeshko reviewed Oct 2, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmlemeshko dmlemeshko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! I have several minor points

@LeeDr LeeDr marked this pull request as ready for review October 2, 2020 20:40
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 2, 2020

Pinging @elastic/kibana-qa (Team:QA)

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 2, 2020

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@LeeDr LeeDr merged commit ed10d9f into elastic:master Oct 2, 2020
@LeeDr LeeDr deleted the correctWorkspacePath branch October 2, 2020 22:07
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 5, 2020
@gmmorris
Merge branch 'master' into actions/decouple-actions-from-alertid
d99fe4b 
* master: (128 commits)
  add core-js production dependency (elastic#79395)
  Add support for sharing saved objects to all spaces (elastic#76132)
  [Alerting UI] Display a banner to users when some alerts have failures, added alert statuses column and filters (elastic#79038)
  load js-yaml lazily (elastic#79092)
  skip flaky suite (elastic#77278)
  Fix agentPolicyUpdateEventHandler() to use app context soClient for creation of actions (elastic#79341)
  [Security Solution] Untitled Timeline created when first action is to add note (elastic#78988)
  [Security Solutions][Detection Engine] Updates the edit rules page to:wq! only have what is selected for editing (elastic#79233)
  Cleanup yarn.lock from duplicates (elastic#66617)
  [kbn/optimizer] implement more efficient auto transpilation for node (elastic#79052)
  [Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… (elastic#79291)
  [core/server/plugins] don't run discovery in dev server parent process (take 2) (elastic#79358)
  [babel/register] remove from build (take 2) (elastic#79379)
  [Security Solution] Changes rules table tag display (elastic#77102)
  define integrationTestRoot in config file and use to define screensho… (elastic#79247)
  Revert "[babel/register] remove from build (elastic#79176)"
  skip flaky suite (elastic#75241)
  [Uptime] Synthetics UI (elastic#77960)
  [Security Solution] [Detections] Only display actions options if user has "read" privileges (elastic#78812)
  [babel/register] remove from build (elastic#79176)
  ...
gmmorris added a commit to gmmorris/kibana that referenced this pull request Oct 5, 2020
@gmmorris
Merge branch 'master' into task-manager/health
7b14dff 
* master: (288 commits)
  add core-js production dependency (elastic#79395)
  Add support for sharing saved objects to all spaces (elastic#76132)
  [Alerting UI] Display a banner to users when some alerts have failures, added alert statuses column and filters (elastic#79038)
  load js-yaml lazily (elastic#79092)
  skip flaky suite (elastic#77278)
  Fix agentPolicyUpdateEventHandler() to use app context soClient for creation of actions (elastic#79341)
  [Security Solution] Untitled Timeline created when first action is to add note (elastic#78988)
  [Security Solutions][Detection Engine] Updates the edit rules page to only have what is selected for editing (elastic#79233)
  Cleanup yarn.lock from duplicates (elastic#66617)
  [kbn/optimizer] implement more efficient auto transpilation for node (elastic#79052)
  [Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… (elastic#79291)
  [core/server/plugins] don't run discovery in dev server parent process (take 2) (elastic#79358)
  [babel/register] remove from build (take 2) (elastic#79379)
  [Security Solution] Changes rules table tag display (elastic#77102)
  define integrationTestRoot in config file and use to define screensho… (elastic#79247)
  Revert "[babel/register] remove from build (elastic#79176)"
  skip flaky suite (elastic#75241)
  [Uptime] Synthetics UI (elastic#77960)
  [Security Solution] [Detections] Only display actions options if user has "read" privileges (elastic#78812)
  [babel/register] remove from build (elastic#79176)
  ...
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 6, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79247 or prevent reminders by adding the backport:skip label.

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Oct 6, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 7, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79247 or prevent reminders by adding the backport:skip label.

4 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 8, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79247 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 9, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79247 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 12, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79247 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 13, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79247 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 14, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79247 or prevent reminders by adding the backport:skip label.

3 similar comments
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 15, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79247 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 16, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79247 or prevent reminders by adding the backport:skip label.

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Oct 19, 2020

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 79247 or prevent reminders by adding the backport:skip label.

@marius-dr marius-dr added backport:skip This PR does not require backporting and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Oct 20, 2020
@LeeDr LeeDr removed the backport:skip This PR does not require backporting label Oct 28, 2020
This was referenced Oct 28, 2020
Merged
Merged
LeeDr pushed a commit to LeeDr/kibana that referenced this pull request Oct 28, 2020
define integrationTestRoot in config file and use to define screensho… (
409dae2 
elastic#79247)
LeeDr pushed a commit that referenced this pull request Oct 28, 2020
[7.x] define integrationTestRoot in config file and use to define scr…
8ea6bc4 
…eensho… (#79247) (#81899)
LeeDr pushed a commit that referenced this pull request Oct 28, 2020
[7.10] define integrationTestRoot in config file and use to define sc…
fa0e8b7 
…reensho… (#79247) (#81900)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dmlemeshko dmlemeshko dmlemeshko left review comments

@marius-dr marius-dr Awaiting requested review from marius-dr

+1 more reviewer

@wayneseymour wayneseymour wayneseymour approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:QA Platform QA t// test-stack-integration v7.10.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@LeeDr @elasticmachine @kibanamachine @wayneseymour @dmlemeshko @marius-dr