[Security Solution] Untitled Timeline created when first action is to add note by angorayc · Pull Request #78988 · elastic/kibana

angorayc · 2020-09-30T16:36:52Z

Summary

This PR is to fix
https://github.com/elastic/siem-team/issues/844

Steps to reproduce:

Open a new timeline
Add a note
Go to timelines' page

Before: It creates an untitled timeline and shows in the timelines table.

After: It creates a draft timeline and therefore not displaying it in timelines table until putting a title to current timeline.

This PR fixs https://github.com/elastic/security-team/issues/357 too

Steps to Reproduce

Open browser

Click on Create timeline button.
Click on Favorite icon
Go to timelines' page

Before: It creates an untitled timeline and shows in the timelines table.

After: It creates a draft timeline and therefore not displaying it in timelines table until putting a title to current timeline.

XavierM · 2020-10-01T00:36:15Z

The way we managed that before was to create the timeline first if need it and then adding a note to the timeline in the backend. DId that change?

angorayc · 2020-10-01T15:36:23Z

@XavierM That didn't change and. I also found that it's the status didn't set correctly to draft when a timeline/template was created by saving note. It works well after making sure it creates a draft timeline when saving a note.

So @stephmilovic, I gave up the UI fix and roll back to original behaviour, but I think it works correctly now.

angorayc · 2020-10-01T20:46:03Z

@elasticmachine merge upstream

kibanamachine · 2020-10-02T11:59:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b171e15

Metrics [docs]

✅ unchanged

History

💚 Build #78932 succeeded 9f86eee
💔 Build #78789 failed dc635b7
💔 Build #78770 failed 21fcf02
💔 Build #78381 failed 4872f27

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

angorayc · 2020-10-02T13:20:27Z

This fixes https://github.com/elastic/security-team/issues/357 as well

XavierM

LGTM

… add note (elastic#78988) * init tests * Untitled Timeline created * remove console * fix from server side * set timeline status to draft if created by saving notes * add unit test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (128 commits) add core-js production dependency (elastic#79395) Add support for sharing saved objects to all spaces (elastic#76132) [Alerting UI] Display a banner to users when some alerts have failures, added alert statuses column and filters (elastic#79038) load js-yaml lazily (elastic#79092) skip flaky suite (elastic#77278) Fix agentPolicyUpdateEventHandler() to use app context soClient for creation of actions (elastic#79341) [Security Solution] Untitled Timeline created when first action is to add note (elastic#78988) [Security Solutions][Detection Engine] Updates the edit rules page to:wq! only have what is selected for editing (elastic#79233) Cleanup yarn.lock from duplicates (elastic#66617) [kbn/optimizer] implement more efficient auto transpilation for node (elastic#79052) [Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… (elastic#79291) [core/server/plugins] don't run discovery in dev server parent process (take 2) (elastic#79358) [babel/register] remove from build (take 2) (elastic#79379) [Security Solution] Changes rules table tag display (elastic#77102) define integrationTestRoot in config file and use to define screensho… (elastic#79247) Revert "[babel/register] remove from build (elastic#79176)" skip flaky suite (elastic#75241) [Uptime] Synthetics UI (elastic#77960) [Security Solution] [Detections] Only display actions options if user has "read" privileges (elastic#78812) [babel/register] remove from build (elastic#79176) ...

… add note (#78988) (#79390) * init tests * Untitled Timeline created * remove console * fix from server side * set timeline status to draft if created by saving notes * add unit test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>

* master: (288 commits) add core-js production dependency (elastic#79395) Add support for sharing saved objects to all spaces (elastic#76132) [Alerting UI] Display a banner to users when some alerts have failures, added alert statuses column and filters (elastic#79038) load js-yaml lazily (elastic#79092) skip flaky suite (elastic#77278) Fix agentPolicyUpdateEventHandler() to use app context soClient for creation of actions (elastic#79341) [Security Solution] Untitled Timeline created when first action is to add note (elastic#78988) [Security Solutions][Detection Engine] Updates the edit rules page to only have what is selected for editing (elastic#79233) Cleanup yarn.lock from duplicates (elastic#66617) [kbn/optimizer] implement more efficient auto transpilation for node (elastic#79052) [Ingest Manager] Rename Fleet setup and requirement, Fleet => Central… (elastic#79291) [core/server/plugins] don't run discovery in dev server parent process (take 2) (elastic#79358) [babel/register] remove from build (take 2) (elastic#79379) [Security Solution] Changes rules table tag display (elastic#77102) define integrationTestRoot in config file and use to define screensho… (elastic#79247) Revert "[babel/register] remove from build (elastic#79176)" skip flaky suite (elastic#75241) [Uptime] Synthetics UI (elastic#77960) [Security Solution] [Detections] Only display actions options if user has "read" privileges (elastic#78812) [babel/register] remove from build (elastic#79176) ...

… add note (elastic#78988) * init tests * Untitled Timeline created * remove console * fix from server side * set timeline status to draft if created by saving notes * add unit test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

… add note (#78988) (#79424) * init tests * Untitled Timeline created * remove console * fix from server side * set timeline status to draft if created by saving notes * add unit test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

angorayc added 9 commits September 8, 2020 12:27

init tests

8a638a5

Merge branch 'master' of github.com:elastic/kibana

897eda1

Merge branch 'master' of github.com:elastic/kibana

6508784

Merge branch 'master' of github.com:elastic/kibana

79d5acb

Merge branch 'master' of github.com:elastic/kibana

564ae4b

Merge branch 'master' of github.com:elastic/kibana

e038b0b

Merge branch 'master' of github.com:elastic/kibana

b8b26e6

Merge branch 'master' of github.com:elastic/kibana

62207c4

Merge branch 'master' of github.com:elastic/kibana

85bfbf5

angorayc closed this Sep 30, 2020

Untitled Timeline created

33e218b

angorayc reopened this Sep 30, 2020

remove console

4872f27

angorayc added 2 commits October 1, 2020 15:35

fix from server side

21fcf02

set timeline status to draft if created by saving notes

dc635b7

angorayc added v7.10.0 release_note:skip Skip the PR/issue when compiling release notes labels Oct 1, 2020

angorayc marked this pull request as ready for review October 1, 2020 15:42

angorayc requested review from a team as code owners October 1, 2020 15:42

elasticmachine and others added 3 commits October 1, 2020 16:46

Merge branch 'master' into issue844

9f86eee

add unit test

2f67482

Merge branch 'issue844' of github.com:angorayc/kibana into issue844

b171e15

XavierM approved these changes Oct 3, 2020

View reviewed changes

angorayc merged commit 513ebb5 into elastic:master Oct 3, 2020

angorayc mentioned this pull request Oct 3, 2020

[7.x] [Security Solution] Untitled Timeline created when first action is to add note (#78988) #79390

Merged

angorayc mentioned this pull request Oct 5, 2020

[7.9] [Security Solution] Untitled Timeline created when first action is to add note (#78988) #79424

Merged

angorayc added Team:Threat Hunting Security Solution Threat Hunting Team v7.9.3 labels Oct 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] Untitled Timeline created when first action is to add note#78988

[Security Solution] Untitled Timeline created when first action is to add note#78988
angorayc merged 16 commits intoelastic:masterfrom
angorayc:issue844

angorayc commented Sep 30, 2020 •

edited

Loading

Uh oh!

XavierM commented Oct 1, 2020

Uh oh!

angorayc commented Oct 1, 2020 •

edited

Loading

Uh oh!

angorayc commented Oct 1, 2020

Uh oh!

kibanamachine commented Oct 2, 2020

Uh oh!

angorayc commented Oct 2, 2020

Uh oh!

XavierM left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

angorayc commented Sep 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

XavierM commented Oct 1, 2020

Uh oh!

angorayc commented Oct 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

angorayc commented Oct 1, 2020

Uh oh!

kibanamachine commented Oct 2, 2020

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

angorayc commented Oct 2, 2020

Uh oh!

XavierM left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

angorayc commented Sep 30, 2020 •

edited

Loading

angorayc commented Oct 1, 2020 •

edited

Loading