[Reporting/Functional] unskip pagination test#74973
Merged
tsullivan merged 3 commits intoelastic:masterfrom Aug 13, 2020
Merged
[Reporting/Functional] unskip pagination test#74973tsullivan merged 3 commits intoelastic:masterfrom
tsullivan merged 3 commits intoelastic:masterfrom
Conversation
tsullivan
commented
Aug 13, 2020
| @@ -4,9 +4,7 @@ | |||
| * you may not use this file except in compliance with the Elastic License. | |||
| */ | |||
|
|
|||
| import { FtrProviderContext } from '../../ftr_provider_context'; | |||
|
|
|||
| export default ({ loadTestFile }: FtrProviderContext) => { | |||
Member
Author
There was a problem hiding this comment.
Changed this to JS file so that it can run in the flaky test runner
Member
Author
|
Update: This branch has just passed in the flaky test runner 15 times. |
Contributor
💚 Build SucceededBuild metricspage load bundle size
History
To update your PR or re-run it, just comment with: |
rashmivkulkarni
approved these changes
Aug 13, 2020
Contributor
rashmivkulkarni
left a comment
There was a problem hiding this comment.
LGTM ,
- test is successful multiple times on FTR.
- code reviewed.
- also like the fact that
findbyCssSelectoris replaced by actual id of the object.
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Aug 14, 2020
* [Reporting/Functional] unskip pagination test * change to js file for flaky test runner * fix ts
tsullivan
added a commit
that referenced
this pull request
Aug 14, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 14, 2020
* master: (23 commits) Adding API test for custom link transaction example (elastic#74238) [Uptime] Singular alert (elastic#74659) Revert "attempt excluding a codeowners directory" (elastic#75023) [Metrics UI] Remove TSVB dependency from Metrics Explorer APIs (elastic#74804) Remove degraded state from ES status service (elastic#75007) [Reporting/Functional] unskip pagination test (elastic#74973) [Resolver] Stale query string values are removed when resolver's component instance ID changes. (elastic#74979) Add public url to Workplace Search plugin (elastic#74991) [Reporting] Update more Server Types for TaskManager (elastic#74915) [I18n] verify select icu-message options are in english (elastic#74963) Make data.search.aggs available on the server. (elastic#74472) [Security Solution][Resolver] Graph Control Tests and Update Simulator Selectors (elastic#74680) attempt excluding a codeowners directory [ML] DF Analytics: allow failed job to be stopped by force via the UI (elastic#74710) Add kibana-core-ui-designers team (elastic#74970) [Metrics UI] Fix inventory footer misalignment (elastic#74707) Remove legacy optimizer (elastic#73154) Update design-specific GH code-owners (elastic#74877) skip test Reporting paginates content elastic#74922 [Metrics UI] Add Jest tests for alert previews (elastic#74890) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #74922
Checklist
Delete any items that are not applicable to this PR.
For maintainers