Remove legacy optimizer by spalger · Pull Request #73154 · elastic/kibana

spalger · 2020-07-23T22:07:32Z

Fixes #7322
Fixes #58369
Closes #19633
Closes #6495
Closes #27274
Closes #45409
Closes #53160

The legacy optimizer is no longer required so this PR removes it along with a handful of related components. I tried to break this out into separate PRs, but the extra cost of all that review was weighing heavy on the effort to just get this removed so I ditched that approach and moved forward with a pretty colossal deletion PR.

Mostly complete change list:

deprecated --optimize CLI flag, we now log and exit as soon as we start with this flag.
all optimize.* config options have been deprecated with log messages about removal
- optimize.viewCaching was used by an unused view rendering layer in the legacy server, which I removed so I could remove this config value
Support for ui/* imports in KP scss was removed, remaining usage was converted to use ~ css-loader syntax to pull from assets in src/core/public/core_app
~~The @kbn/optimizer max workers count is now Math.max(CPU_COUNT - 1, 3)~~
legacy sass build logic was removed
Global themes were moved from src/legacy/ui/public/styles to src/core/public/core_app/styles
Customized bootstrap styles from src/legacy/ui/public were converted from less to css and stored in src/core/server/core_app/assets
background images which are provided by the global mixins are moved to src/core/public/core_app/images
public_path_placeholder logic which stuck around for legacy bundle support was removed, including integration with bundle routes module
--no-optimizer can now be passed to yarn start if people want to run the @kbn/optimizer separately (used to be --optimize.enabled, no deprecation since this is likely never used and dev only)
uiExports which only pertained to the legacy optimizer were removed
the bootstrap script is moved from /bundles/app/{id}/bootstrap.js to just /bootstrap.js as it's not a bundle and it's not app specific
UUID syncToFile option was removed as this was only necessary to support --optimize flag
legacy status page was removed
UiBundles removed
bundleRoute is now just responsible for cache/etag logic, good candidate for replacement with more standard logic
legacy optimize mixin just sets up bundle routes
kbn/storybook, canvas storybook, and canvas sharable runtime now just import src/core/server/core_app/assets/legacy_light_theme.css rather than building sass and importing plugin light themes from build_assets or ui/public/styles

Stats:

This produces a modest 3MB reduction in the side of the default distributable, 2646 fewer files. Server startup time doesn't seem to be impacted at all by this change, which is generally expected since we've moved basically all the files from legacy to the Kibana Platform.

Holy change set!:

FYI, 23310 of the 24043 additions (97%) were caused by the @kbn/pm dist as well as committing the compiled versions of src/core/server/core_app/assets/legacy_light_theme.css and src/core/server/core_app/assets/legacy_dark_theme.css. That leaves 733 lines actually changed. Please don't be overwhelmed by the described changes :)

Release note:

Kibana no longer needs to optimize plugins for use in the browser when a plugin is installed. This means the --optimize flag is now deprecated and does nothing now. It will be removed in 8.0.

spalger · 2020-08-05T15:29:09Z

@elasticmachine merge upstream

spalger · 2020-08-05T19:04:54Z

mime was updated (includes new definitions), which is included in the canvas bundle causing the increase.

upgradeAssistant includes the package.json file, causing the increase.

…-optimizer

spalger · 2020-08-12T03:00:10Z

@elasticmachine merge upstream

snide

Looks good. Checked without base-path and correctly see success/error messaging. Checked that editing in various themes trigger, and that editing the css directly works.

timroes

Code review only of Kibana App owned files. Code changes LGTM

spalger · 2020-08-12T21:10:22Z

@elasticmachine merge upstream

joshdover

This PR turned out to be less scary than I expected 😄 I actually have very little to comment on, most of this was just removing.

I think we can remove the /src/legacy/server/sass/ @elastic/kibana-operations line from our CODEOWNERS

Do you agree that all of the bundle serving logic in src/optimize should be moved to src/core/server when we start removing src/legacy/server? Definitely out of scope for this PR, just wanted to gut check my assumptions here.

joshdover · 2020-08-12T22:23:34Z

src/core/server/bootstrap.ts

  }

+  if (cliArgs.optimize) {
+    // --optimize is deprecated and does nothing now, avoid starting up and just shutdown


Should we log a warning?

I tried, but the logger is in buffering mode here and I don't think we should write something to stdout or something without considering the other flags... I figured the --help and release notes are sufficient to warn people that they don't need to call this. In 8.0 we'll remove the flag and then it will stop working, I don't think we need to figure out how to make it log. #73154 (comment)

src/core/server/rendering/rendering_service.tsx

package.json

joshdover · 2020-08-12T23:06:51Z

package.json

@@ -118,7 +118,6 @@
  },
  "dependencies": {
    "@babel/core": "^7.11.1",


Are we still using babel in production? I thought we pre-babel'd everything during the build?

We still babel-register, but I plan to remove that soon, once the plugin-helpers take care of babel-ifying things at build time.

…-optimizer

kibanamachine · 2020-08-13T03:29:53Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: f29489d

Build metrics

@kbn/optimizer bundle module count

id	value	diff	baseline
graph	159	-1	160

async chunks size

id	value	diff	baseline
graph	1.4MB	-79.0B	1.4MB

page load bundle size

id	value	diff	baseline
canvas	1.3MB	+1.4KB	1.3MB
upgradeAssistant	64.6KB	-624.0B	65.2KB
total		+799.0B

History

💔 Build #67851 failed 2f19db6
💔 Build #67847 failed 5adf934
💚 Build #67801 succeeded dac0a5f
💚 Build #67641 succeeded b41d99f
💚 Build #67625 succeeded 054913c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

clintandrewhall

I tested Canvas, Storybook (dev and build) and the Shareable Runtime (dev and build) and all is working! Great job, @spalger

Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # docs/setup/install/deb.asciidoc # docs/setup/install/rpm.asciidoc # docs/setup/install/targz.asciidoc # docs/setup/install/windows.asciidoc # package.json # packages/kbn-pm/dist/index.js # packages/kbn-test/src/functional_tests/lib/paths.js # src/core/server/config/deprecation/core_deprecations.ts # src/legacy/server/config/schema.js # src/optimize/base_optimizer.js # test/scripts/jenkins_xpack.sh # x-pack/legacy/plugins/xpack_main/index.js # yarn.lock

* upstream/master: (45 commits) [Metrics UI] Fix inventory footer misalignment (elastic#74707) Remove legacy optimizer (elastic#73154) Update design-specific GH code-owners (elastic#74877) skip test Reporting paginates content elastic#74922 [Metrics UI] Add Jest tests for alert previews (elastic#74890) Fixed tooltip (elastic#74074) [Ingest Pipelines] Processor forms for processors A-D (elastic#72849) [Observability] change ingest manager link (elastic#74928) [Task manager] Prevents edge case where already running tasks are reschedule every polling interval (elastic#74606) [Security Solution] Fix the status of timelines' bulk actions (elastic#74560) Data plugin: Suggested enhance pattern (elastic#74505) Use jest.useFakeTimers instead of hard coded timeout for tooltip tests. (elastic#74642) [Security Solution][lists] Adds tests for exception lists and items part 2 (elastic#74815) [Security Solution][Resolver] fix presentation role on edgeline (elastic#74869) [Security Solution][Detections] Refactor ML calls for newest ML permissions (elastic#74582) [bin/kibana-plugin] support KP plugins instead (elastic#74604) Reduce number of indexed fields in index pattern saved object (elastic#74817) [reporting] Pass along generic parameters in high-order route handler (elastic#74892) Migrated last pieces of legacy fixture code (elastic#74470) Empty index patterns page re-design (elastic#68819) ...

epixa · 2020-08-13T18:00:37Z

This PR is good.

Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: (23 commits) Adding API test for custom link transaction example (elastic#74238) [Uptime] Singular alert (elastic#74659) Revert "attempt excluding a codeowners directory" (elastic#75023) [Metrics UI] Remove TSVB dependency from Metrics Explorer APIs (elastic#74804) Remove degraded state from ES status service (elastic#75007) [Reporting/Functional] unskip pagination test (elastic#74973) [Resolver] Stale query string values are removed when resolver's component instance ID changes. (elastic#74979) Add public url to Workplace Search plugin (elastic#74991) [Reporting] Update more Server Types for TaskManager (elastic#74915) [I18n] verify select icu-message options are in english (elastic#74963) Make data.search.aggs available on the server. (elastic#74472) [Security Solution][Resolver] Graph Control Tests and Update Simulator Selectors (elastic#74680) attempt excluding a codeowners directory [ML] DF Analytics: allow failed job to be stopped by force via the UI (elastic#74710) Add kibana-core-ui-designers team (elastic#74970) [Metrics UI] Fix inventory footer misalignment (elastic#74707) Remove legacy optimizer (elastic#73154) Update design-specific GH code-owners (elastic#74877) skip test Reporting paginates content elastic#74922 [Metrics UI] Add Jest tests for alert previews (elastic#74890) ...

spalger force-pushed the remove/legacy-optimizer branch from c886236 to 5b6c5c6 Compare July 24, 2020 02:06

spalger mentioned this pull request Jul 27, 2020

Remove karma #73126

Merged

spalger force-pushed the remove/legacy-optimizer branch 2 times, most recently from 21ecf55 to 7c820df Compare July 27, 2020 19:43

spalger mentioned this pull request Jul 29, 2020

move and unify postcss config into @kbn/optimizer #73633

Merged

spalger force-pushed the remove/legacy-optimizer branch 4 times, most recently from f132f77 to 25ca57a Compare July 30, 2020 19:40

spalger mentioned this pull request Jul 31, 2020

Optimize the optimizer #14477

Closed

spalger force-pushed the remove/legacy-optimizer branch 3 times, most recently from 3567e28 to b058ea3 Compare August 4, 2020 22:57

spalger mentioned this pull request Aug 5, 2020

Migrate ui/styles to New Platform #58369

Closed

spalger force-pushed the remove/legacy-optimizer branch from acbaadd to afa73c8 Compare August 5, 2020 05:02

spalger force-pushed the remove/legacy-optimizer branch from f7be502 to 12cc326 Compare August 5, 2020 19:53

Remove legacy optimizer

8fbc20b

spalger force-pushed the remove/legacy-optimizer branch from 12cc326 to 8fbc20b Compare August 5, 2020 20:08

spalger added 4 commits August 5, 2020 13:09

update test fixutre

682f944

restore kbn/pm dist checking and update dist

f1cbff2

update deprecation tests to be more comprehensive

a3abe9f

Merge branch 'master' of github.com:elastic/kibana into remove/legacy…

63ea215

…-optimizer

spalger marked this pull request as ready for review August 5, 2020 22:56

spalger requested review from a team as code owners August 5, 2020 22:56

Merge branch 'master' into remove/legacy-optimizer

b41d99f

snide approved these changes Aug 12, 2020

View reviewed changes

tylersmalley approved these changes Aug 12, 2020

View reviewed changes

timroes approved these changes Aug 12, 2020

View reviewed changes

Merge branch 'master' into remove/legacy-optimizer

dac0a5f

joshdover mentioned this pull request Aug 12, 2020

Remove ApplicationService's legacyMode #74911

Closed

joshdover approved these changes Aug 12, 2020

View reviewed changes

spalger added 7 commits August 12, 2020 16:10

Merge branch 'master' of github.com:elastic/kibana into remove/legacy…

d2332b2

…-optimizer

Merge branch 'master' of github.com:elastic/kibana into remove/legacy…

43b2fad

…-optimizer

apply some feedback

9f46cd1

Merge branch 'master' of github.com:elastic/kibana into remove/legacy…

5adf934

…-optimizer

remove legacy snapshots from rendering service

2f19db6

remove unused variable

86b2a4d

Merge branch 'master' of github.com:elastic/kibana into remove/legacy…

f29489d

…-optimizer

timroes mentioned this pull request Aug 13, 2020

Working with multiple Kibana source codes in parallel #27390

Closed

clintandrewhall approved these changes Aug 13, 2020

View reviewed changes

spalger merged commit 4c810be into elastic:master Aug 13, 2020

spalger deleted the remove/legacy-optimizer branch August 13, 2020 16:08

spalger mentioned this pull request Aug 13, 2020

[7.x] Remove legacy optimizer (#73154) #74966

Merged

spalger mentioned this pull request Aug 13, 2020

[npm] remove unused less fork #74969

Closed

spalger added a commit that referenced this pull request Aug 13, 2020

[7.x] Remove legacy optimizer (#73154) (#74966)

47897a2

Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

spalger mentioned this pull request Aug 25, 2020

[src/dev/build] stop including public source in distributable #75841

Merged

TinaHeiligers mentioned this pull request Sep 28, 2021

Removes support for unused optimize.* settings from core deprecations #113296

Merged

Conversation

spalger commented Jul 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spalger commented Aug 5, 2020

Uh oh!

spalger commented Aug 5, 2020

Uh oh!

spalger commented Aug 12, 2020

Uh oh!

snide left a comment

Choose a reason for hiding this comment

Uh oh!

timroes left a comment

Choose a reason for hiding this comment

Uh oh!

spalger commented Aug 12, 2020

Uh oh!

joshdover left a comment

Choose a reason for hiding this comment

Uh oh!

joshdover Aug 12, 2020

Choose a reason for hiding this comment

Uh oh!

spalger Aug 13, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

joshdover Aug 12, 2020

Choose a reason for hiding this comment

Uh oh!

spalger Aug 13, 2020

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Aug 13, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

async chunks size

page load bundle size

History

Uh oh!

clintandrewhall left a comment

Choose a reason for hiding this comment

Uh oh!

epixa commented Aug 13, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

spalger commented Jul 23, 2020 •

edited

Loading