Skip to content

[ML] DF Analytics: allow failed job to be stopped by force via the UI#74710

Merged
alvarezmelissa87 merged 2 commits intoelastic:masterfrom
alvarezmelissa87:ml-dfanalytics-force-stop-in-edit
Aug 13, 2020
Merged

[ML] DF Analytics: allow failed job to be stopped by force via the UI#74710
alvarezmelissa87 merged 2 commits intoelastic:masterfrom
alvarezmelissa87:ml-dfanalytics-force-stop-in-edit

Conversation

@alvarezmelissa87
Copy link
Copy Markdown
Contributor

@alvarezmelissa87 alvarezmelissa87 commented Aug 10, 2020 •
edited
Loading

Summary

Fixes #72661

NOTE: Feedback on modal wording is welcome.

This PR replaces the Start action in the analytics list with the Stop action when the job is in a failed state as Start action will fail for a failed job state.

error-starting-job

If the job is in a failed state, the user will now see the Stop action which will allow the user to force stop the job. A confirmation modal will appear.

stop-action

force-stop-modal

job-stopped

Checklist

Delete any items that are not applicable to this PR.

@alvarezmelissa87 alvarezmelissa87 added :ml release_note:skip Skip the PR/issue when compiling release notes Feature:Data Frame Analytics ML data frame analytics features v7.10.0 labels Aug 10, 2020
@alvarezmelissa87 alvarezmelissa87 requested a review from a team as a code owner August 10, 2020 21:13
@alvarezmelissa87 alvarezmelissa87 self-assigned this Aug 10, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Aug 10, 2020

Pinging @elastic/ml-ui (:ml)

@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Aug 10, 2020
Closed
walterra
walterra approved these changes Aug 11, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just added a small suggestion about the button text in the modal.

...data_frame_analytics/pages/analytics_management/components/action_stop/stop_button_modal.tsx Outdated
Copy link
Copy Markdown
Contributor

@walterra walterra Aug 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to make the button text Force stop.

@sophiec20
Copy link
Copy Markdown
Contributor

sophiec20 commented Aug 11, 2020

Can you please loop in @lcawl ? I think it is worth succinctly explaining that a force stop will reset the state of the job and allow you to restart it again, assuming you've rectified the problem.

lcawl
lcawl reviewed Aug 11, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worked with @gchaps on these suggestions, so if you like them credit goes to the guru!

...data_frame_analytics/pages/analytics_management/components/action_stop/stop_button_modal.tsx Outdated
Copy link
Copy Markdown
Member

@lcawl lcawl Aug 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case the job name is long, can we put it in the body of the message instead of the title?

Suggested change
defaultMessage: 'Force stop {analyticsId}',
defaultMessage: 'Force this job to stop?',

...data_frame_analytics/pages/analytics_management/components/action_stop/stop_button_modal.tsx Outdated
Copy link
Copy Markdown
Member

@lcawl lcawl Aug 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with suggestion from @walterra

Suggested change
defaultMessage: 'Stop',
defaultMessage: 'Force stop',

...data_frame_analytics/pages/analytics_management/components/action_stop/stop_button_modal.tsx Outdated
Copy link
Copy Markdown
Member

@lcawl lcawl Aug 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to hint at some of the next steps, I suggest something like this:

Suggested change
defaultMessage="The analytics job is in the failed state, do you want to force stop {analyticsId}?"
defaultMessage="{analyticsId} is in a failed state. You must stop the job and fix the failure."

Copy link
Copy Markdown
Contributor Author

@alvarezmelissa87 alvarezmelissa87 Aug 13, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @lcawl! 🙏 😄 All updates in 61308c2

jgowdyelastic
jgowdyelastic approved these changes Aug 12, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvarezmelissa87 alvarezmelissa87 force-pushed the ml-dfanalytics-force-stop-in-edit branch from 3ecc90a to 9c1e1fd Compare August 13, 2020 16:09
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Aug 13, 2020

💚 Build Succeeded

Build metrics

@kbn/optimizer bundle module count

id value diff baseline
ml 1355 +2 1353

async chunks size

id value diff baseline
ml 8.0MB +12.6KB 8.0MB

History

  • 💚 Build #67386 succeeded 3ecc90a6e12c62f5ebb7981d7a3f94a123c0bb77

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@alvarezmelissa87 alvarezmelissa87 merged commit 479a991 into elastic:master Aug 13, 2020
@alvarezmelissa87 alvarezmelissa87 mentioned this pull request Aug 13, 2020
Merged
alvarezmelissa87 added a commit to alvarezmelissa87/kibana that referenced this pull request Aug 13, 2020
@alvarezmelissa87
[ML] DF Analytics: allow failed job to be stopped by force via the UI (…
ce6a4bf 
…elastic#74710)

* allow force stop from ui if job is failed

* update wording in confirm modal
@alvarezmelissa87 alvarezmelissa87 deleted the ml-dfanalytics-force-stop-in-edit branch August 13, 2020 18:20
alvarezmelissa87 added a commit that referenced this pull request Aug 13, 2020
@alvarezmelissa87
[ML] DF Analytics: allow failed job to be stopped by force via the UI (…
86d8d41 
…#74710) (#74983)

* allow force stop from ui if job is failed

* update wording in confirm modal
gmmorris added a commit to gmmorris/kibana that referenced this pull request Aug 14, 2020
@gmmorris
Merge branch 'master' into actions/webhook-remove-header
bd12cb4 
* master: (23 commits)
  Adding API test for custom link transaction example (elastic#74238)
  [Uptime] Singular alert (elastic#74659)
  Revert "attempt excluding a codeowners directory" (elastic#75023)
  [Metrics UI] Remove TSVB dependency from Metrics Explorer APIs (elastic#74804)
  Remove degraded state from ES status service (elastic#75007)
  [Reporting/Functional] unskip pagination test (elastic#74973)
  [Resolver] Stale query string values are removed when resolver's component instance ID changes. (elastic#74979)
  Add public url to Workplace Search plugin (elastic#74991)
  [Reporting] Update more Server Types for TaskManager (elastic#74915)
  [I18n] verify select icu-message options are in english (elastic#74963)
  Make data.search.aggs available on the server. (elastic#74472)
  [Security Solution][Resolver] Graph Control Tests and Update Simulator Selectors (elastic#74680)
  attempt excluding a codeowners directory
  [ML] DF Analytics: allow failed job to be stopped by force via the UI (elastic#74710)
  Add kibana-core-ui-designers team (elastic#74970)
  [Metrics UI] Fix inventory footer misalignment (elastic#74707)
  Remove legacy optimizer (elastic#73154)
  Update design-specific GH code-owners (elastic#74877)
  skip test Reporting paginates content elastic#74922
  [Metrics UI] Add Jest tests for alert previews (elastic#74890)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcawl lcawl lcawl left review comments

@walterra walterra walterra approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

@darnautov darnautov Awaiting requested review from darnautov

Assignees

@alvarezmelissa87 alvarezmelissa87

Labels

Feature:Data Frame Analytics ML data frame analytics features :ml release_note:skip Skip the PR/issue when compiling release notes v7.10.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[ML] Allow force stop job action on DFA job failure

7 participants

@alvarezmelissa87 @elasticmachine @sophiec20 @kibanamachine @walterra @jgowdyelastic @lcawl