Merged
Conversation
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededBuild metricsasync chunks size
page load bundle size
History
To update your PR or re-run it, just comment with: |
andrewvc
reviewed
Aug 12, 2020
Contributor
andrewvc
left a comment
There was a problem hiding this comment.
Great work here, left a comment about inheritance vs pseudo-inheritance via composition
justinkambic
approved these changes
Aug 13, 2020
Contributor
justinkambic
left a comment
There was a problem hiding this comment.
LGTM! Tested this locally and it's working as I'd expect, and it's a better alerting experience getting a per-monitor notification.
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 14, 2020
* master: (23 commits) Adding API test for custom link transaction example (elastic#74238) [Uptime] Singular alert (elastic#74659) Revert "attempt excluding a codeowners directory" (elastic#75023) [Metrics UI] Remove TSVB dependency from Metrics Explorer APIs (elastic#74804) Remove degraded state from ES status service (elastic#75007) [Reporting/Functional] unskip pagination test (elastic#74973) [Resolver] Stale query string values are removed when resolver's component instance ID changes. (elastic#74979) Add public url to Workplace Search plugin (elastic#74991) [Reporting] Update more Server Types for TaskManager (elastic#74915) [I18n] verify select icu-message options are in english (elastic#74963) Make data.search.aggs available on the server. (elastic#74472) [Security Solution][Resolver] Graph Control Tests and Update Simulator Selectors (elastic#74680) attempt excluding a codeowners directory [ML] DF Analytics: allow failed job to be stopped by force via the UI (elastic#74710) Add kibana-core-ui-designers team (elastic#74970) [Metrics UI] Fix inventory footer misalignment (elastic#74707) Remove legacy optimizer (elastic#73154) Update design-specific GH code-owners (elastic#74877) skip test Reporting paginates content elastic#74922 [Metrics UI] Add Jest tests for alert previews (elastic#74890) ...
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
Aug 14, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
mikecote
pushed a commit
that referenced
this pull request
Aug 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes: elastic/uptime#237
This PR changes the default behaviour of monitor status alert from a digest type message to message per monitor per location.
Down check default message:
Monitor HTTP-NOWHERE with url http://nowhere.example.com is down from nyc-heartbeat. The latest error message is lookup nowhere.example.com on 10.55.240.10:53: no such hostAvailability check default message:
Monitor Always Down Local Port with url tcp://localhost:18278 is below threshold with 0.00% availability expected is 99% from nyc-heartbeat. The latest error message is dial tcp 127.0.0.1:18278: connect: connection refusedMessage where both down and availability check are enabled
Monitor tcp-ext-KIBANA with url tcp://kibana.35.241.204.195.ip.es.io:443 is down and also below threshold with 28.37% availability expected is 99% from nyc-heartbeat. The latest error message is dial tcp 35.241.204.195:443: i/o timeoutin Alert Flyout message will appear like this
user can change message at will by selecting from following monitor fields
monitorId,monitorUrl,monitorType,latestErrorMessage,observerLocation,observerHostname,statusMessageAlerts pre 7.10 will continue to work but their behaviour will change instead of throwing a combined message, user will receive a singular message as well.