[Observability UI] Fixed grammar "awhile" to "a while"#74725
Merged
igoristic merged 1 commit intoelastic:masterfrom Aug 11, 2020
Merged
[Observability UI] Fixed grammar "awhile" to "a while"#74725igoristic merged 1 commit intoelastic:masterfrom
igoristic merged 1 commit intoelastic:masterfrom
Conversation
lizozom
reviewed
Aug 11, 2020
| this.longRunningToast = this.deps.toasts.addInfo( | ||
| { | ||
| title: 'Your query is taking awhile', | ||
| title: 'Your query is taking a while', |
Contributor
There was a problem hiding this comment.
I remember looking this up when implementing the feature.
I think awhile is actually the right form, but I also find it weird.
Contributor
Author
There was a problem hiding this comment.
Yeah, it's a bit confusing for me too 🙃
The way I understand it is awhile == for a while so it would read something like: "Your query is taking for a while" which can also work 🤷♂️
lizozom
approved these changes
Aug 11, 2020
This was referenced Aug 11, 2020
igoristic
added a commit
to igoristic/kibana
that referenced
this pull request
Aug 11, 2020
# Conflicts: # rfcs/text/0001_lifecycle_setup.md
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Aug 11, 2020
* master: (106 commits) [Functional Tests] Adds a wait time between setting the index pattern and the time field on TSVB (elastic#74736) [Lens] Add styling options for x and y axes on the settings popover (elastic#71829) [Maps] add initial location option that fits to data bounds (elastic#74583) theme function (elastic#73451) [data.ui.query] Write filters to query log from default editor. (elastic#74474) [data.search.SearchSource] Move some SearchSource dependencies to the server. (elastic#74607) [Canvas][tech-debt] Convert renderers (elastic#74134) [security solutions][lists] Adds end to end tests (elastic#74473) pluralized for occurrences vs occurrence (elastic#74564) Update links that pointed to CONTRIBUTING.md (elastic#74757) [Ingest pipelines] Implement tabs in processor flyout (elastic#74469) [Event log] Use Alerts client & Actions client when fetching these types of SOs (elastic#73257) Bump chalk to 4.1.0 (elastic#73397) Index pattern field list - transition away from extending array - introduce and use getAll() (elastic#74718) [SECURITY] Bugs css/inspect (elastic#74711) [telemetry] update README to downplay ui_metrics (elastic#74635) Fixed grammar (elastic#74725) [Telemetry][API Integration] size_in_bytes to be a number (elastic#74664) [ILM] Convert node details flyout to TS (elastic#73707) [Ingest Node Pipelines] Sentence-case processor names (elastic#74645) ...
igoristic
added a commit
that referenced
this pull request
Aug 11, 2020
igoristic
added a commit
that referenced
this pull request
Aug 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #74698
Just a slight grammar correction