pluralized for occurrences vs occurrence by brittanyjoiner15 · Pull Request #74564 · elastic/kibana

brittanyjoiner15 · 2020-08-06T16:49:55Z

Resolves #74005

For error details chart, occurrence is singular when there is only one.

elasticmachine · 2020-08-06T16:50:00Z

Pinging @elastic/apm-ui (Team:apm)

brittanyjoiner15 · 2020-08-10T15:04:12Z

@elasticmachine merge upstream

kibanamachine · 2020-08-10T16:57:29Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ea07b41

Build metrics

async chunks size

id	value	diff	baseline
apm	3.7MB	+45.0B	3.7MB

History

💚 Build #66983 succeeded b8f7ee8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cauemarcondes

LGTM

* master: (106 commits) [Functional Tests] Adds a wait time between setting the index pattern and the time field on TSVB (elastic#74736) [Lens] Add styling options for x and y axes on the settings popover (elastic#71829) [Maps] add initial location option that fits to data bounds (elastic#74583) theme function (elastic#73451) [data.ui.query] Write filters to query log from default editor. (elastic#74474) [data.search.SearchSource] Move some SearchSource dependencies to the server. (elastic#74607) [Canvas][tech-debt] Convert renderers (elastic#74134) [security solutions][lists] Adds end to end tests (elastic#74473) pluralized for occurrences vs occurrence (elastic#74564) Update links that pointed to CONTRIBUTING.md (elastic#74757) [Ingest pipelines] Implement tabs in processor flyout (elastic#74469) [Event log] Use Alerts client & Actions client when fetching these types of SOs (elastic#73257) Bump chalk to 4.1.0 (elastic#73397) Index pattern field list - transition away from extending array - introduce and use getAll() (elastic#74718) [SECURITY] Bugs css/inspect (elastic#74711) [telemetry] update README to downplay ui_metrics (elastic#74635) Fixed grammar (elastic#74725) [Telemetry][API Integration] size_in_bytes to be a number (elastic#74664) [ILM] Convert node details flyout to TS (elastic#73707) [Ingest Node Pipelines] Sentence-case processor names (elastic#74645) ...

…nes/processor-forms-a-d * 'master' of github.com:elastic/kibana: (25 commits) [ML] Removing full lodash library imports (elastic#74742) [Search] Server strategy example (elastic#71679) [Reporting] Fix and test for Listing of Reports (elastic#74453) [maps] fix drawing shapes (elastic#74689) [Resolver] Improve simulator. Add more click-through tests and panel tests. (elastic#74601) Deprecate schema-less specs in Vega (elastic#73805) [Security Solution] Rename Administration > Hosts subtab to Endpoints (elastic#74287) Timelion deprecation doc (elastic#74508) [Functional Tests] Adds a wait time between setting the index pattern and the time field on TSVB (elastic#74736) [Lens] Add styling options for x and y axes on the settings popover (elastic#71829) [Maps] add initial location option that fits to data bounds (elastic#74583) theme function (elastic#73451) [data.ui.query] Write filters to query log from default editor. (elastic#74474) [data.search.SearchSource] Move some SearchSource dependencies to the server. (elastic#74607) [Canvas][tech-debt] Convert renderers (elastic#74134) [security solutions][lists] Adds end to end tests (elastic#74473) pluralized for occurrences vs occurrence (elastic#74564) Update links that pointed to CONTRIBUTING.md (elastic#74757) [Ingest pipelines] Implement tabs in processor flyout (elastic#74469) [Event log] Use Alerts client & Actions client when fetching these types of SOs (elastic#73257) ... # Conflicts: # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/field_components/text_editor.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/manage_processor_form.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/append.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/bytes.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/circle.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/common_fields/field_name_field.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/common_fields/ignore_missing_field.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/convert.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/csv.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/date.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/date_index_name.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/dissect.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/dot_expander.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/drop.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/index.ts # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_processors_editor/components/manage_processor_form/processors/shared.ts

kibanamachine · 2020-08-13T14:28:44Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 74564 or prevent reminders by adding the backport:skip label.

kibanamachine · 2020-08-14T14:38:44Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 74564 or prevent reminders by adding the backport:skip label.

kibanamachine · 2020-08-17T14:48:44Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 74564 or prevent reminders by adding the backport:skip label.

kibanamachine · 2020-08-18T14:58:43Z

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 74564 or prevent reminders by adding the backport:skip label.

dgieselaar · 2020-08-18T15:06:42Z

@brittanyjoiner15 should this be backported? If so, do you know how to/are you able to? Otherwise one of us can pick it up.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # x-pack/plugins/apm/public/components/app/ErrorGroupDetails/Distribution/index.tsx

dgieselaar · 2020-08-19T07:14:46Z

@brittanyjoiner15 Backporting to 7.x and 7.9 should be good enough - I've closed the other backport PRs.

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

pluralized for occurrences vs occurrence

b8f7ee8

brittanyjoiner15 added release_note:enhancement v7.9.1 labels Aug 6, 2020

brittanyjoiner15 requested review from a team and smith August 6, 2020 16:49

brittanyjoiner15 self-assigned this Aug 6, 2020

botelastic bot added the Team:APM - DEPRECATED Use Team:obs-ux-infra_services. label Aug 6, 2020

Merge branch 'master' into bjoiner/pluralization

ea07b41

cauemarcondes approved these changes Aug 11, 2020

View reviewed changes

brittanyjoiner15 merged commit f621b0e into elastic:master Aug 11, 2020

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 13, 2020

This was referenced Aug 18, 2020

[7.9] pluralized for occurrences vs occurrence (#74564) #75318

Merged

[7.x] pluralized for occurrences vs occurrence (#74564) #75319

Merged

brittanyjoiner15 added a commit to brittanyjoiner15/kibana that referenced this pull request Aug 18, 2020

pluralized for occurrences vs occurrence (elastic#74564)

ce1beb2

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

brittanyjoiner15 added a commit to brittanyjoiner15/kibana that referenced this pull request Aug 18, 2020

pluralized for occurrences vs occurrence (elastic#74564)

8986fd5

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

brittanyjoiner15 mentioned this pull request Aug 18, 2020

[7.8] pluralized for occurrences vs occurrence (#74564) #75320

Closed

brittanyjoiner15 added a commit to brittanyjoiner15/kibana that referenced this pull request Aug 18, 2020

pluralized for occurrences vs occurrence (elastic#74564)

d00150b

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

brittanyjoiner15 mentioned this pull request Aug 18, 2020

[7.7] pluralized for occurrences vs occurrence (#74564) #75322

Closed

brittanyjoiner15 mentioned this pull request Aug 18, 2020

[7.6] pluralized for occurrences vs occurrence (#74564) #75323

Closed

brittanyjoiner15 mentioned this pull request Aug 18, 2020

[7.0] pluralized for occurrences vs occurrence (#74564) #75330

Closed

brittanyjoiner15 mentioned this pull request Aug 18, 2020

[6.8] pluralized for occurrences vs occurrence (#74564) #75331

Closed

brittanyjoiner15 mentioned this pull request Aug 18, 2020

[6.7] pluralized for occurrences vs occurrence (#74564) #75333

Closed

brittanyjoiner15 mentioned this pull request Aug 18, 2020

[6.6] pluralized for occurrences vs occurrence (#74564) #75334

Closed

brittanyjoiner15 mentioned this pull request Aug 18, 2020

[6.5] pluralized for occurrences vs occurrence (#74564) #75336

Closed

brittanyjoiner15 mentioned this pull request Aug 18, 2020

[6.4] pluralized for occurrences vs occurrence (#74564) #75337

Closed

brittanyjoiner15 mentioned this pull request Aug 18, 2020

[6.3] pluralized for occurrences vs occurrence (#74564) #75339

Closed

brittanyjoiner15 mentioned this pull request Aug 18, 2020

[6.2] pluralized for occurrences vs occurrence (#74564) #75343

Closed

brittanyjoiner15 mentioned this pull request Aug 18, 2020

[6.1] pluralized for occurrences vs occurrence (#74564) #75345

Closed

brittanyjoiner15 mentioned this pull request Aug 18, 2020

[6.0] pluralized for occurrences vs occurrence (#74564) #75346

Closed

brittanyjoiner15 mentioned this pull request Aug 18, 2020

[5.6] pluralized for occurrences vs occurrence (#74564) #75348

Closed

dgieselaar added release_note:fix v7.10.0 and removed release_note:enhancement labels Aug 19, 2020

brittanyjoiner15 added a commit that referenced this pull request Aug 19, 2020

pluralized for occurrences vs occurrence (#74564) (#75318)

28f7630

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

brittanyjoiner15 added a commit that referenced this pull request Aug 19, 2020

pluralized for occurrences vs occurrence (#74564) (#75319)

50f9d27

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Aug 19, 2020

elasticmachine unassigned brittanyjoiner15 Oct 29, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pluralized for occurrences vs occurrence#74564

pluralized for occurrences vs occurrence#74564
brittanyjoiner15 merged 2 commits intoelastic:masterfrom
brittanyjoiner15:bjoiner/pluralization

brittanyjoiner15 commented Aug 6, 2020

Uh oh!

elasticmachine commented Aug 6, 2020

Uh oh!

brittanyjoiner15 commented Aug 10, 2020

Uh oh!

kibanamachine commented Aug 10, 2020

Uh oh!

cauemarcondes left a comment

Uh oh!

kibanamachine commented Aug 13, 2020

Uh oh!

kibanamachine commented Aug 14, 2020

Uh oh!

kibanamachine commented Aug 17, 2020

Uh oh!

kibanamachine commented Aug 18, 2020

Uh oh!

dgieselaar commented Aug 18, 2020

Uh oh!

dgieselaar commented Aug 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

brittanyjoiner15 commented Aug 6, 2020

Uh oh!

elasticmachine commented Aug 6, 2020

Uh oh!

brittanyjoiner15 commented Aug 10, 2020

Uh oh!

kibanamachine commented Aug 10, 2020

💚 Build Succeeded

Build metrics

async chunks size

History

Uh oh!

cauemarcondes left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Aug 13, 2020

Uh oh!

kibanamachine commented Aug 14, 2020

Uh oh!

kibanamachine commented Aug 17, 2020

Uh oh!

kibanamachine commented Aug 18, 2020

Uh oh!

dgieselaar commented Aug 18, 2020

Uh oh!

dgieselaar commented Aug 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants