[Security Solution][Exceptions] - Updates exception hooks and viewer by yctercero · Pull Request #73588 · elastic/kibana

yctercero · 2020-07-29T00:04:13Z

Summary

This PR focuses on addressing issues around the pagination and functionality of rules with numerous (2+) exception lists.

Updated the use_exception_list.ts hook to make use of the new multi list find API
Updated the viewer to make use of the new multi list find API
- Previously was doing a lot of the filtering and paging manually (and badly) in the UI, now the _find takes care of all that
Added logic for showing No results text if user filter/search returns no items
- Previously would show the This rule has not exceptions text

Samples 🤤

Empty exception lists

No search results found

Successful search 🔍

Checklist

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility

…rule

…ui_find

…rule

…into exceptions_ui_find

…display more than two lists associated to rule

madirey · 2020-07-29T01:08:36Z

x-pack/plugins/lists/public/exceptions/api.ts

-      ? filterOptions.tags.map((t) => `${namespace}.attributes.tags:${t}`)
-      : []),
-  ];
+  const filters: string = filterOptions


What happens if listIds.length !== namespaceTypes.length? Maybe could use some extra validation around that...

👍 The backend has validation for it x-pack/plugins/lists/server/routes/find_exception_list_item_route.ts (line 50)

madirey · 2020-07-29T01:23:13Z

x-pack/plugins/lists/public/exceptions/hooks/use_api.ts

+          );
+
+        try {
+          if (ids.length > 0 && namespaces.length > 0) {


What happens if they are not > 0?

Just doesn't make the call here since there would be no lists to search.

Updated so if ids are not > 0 then it still calls onSuccess but with defaults.

…ui_find

x-pack/plugins/lists/public/exceptions/hooks/use_exception_list.ts

x-pack/plugins/security_solution/public/common/components/exceptions/viewer/index.tsx

x-pack/plugins/lists/public/exceptions/hooks/use_exception_list.ts

FrankHassanabad · 2020-07-29T19:05:59Z

x-pack/plugins/lists/public/exceptions/hooks/use_api.ts

+        const abortCtrl = new AbortController();
+        const { ids, namespaces } = lists
+          .filter((list) => {
+            if (showDetectionsListsOnly) {


This logic of filter and reduce looks like is duplicated elsewhere. Just mentioning in case you want to make it into a utility, but am fine if it needs to be duplicated here and later on but would be prone to possible changes/bug fixes in one vs. the other later.

Moved to util and added test!

FrankHassanabad · 2020-07-29T19:10:28Z

x-pack/plugins/lists/public/exceptions/hooks/use_exception_list.test.ts

+          })
+      );
+      await waitForNextUpdate();
+      await waitForNextUpdate();


Interesting there has to be two updates before the expect. I trust it, but that is interesting to me. Is there a comment of why two are needed we can add here? Otherwise I always will be like 🤔 when I read this or work with it later.

Optional change of a comment. Not required.

So did a bit of digging. The first one is initialization. I added a note to them all.

FrankHassanabad

Read through it, a few optionals and I might not be the best person to trust giving a front end 👍 but I appreciate the extra conversations about your experience with the react reducer for my education of later when I make front end changes.

Everything looks clean enough and the demo of it looked great. Can't wait to see it in the product.

elasticmachine · 2020-07-29T20:03:18Z

Pinging @elastic/siem (Team:SIEM)

peluja1012

Pulled down the branch and did some testing on the feature. Looks to be functioning well. Thanks!

kibanamachine · 2020-07-29T21:48:15Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: f01e299

Build metrics

async chunks size

id	value	diff	baseline
securitySolution	7.3MB	+2.8KB	7.3MB

page load bundle size

id	value	diff	baseline
lists	269.8KB	-24.0B	269.8KB

History

💔 Build #65288 failed c9847ba
💔 Build #65284 failed 53e4072
💚 Build #65094 succeeded d4288a1
💔 Build #65031 failed 1429893

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…lastic#73588) ## Summary This PR focuses on addressing issues around the pagination and functionality of rules with numerous (2+) exception lists. - Updated the `use_exception_list.ts` hook to make use of the new multi list find API - Updated the viewer to make use of the new multi list find API - Previously was doing a lot of the filtering and paging manually (and badly) in the UI, now the _find takes care of all that - Added logic for showing `No results` text if user filter/search returns no items - Previously would show the `This rule has not exceptions` text

…73588) (#73747) ## Summary This PR focuses on addressing issues around the pagination and functionality of rules with numerous (2+) exception lists. - Updated the `use_exception_list.ts` hook to make use of the new multi list find API - Updated the viewer to make use of the new multi list find API - Previously was doing a lot of the filtering and paging manually (and badly) in the UI, now the _find takes care of all that - Added logic for showing `No results` text if user filter/search returns no items - Previously would show the `This rule has not exceptions` text

…73588) (#73748) ## Summary This PR focuses on addressing issues around the pagination and functionality of rules with numerous (2+) exception lists. - Updated the `use_exception_list.ts` hook to make use of the new multi list find API - Updated the viewer to make use of the new multi list find API - Previously was doing a lot of the filtering and paging manually (and badly) in the UI, now the _find takes care of all that - Added logic for showing `No results` text if user filter/search returns no items - Previously would show the `This rule has not exceptions` text

* master: [Vega][Inspector] Request panel should show correct names for requests (elastic#73655) [Security Solution] Update filter (elastic#73350) TSVB Inaccurate Group By (elastic#73683) [Vega][Inspect panel] Write tutorials and reference (elastic#73262) [ML] Removing node info check for file data viz import (elastic#73717) check that pathname has been updated. ignore other parts (elastic#73689) [build] rewrite source as transpiled JS later in the process (elastic#73749) Fix Snapshot Restore /policies/indices API endpoint on Cloud (elastic#73734) skip flaky suite (elastic#69783) (elastic#70043) [Security Solution][Exceptions] - Updates exception hooks and viewer (elastic#73588) skip failing suite (elastic#58815) [Canvas][fatal bug] Fix props confusion in TextStylePicker (elastic#73732) [DOCS] Changes level offset of monitoring pages (elastic#73573) Added close button to toast notifications by migrating to different API that is more widely used in Kibana and Security solution in particular. (elastic#73662) [ML] Transforms/DFA: Change action button size back to 'xs'. [Metrics UI] Fix evaluating rate-aggregated alerts when there's no normalized value (elastic#73545) [Metrics UI] Fix formatting of values in inventory context.reason (elastic#73155) [maps] rename GisMap to MapContainer and convert to TS (elastic#73690) [APM] docs: remove watcher documentation (elastic#73485)

elasticmachine · 2021-09-23T14:28:41Z

Pinging @elastic/security-solution (Team: SecuritySolution)

yctercero and others added 16 commits July 27, 2020 10:03

wip

6d5198f

updated exceptions_list on rules to include the exception list list_id

bfbf030

Merge branch 'master' of github.com:yctercero/kibana into exceptions_…

d4e8341

…rule

Merge branch 'master' of github.com:yctercero/kibana into exceptions_…

7add86a

…rule

update test

b6c45f8

Merge branch 'master' of github.com:yctercero/kibana into exceptions_…

801fb84

…ui_find

wip - updating hooks with new find functionality

4731e0e

update external_alerts rule to remove endgame index

ae73839

Merge branch 'master' of github.com:yctercero/kibana into exceptions_…

db6f33b

…rule

Merge branch 'master' into exceptions_rule

651fbbf

wip

b02a7b7

wip

5f059c1

Merge branch 'exceptions_rule' of https://github.com/yctercero/kibana …

1a0e98e

…into exceptions_ui_find

updated exceptions hook and viewer to use new find functionality and …

f49a9bd

…display more than two lists associated to rule

restored changes to simplest_updated_name.json

e9e5b26

cleanup pagination

1429893

yctercero added release_note:enhancement Team:SIEM v8.0.0 v7.10.0 v7.9.0 labels Jul 29, 2020

yctercero self-assigned this Jul 29, 2020

madirey reviewed Jul 29, 2020

View reviewed changes

yctercero added 6 commits July 28, 2020 22:36

fix unit tests

e5d6bd4

Merge branch 'master' of github.com:yctercero/kibana into exceptions_…

c7cd80f

…ui_find

fix init loading on viewer when no exception lists exist

116ab1a

Merge branch 'master' of github.com:yctercero/kibana into exceptions_…

d4288a1

…ui_find

Merge branch 'master' of github.com:yctercero/kibana into exceptions_…

03b3996

…ui_find

fix filter bug when only one exception item exists

53e4072

cleanup

c9847ba

yctercero commented Jul 29, 2020

View reviewed changes

x-pack/plugins/lists/public/exceptions/hooks/use_exception_list.ts Outdated Show resolved Hide resolved

yctercero commented Jul 29, 2020

View reviewed changes

x-pack/plugins/security_solution/public/common/components/exceptions/viewer/index.tsx Show resolved Hide resolved

yctercero commented Jul 29, 2020

View reviewed changes

x-pack/plugins/security_solution/public/common/components/exceptions/viewer/index.tsx Outdated Show resolved Hide resolved

FrankHassanabad reviewed Jul 29, 2020

View reviewed changes

x-pack/plugins/lists/public/exceptions/hooks/use_exception_list.ts Outdated Show resolved Hide resolved

FrankHassanabad reviewed Jul 29, 2020

View reviewed changes

FrankHassanabad approved these changes Jul 29, 2020

View reviewed changes

updated per feedback

f01e299

yctercero marked this pull request as ready for review July 29, 2020 20:03

yctercero requested review from a team as code owners July 29, 2020 20:03

peluja1012 approved these changes Jul 29, 2020

View reviewed changes

yctercero merged commit 0756dd3 into elastic:master Jul 29, 2020

yctercero mentioned this pull request Jul 29, 2020

[7.x] [Security Solution][Exceptions] - Updates exception hooks and viewer (#73588) #73747

Merged

yctercero mentioned this pull request Jul 29, 2020

[7.9] [Security Solution][Exceptions] - Updates exception hooks and viewer (#73588) #73748

Merged

yctercero deleted the exceptions_ui_find branch October 14, 2020 11:59

MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021

Conversation

yctercero commented Jul 29, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Samples 🤤

Empty exception lists

No search results found

Successful search 🔍

Checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FrankHassanabad left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Jul 29, 2020

Uh oh!

peluja1012 left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Jul 29, 2020

💚 Build Succeeded

Build metrics

async chunks size

page load bundle size

History

Uh oh!

elasticmachine commented Sep 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

yctercero commented Jul 29, 2020 •

edited

Loading