Merged
Conversation
ThomThomson
approved these changes
Jul 29, 2020
Contributor
ThomThomson
left a comment
There was a problem hiding this comment.
Tested in chrome, and the issue seems to be resolved. Code LGTM!
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
stratoula
approved these changes
Jul 30, 2020
Contributor
stratoula
left a comment
There was a problem hiding this comment.
Tested in Safari, LGTM 🍰
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Jul 30, 2020
alexwizp
added a commit
that referenced
this pull request
Jul 30, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jul 30, 2020
* master: [Vega][Inspector] Request panel should show correct names for requests (elastic#73655) [Security Solution] Update filter (elastic#73350) TSVB Inaccurate Group By (elastic#73683) [Vega][Inspect panel] Write tutorials and reference (elastic#73262) [ML] Removing node info check for file data viz import (elastic#73717) check that pathname has been updated. ignore other parts (elastic#73689) [build] rewrite source as transpiled JS later in the process (elastic#73749) Fix Snapshot Restore /policies/indices API endpoint on Cloud (elastic#73734) skip flaky suite (elastic#69783) (elastic#70043) [Security Solution][Exceptions] - Updates exception hooks and viewer (elastic#73588) skip failing suite (elastic#58815) [Canvas][fatal bug] Fix props confusion in TextStylePicker (elastic#73732) [DOCS] Changes level offset of monitoring pages (elastic#73573) Added close button to toast notifications by migrating to different API that is more widely used in Kibana and Security solution in particular. (elastic#73662) [ML] Transforms/DFA: Change action button size back to 'xs'. [Metrics UI] Fix evaluating rate-aggregated alerts when there's no normalized value (elastic#73545) [Metrics UI] Fix formatting of values in inventory context.reason (elastic#73155) [maps] rename GisMap to MapContainer and convert to TS (elastic#73690) [APM] docs: remove watcher documentation (elastic#73485)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #62081
Describe the bug:
Potentially confusing TSVB functionality. Group by settings configured in any TSVB vis apply to all visualization types, even when the series and related aggregation are not shown.
Steps to reproduce:
Expected behavior:
The series configuration should show all configuration items that apply to the current visualization
Checklist
Delete any items that are not applicable to this PR.
For maintainers