[Security Solution] Update filter by angorayc · Pull Request #73350 · elastic/kibana

angorayc · 2020-07-27T20:39:29Z

Summary

This PR is to fix
https://github.com/elastic/siem-team/issues/740 - item 48
and https://github.com/elastic/siem-team/issues/805

It’s because previously we have a filter that filters createBy: Elastic, but seems that it’s not case sensitive.
That’s why when users login as elastic user name, the templates they create are not filtered correctly.
In this PR, I remove this clause and rely on status:immutable or active to distinguished elastic and custom templates

How to verify this PR:

case one - login as elastic user:

go to: x-pack/test/security_solution_cypress/runner.ts
in line 25 change cypress:run to cypress:open
then in our directory run yarn cypress:run-as-ci when the cypress is open,
you can access the Kibana instance in port 5620 with username elastic and password changeme
Download this file timelines_export (2).txt
and rename it from .txt to .ndjson
import it and see if it filters correctly

case two - login as normal user:

start this branch normally from your local
do step 5 & 6 listed above

elasticmachine · 2020-07-27T20:41:26Z

Pinging @elastic/siem (Team:SIEM)

angorayc · 2020-07-28T16:39:11Z

@elasticmachine merge upstream

angorayc · 2020-07-28T17:42:24Z

@elasticmachine merge upstream

angorayc · 2020-07-28T19:02:32Z

@elasticmachine merge upstream

angorayc · 2020-07-28T22:11:59Z

@elasticmachine merge upstream

angorayc · 2020-07-29T10:41:42Z

@elasticmachine merge upstream

angorayc · 2020-07-29T12:51:41Z

@elasticmachine merge upstream

angorayc · 2020-07-29T15:04:05Z

@elasticmachine merge upstream

kibanamachine · 2020-07-29T16:49:07Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: c663d17

Build metrics

async chunks size

id	value	diff	baseline
securitySolution	7.3MB	-410.0B	7.3MB

page load bundle size

id	value	diff	baseline
securitySolution	869.8KB	-210.0B	870.0KB

History

💚 Build #65176 succeeded ea4721f
💔 Build #65141 failed 16a3de5
💔 Build #65136 failed 2b1182d
💔 Build #64985 failed e965705
💔 Build #64913 failed 5ca2744

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

patrykkopycinski

Tested locally and LGTM! Well done Angela 💪

* update filter * fix type errors * fix unit Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* master: [Vega][Inspector] Request panel should show correct names for requests (elastic#73655) [Security Solution] Update filter (elastic#73350) TSVB Inaccurate Group By (elastic#73683) [Vega][Inspect panel] Write tutorials and reference (elastic#73262) [ML] Removing node info check for file data viz import (elastic#73717) check that pathname has been updated. ignore other parts (elastic#73689) [build] rewrite source as transpiled JS later in the process (elastic#73749) Fix Snapshot Restore /policies/indices API endpoint on Cloud (elastic#73734) skip flaky suite (elastic#69783) (elastic#70043) [Security Solution][Exceptions] - Updates exception hooks and viewer (elastic#73588) skip failing suite (elastic#58815) [Canvas][fatal bug] Fix props confusion in TextStylePicker (elastic#73732) [DOCS] Changes level offset of monitoring pages (elastic#73573) Added close button to toast notifications by migrating to different API that is more widely used in Kibana and Security solution in particular. (elastic#73662) [ML] Transforms/DFA: Change action button size back to 'xs'. [Metrics UI] Fix evaluating rate-aggregated alerts when there's no normalized value (elastic#73545) [Metrics UI] Fix formatting of values in inventory context.reason (elastic#73155) [maps] rename GisMap to MapContainer and convert to TS (elastic#73690) [APM] docs: remove watcher documentation (elastic#73485)

* update filter * fix type errors * fix unit Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

elasticmachine · 2021-09-23T14:28:38Z

Pinging @elastic/security-solution (Team: SecuritySolution)

update filter

a75fe31

angorayc requested review from a team as code owners July 27, 2020 20:39

angorayc added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.9.0 v8.0.0 labels Jul 27, 2020

fix type errors

4a2c1f6

Merge branch 'master' into filter

d5b783a

Merge branch 'master' into filter

998790f

elasticmachine and others added 2 commits July 28, 2020 13:02

Merge branch 'master' into filter

43e2893

fix unit

5ca2744

elasticmachine and others added 2 commits July 28, 2020 16:12

Merge branch 'master' into filter

e965705

Merge remote-tracking branch 'upstream/master' into filter

2b1182d

Merge branch 'master' into filter

16a3de5

Merge branch 'master' into filter

ea4721f

Merge branch 'master' into filter

c663d17

patrykkopycinski approved these changes Jul 30, 2020

View reviewed changes

angorayc merged commit e3f536c into elastic:master Jul 30, 2020

angorayc mentioned this pull request Jul 30, 2020

[7.x] [Security Solution] Update filter (#73350) #73782

Merged

angorayc added a commit to angorayc/kibana that referenced this pull request Jul 30, 2020

[Security Solution] Update filter (elastic#73350)

e3e4e92

* update filter * fix type errors * fix unit Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

angorayc mentioned this pull request Jul 30, 2020

[7.9] [Security Solution] Update filter (#73350) #73783

Merged

angorayc added a commit to angorayc/kibana that referenced this pull request Jul 30, 2020

[Security Solution] Update filter (elastic#73350)

ef5faaf

* update filter * fix type errors * fix unit Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Sep 23, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Security Solution] Update filter#73350

[Security Solution] Update filter#73350
angorayc merged 11 commits intoelastic:masterfrom
angorayc:filter

angorayc commented Jul 27, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Jul 27, 2020

Uh oh!

angorayc commented Jul 28, 2020

Uh oh!

angorayc commented Jul 28, 2020

Uh oh!

angorayc commented Jul 28, 2020

Uh oh!

angorayc commented Jul 28, 2020

Uh oh!

angorayc commented Jul 29, 2020

Uh oh!

angorayc commented Jul 29, 2020

Uh oh!

angorayc commented Jul 29, 2020

Uh oh!

kibanamachine commented Jul 29, 2020

Uh oh!

patrykkopycinski left a comment

Uh oh!

elasticmachine commented Sep 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

angorayc commented Jul 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

elasticmachine commented Jul 27, 2020

Uh oh!

angorayc commented Jul 28, 2020

Uh oh!

angorayc commented Jul 28, 2020

Uh oh!

angorayc commented Jul 28, 2020

Uh oh!

angorayc commented Jul 28, 2020

Uh oh!

angorayc commented Jul 29, 2020

Uh oh!

angorayc commented Jul 29, 2020

Uh oh!

angorayc commented Jul 29, 2020

Uh oh!

kibanamachine commented Jul 29, 2020

💚 Build Succeeded

Build metrics

async chunks size

page load bundle size

History

Uh oh!

patrykkopycinski left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Sep 23, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

angorayc commented Jul 27, 2020 •

edited

Loading