Skip to content

[7.x] [Security Solution][Exceptions] - Updates exception hooks and viewer (#73588)#73747

Merged
yctercero merged 1 commit intoelastic:7.xfrom
yctercero:backport/7.x/pr-73588
Jul 30, 2020
Merged

[7.x] [Security Solution][Exceptions] - Updates exception hooks and viewer (#73588)#73747
yctercero merged 1 commit intoelastic:7.xfrom
yctercero:backport/7.x/pr-73588

Conversation

@yctercero
Copy link
Copy Markdown
Contributor

Backports the following commits to 7.x:

…lastic#73588)

## Summary

This PR focuses on addressing issues around the pagination and functionality of rules with numerous (2+) exception lists.

- Updated the `use_exception_list.ts` hook to make use of the new multi list find API
- Updated the viewer to make use of the new multi list find API
  - Previously was doing a lot of the filtering and paging manually (and badly) in the UI, now the _find takes care of all that
- Added logic for showing `No results` text if user filter/search returns no items
  - Previously would show the `This rule has not exceptions` text
@yctercero yctercero added the backport This PR is a backport of another PR label Jul 29, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Build metrics

async chunks size

id value diff baseline
securitySolution 7.3MB +2.8KB 7.3MB

page load bundle size

id value diff baseline
lists 269.8KB -24.0B 269.8KB

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@yctercero yctercero merged commit 2d444dc into elastic:7.x Jul 30, 2020
@yctercero yctercero deleted the backport/7.x/pr-73588 branch October 14, 2020 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants