Skip to content

FTR: move basic services under common folder#66563

Merged
dmlemeshko merged 6 commits intoelastic:masterfrom
dmlemeshko:ftr/kibana-qa-owns-ftr-services
May 15, 2020
Merged

FTR: move basic services under common folder#66563
dmlemeshko merged 6 commits intoelastic:masterfrom
dmlemeshko:ftr/kibana-qa-owns-ftr-services

Conversation

@dmlemeshko
Copy link
Copy Markdown
Contributor

@dmlemeshko dmlemeshko commented May 14, 2020 •
edited
Loading

Summary

This PR moves following services under /common folder:

  • browser
  • find
  • testSubjects
  • screenshot
  • snapshot
  • failureDebug

To keep on track with the changes and be able to provide quick feedback on how these services can be used in the best way, I propose assigning Kibana-QA as owners for services under lib, remote and common.

@dmlemeshko dmlemeshko changed the title [skip ci] CODEOWNERS: set kibana-qa to own test/functional/services FTR: move basic services under /common folder May 14, 2020
@dmlemeshko dmlemeshko changed the title FTR: move basic services under /common folder FTR: move basic services under common folder May 14, 2020
@dmlemeshko
Copy link
Copy Markdown
Contributor Author

dmlemeshko commented May 14, 2020

@elasticmachine merge upstream

@LeeDr
Copy link
Copy Markdown

LeeDr commented May 14, 2020 •
edited
Loading

I'm OK with the change.

current list of test/functional/services/

(ones to be moved to test/functional/services/common/)
browser.ts
find.ts
failure_debugging.ts
test_subjects.ts
screenshots.ts
snapshots.ts

(not moving)
apps_menu.ts
combo_box.ts
dashboard/
doc_table.ts
elastic_chart.ts
embedding.ts
filter_bar.ts
flyout.ts
global_nav.ts
index.ts
inspector.ts
lib/
listing_table.ts
query_bar.ts
remote/
renderable.ts
saved_query_management_component.ts
supertest.ts
table.ts
toasts.ts
visualizations/

@dmlemeshko
Copy link
Copy Markdown
Contributor Author

dmlemeshko commented May 15, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 15, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@dmlemeshko dmlemeshko added v7.8.1 v7.9.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes test_ui_functional labels May 15, 2020
@dmlemeshko dmlemeshko marked this pull request as ready for review May 15, 2020 09:33
@dmlemeshko dmlemeshko requested review from LeeDr and wayneseymour May 15, 2020 09:33
LeeDr
LeeDr approved these changes May 15, 2020
View reviewed changes
Copy link
Copy Markdown

@LeeDr LeeDr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Code review and Jenkins check only (and discussed with @dmlemeshko

@dmlemeshko dmlemeshko added v7.8.0 and removed v7.8.1 labels May 15, 2020
@dmlemeshko dmlemeshko merged commit f575913 into elastic:master May 15, 2020
@dmlemeshko dmlemeshko mentioned this pull request May 15, 2020
Merged
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request May 15, 2020
@dmlemeshko @elasticmachine
FTR: move basic services under common folder (elastic#66563)
406f9b1 
* [CODEOWNERS] set kibana-qa to own test/functional/services

* [functional/services] move low-level services to common folder

* update codeowners

* update imports

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	.github/CODEOWNERS
@dmlemeshko dmlemeshko mentioned this pull request May 15, 2020
Merged
dmlemeshko added a commit to dmlemeshko/kibana that referenced this pull request May 15, 2020
@dmlemeshko @elasticmachine
FTR: move basic services under common folder (elastic#66563)
66ae396 
* [CODEOWNERS] set kibana-qa to own test/functional/services

* [functional/services] move low-level services to common folder

* update codeowners

* update imports

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	.github/CODEOWNERS
dmlemeshko added a commit that referenced this pull request May 15, 2020
@dmlemeshko
[7.x] FTR: move basic services under common folder (#66563) (#66780)
15d02d2 
* FTR: move basic services under common folder (#66563)

* [CODEOWNERS] set kibana-qa to own test/functional/services

* [functional/services] move low-level services to common folder

* update codeowners

* update imports

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	.github/CODEOWNERS

* remove CODEOWNERS
dmlemeshko added a commit that referenced this pull request May 15, 2020
@dmlemeshko @elasticmachine
FTR: move basic services under common folder (#66563) (#66782)
d2afe6e 
* [CODEOWNERS] set kibana-qa to own test/functional/services

* [functional/services] move low-level services to common folder

* update codeowners

* update imports

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
# Conflicts:
#	.github/CODEOWNERS
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 15, 2020
@gmmorris
Merge branch 'master' into saved-objects/scoped-client-with-extra-types
d5bddce 
* master: (191 commits)
  [Maps] Get number of categories from palette (elastic#66454)
  move oss features registration to KP (elastic#66524)
  [kbn/plugin-helpers] typescript-ify (elastic#66513)
  Add kibana-operations as codeowners for .ci/es-snapshots and vars/ (elastic#66746)
  FTR: move basic services under common folder (elastic#66563)
  Migrate Beats Management UI to KP (elastic#65791)
  [CI] Add 20 minutes to overall build timeout
  lint import from restricted zones for export exressions (elastic#66588)
  [SIEM][Detection Engine] Add validation for Rule Actions (elastic#63332)
  KP plugins shouldn't need package.json (elastic#66654)
  Replace agent metrics link with the new one (elastic#66632)
  [CI] Add one retry to setup step (elastic#66638)
  [CI] Add slack alerts to tracked branch jobs, change default channel, change formatting (elastic#66580)
  [docLinks] Add docLinks to CoreSetup. (elastic#66631)
  [DOCS] Rename monitoring collection from internal to legacy (elastic#65781)
  unskip newsfeed tests (elastic#66562)
  [NP] Migrate uiSettings owned by Kibana app (elastic#64321)
  [ML] Functional tests - stabilize typing in DFA mml input (elastic#66706)
  [Map] return bounding box for static feature collection without joins (elastic#66607)
  remove trailing slash in graph sample data links (elastic#66358)
  ...
jloleysens added a commit that referenced this pull request May 18, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into feature/pipel…
40e6c71 
…ine-editor

* 'master' of github.com:elastic/kibana: (157 commits)
  [ML] fix url assertion (#66850)
  Skip failing lens test(s). #66779
  [SOM] Preserve saved object references when saving the object (#66584)
  Use ES API from start contract (#66157)
  Reorganize Management apps into Ingest, Data, Alerts and Insights, Security, Kibana, and Stack groups (#65796)
  [Uptime] Fix flaky navigation to certs page in tests (#66806)
  [Maps] Do not check count for blended layers when layer is not visible (#66460)
  [SIEM] Fixes glob patterns from directory changes recently for GraphQL
  chore(NA): bump static-fs to 1.0.2 (#66775)
  [Maps] Handle cross cluster index _settings resp (#66797)
  [SIEM][Lists] Adds 90% of the REST API and client API for exception lists and exception items
  allow any type for customResponseHeaders config (#66689)
  [APM] Disable map layout animation (#66763)
  [ML] Add linking to dataframe from job management tab (#65778)
  [Maps] Get number of categories from palette (#66454)
  move oss features registration to KP (#66524)
  [kbn/plugin-helpers] typescript-ify (#66513)
  Add kibana-operations as codeowners for .ci/es-snapshots and vars/ (#66746)
  FTR: move basic services under common folder (#66563)
  Migrate Beats Management UI to KP (#65791)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form.tsx
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx
@dmlemeshko dmlemeshko deleted the ftr/kibana-qa-owns-ftr-services branch January 31, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wayneseymour wayneseymour Awaiting requested review from wayneseymour

1 more reviewer

@LeeDr LeeDr LeeDr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release_note:skip Skip the PR/issue when compiling release notes test_ui_functional v7.8.0 v7.9.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dmlemeshko @LeeDr @kibanamachine @elasticmachine