[Maps] Handle cross cluster index _settings resp#66797
Merged
nreese merged 1 commit intoelastic:masterfrom May 15, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
kindsun
approved these changes
May 15, 2020
Contributor
kindsun
left a comment
There was a problem hiding this comment.
Thanks for the quick fix on this, lgtm!
- code review
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
May 15, 2020
nreese
added a commit
to nreese/kibana
that referenced
this pull request
May 15, 2020
nreese
added a commit
to nreese/kibana
that referenced
this pull request
May 15, 2020
nreese
added a commit
that referenced
this pull request
May 15, 2020
nreese
added a commit
that referenced
this pull request
May 15, 2020
nreese
added a commit
that referenced
this pull request
May 15, 2020
jloleysens
added a commit
that referenced
this pull request
May 18, 2020
…ine-editor * 'master' of github.com:elastic/kibana: (157 commits) [ML] fix url assertion (#66850) Skip failing lens test(s). #66779 [SOM] Preserve saved object references when saving the object (#66584) Use ES API from start contract (#66157) Reorganize Management apps into Ingest, Data, Alerts and Insights, Security, Kibana, and Stack groups (#65796) [Uptime] Fix flaky navigation to certs page in tests (#66806) [Maps] Do not check count for blended layers when layer is not visible (#66460) [SIEM] Fixes glob patterns from directory changes recently for GraphQL chore(NA): bump static-fs to 1.0.2 (#66775) [Maps] Handle cross cluster index _settings resp (#66797) [SIEM][Lists] Adds 90% of the REST API and client API for exception lists and exception items allow any type for customResponseHeaders config (#66689) [APM] Disable map layout animation (#66763) [ML] Add linking to dataframe from job management tab (#65778) [Maps] Get number of categories from palette (#66454) move oss features registration to KP (#66524) [kbn/plugin-helpers] typescript-ify (#66513) Add kibana-operations as codeowners for .ci/es-snapshots and vars/ (#66746) FTR: move basic services under common folder (#66563) Migrate Beats Management UI to KP (#65791) ... # Conflicts: # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form.tsx # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 18, 2020
* master: [ML] fix url assertion (elastic#66850) Skip failing lens test(s). elastic#66779 [SOM] Preserve saved object references when saving the object (elastic#66584) Use ES API from start contract (elastic#66157) Reorganize Management apps into Ingest, Data, Alerts and Insights, Security, Kibana, and Stack groups (elastic#65796) [Uptime] Fix flaky navigation to certs page in tests (elastic#66806) [Maps] Do not check count for blended layers when layer is not visible (elastic#66460) [SIEM] Fixes glob patterns from directory changes recently for GraphQL chore(NA): bump static-fs to 1.0.2 (elastic#66775) [Maps] Handle cross cluster index _settings resp (elastic#66797) [SIEM][Lists] Adds 90% of the REST API and client API for exception lists and exception items allow any type for customResponseHeaders config (elastic#66689) [APM] Disable map layout animation (elastic#66763) [ML] Add linking to dataframe from job management tab (elastic#65778)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #66776
_settings API returns
{}for remote indices. This response breaks maps application/indexSettingsroute and prevents cross cluster _search requests from settingsizeproperty. This results in relying on default size setting of 10, so only 10 documents get returned.It does not appear that there is an API for getting index settings from a remote index. So the best we can do is fall back to default values.
To test, you can set up cross cluster search by following the instructions at https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#running-remote-clusters
Once you have a remote cluster running, you can test out the _settings API with the following commands in dev tools
GET /kibana_sample_data_ecommerce/_settingswill return expected index settings. Note: kibana_sample_data_ecommerce is an index in the primary clusterGET /*:kibana_sample_data_logs/_settingswill return{}. Note: kibana_sample_data_logs is an index in the remove cluster.