lint import from restricted zones for export exressions#66588
lint import from restricted zones for export exressions#66588mshustov merged 4 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/kibana-platform (Team:Platform) |
| } from '../../siem/server/lib/detection_engine/routes/utils'; | ||
| } from '../../siem/server/lib/detection_engine/routes/utils'; // eslint-disable-line @kbn/eslint/no-restricted-paths | ||
| // eslint-disable-next-line @kbn/eslint/no-restricted-paths | ||
| export { deleteTemplate } from '../../siem/server/lib/detection_engine/index/delete_template'; |
There was a problem hiding this comment.
can it be exported from '../../siem/server? @elastic/siem-security-team
There was a problem hiding this comment.
Yep, we'll do that in a followup, thanks @restrry 👍
There was a problem hiding this comment.
I will handle this in a follow up PR from my side. Appreciate this fix
flash1293
left a comment
There was a problem hiding this comment.
Kibana app changes LGTM 👍
kindsun
left a comment
There was a problem hiding this comment.
Maps changes lgtm!
- code review
cjcenizal
left a comment
There was a problem hiding this comment.
Code changes to Index Management, Ingest Pipelines, License Management, and Watcher LGTM. Didn't test locally.
jen-huang
left a comment
There was a problem hiding this comment.
Ingest manager changes LGTM
afharo
left a comment
There was a problem hiding this comment.
Telemetry changes LGTM!
Files src/plugins/telemetry_management_section/public/index.ts and x-pack/plugins/license_management/public/application/lib/telemetry.ts
spalger
left a comment
There was a problem hiding this comment.
Operations: eslint plugin changes LGTM
chrisronline
left a comment
There was a problem hiding this comment.
LGTM for stack monitoring
walterra
left a comment
There was a problem hiding this comment.
ML/transform changes LGTM
|
@elasticmachine merge upstream |
jonathan-buttner
left a comment
There was a problem hiding this comment.
Looks good from an Endpoint side.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* line restricted zones for export exressions * more robust rule * fix or mute eslint errors Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
* master: (191 commits) [Maps] Get number of categories from palette (elastic#66454) move oss features registration to KP (elastic#66524) [kbn/plugin-helpers] typescript-ify (elastic#66513) Add kibana-operations as codeowners for .ci/es-snapshots and vars/ (elastic#66746) FTR: move basic services under common folder (elastic#66563) Migrate Beats Management UI to KP (elastic#65791) [CI] Add 20 minutes to overall build timeout lint import from restricted zones for export exressions (elastic#66588) [SIEM][Detection Engine] Add validation for Rule Actions (elastic#63332) KP plugins shouldn't need package.json (elastic#66654) Replace agent metrics link with the new one (elastic#66632) [CI] Add one retry to setup step (elastic#66638) [CI] Add slack alerts to tracked branch jobs, change default channel, change formatting (elastic#66580) [docLinks] Add docLinks to CoreSetup. (elastic#66631) [DOCS] Rename monitoring collection from internal to legacy (elastic#65781) unskip newsfeed tests (elastic#66562) [NP] Migrate uiSettings owned by Kibana app (elastic#64321) [ML] Functional tests - stabilize typing in DFA mml input (elastic#66706) [Map] return bounding box for static feature collection without joins (elastic#66607) remove trailing slash in graph sample data links (elastic#66358) ...
Added linting for
exportexpressions as well.Fixed errors whenever it's possible and mute others. Codeowners should correct them later.