[Discover] Deangularize the hits counter and create a react component#65631
Merged
stratoula merged 6 commits intoelastic:masterfrom May 8, 2020
Merged
Conversation
Contributor
Author
|
@elasticmachine merge upstream |
cchaos
reviewed
May 7, 2020
Contributor
cchaos
left a comment
There was a problem hiding this comment.
Awesome. So happy to see more React conversions! My comments are mostly enhancements.
src/plugins/discover/public/application/components/hits_counter/hits_counter.tsx
Outdated
Show resolved
Hide resolved
src/plugins/discover/public/application/components/hits_counter/hits_counter.tsx
Show resolved
Hide resolved
kertal
reviewed
May 8, 2020
src/plugins/discover/public/application/components/hits_counter/hits_counter.test.tsx
Outdated
Show resolved
Hide resolved
kertal
reviewed
May 8, 2020
src/plugins/discover/public/application/components/hits_counter/hits_counter.test.tsx
Outdated
Show resolved
Hide resolved
kertal
reviewed
May 8, 2020
src/plugins/discover/public/application/helpers/format_number_with_commas.ts
Outdated
Show resolved
Hide resolved
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
kertal
approved these changes
May 8, 2020
Member
kertal
left a comment
There was a problem hiding this comment.
Code LGTM, tested locally (MacOs 10.14.6), Safari, Firefox, Chrome, all fine. Thx a lot for moving another brick of the Discover wall to React 🧱 !
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Contributor
|
UI looks great! Weirdly, I can't get the "Reset" button to work in Firefox or Chrome. Steps:
|
Contributor
Author
cchaos
approved these changes
May 8, 2020
Contributor
cchaos
left a comment
There was a problem hiding this comment.
👍 The primary goal of the PR, de-angularization, LGTM. Though the functionality is broken as mentioned in the comments.
stratoula
added a commit
to stratoula/kibana
that referenced
this pull request
May 8, 2020
…elastic#65631) * Deangularize the hits counter and create a react component * Add aria-label to button for accessibility * Add icon to the link button and use EuiText * Remove snapshots and test with findTestSubject * Change toString with String() Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
stratoula
added a commit
that referenced
this pull request
May 11, 2020
…#65631) (#65881) * Deangularize the hits counter and create a react component * Add aria-label to button for accessibility * Add icon to the link button and use EuiText * Remove snapshots and test with findTestSubject * Change toString with String() Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 11, 2020
* master: (58 commits) [Drilldowns][chore] import dashboard url generator from plugin contract (elastic#64628) fix double flyouts in add panel flow (elastic#65861) Point 7.x to 7.9.0 in .backportrc.json Mount ui/new_platform applications in same div structure as Core (elastic#63930) [Uptime] Settings threshold validation (elastic#65454) Fix edit alert flyout to update initialAlert after edit (elastic#65359) Fix anomalies display on focused APM service map (elastic#65882) [SIEM][Detection Engine] Increases the template limit for ECS mappings [SIEM][CASE] Moves functional tests from "legacyEs" to "Es" (elastic#65851) [Metrics UI] Fix p95/p99 charts and alerting error (elastic#65579) [ML] Add job timing stats to anomaly jobs (elastic#65696) restore index pattern management data-test-subj's (elastic#64697) [Discover] Prevent whitespace wrapping of doc table header (elastic#52861) [SIEM] Fixes a CSS issue with Timeline field truncation (elastic#65789) Skipping failing tests. elastic#65867 elastic#65866 elastic#65865 [Discover] Deangularize the hits counter and create a react component (elastic#65631) Tsvb less update (elastic#65467) [TSVB] Remove remaining lodash.set usage (elastic#65846) [Uptime] Add `a11y` tests (elastic#65514) [Uptime] Enable loading on monitor list (elastic#65670) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #65326
Deangularize the result counter (#65326). Created a hitsCounter React Component.
Checklist