[Discover] Prevent whitespace wrapping of doc table header#52861
[Discover] Prevent whitespace wrapping of doc table header#52861kertal merged 5 commits intoelastic:masterfrom
Conversation
💚 Build SucceededTo update your PR or re-run it, just comment with: |
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
|
@elasticmachine merge upstream |
|
merge conflict between base and head |
…-12-discover-table-header-wrap
|
@elasticmachine merge upstream |
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
|
@elasticmachine merge upstream |
snide
left a comment
There was a problem hiding this comment.
Tested in browser. This works. Could cause problems eventually with long field names, but since any field should not contain spaces anyway, i think this would be the preferred functionality.
src/plugins/discover/public/application/angular/doc_table/components/_table_header.scss
Outdated
Show resolved
Hide resolved
Co-authored-by: Dave Snider <dave.snider@gmail.com>
Yes, there's a problem with very long fields that define the width of the column here, but that's not that easy to fix, so it's up to our DataGrid then. |
stratoula
left a comment
There was a problem hiding this comment.
LGTM! Tested on chrome, safari and firefox and sees legit
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
…2861) Co-authored-by: Dave Snider <dave.snider@gmail.com>
* master: (58 commits) [Drilldowns][chore] import dashboard url generator from plugin contract (elastic#64628) fix double flyouts in add panel flow (elastic#65861) Point 7.x to 7.9.0 in .backportrc.json Mount ui/new_platform applications in same div structure as Core (elastic#63930) [Uptime] Settings threshold validation (elastic#65454) Fix edit alert flyout to update initialAlert after edit (elastic#65359) Fix anomalies display on focused APM service map (elastic#65882) [SIEM][Detection Engine] Increases the template limit for ECS mappings [SIEM][CASE] Moves functional tests from "legacyEs" to "Es" (elastic#65851) [Metrics UI] Fix p95/p99 charts and alerting error (elastic#65579) [ML] Add job timing stats to anomaly jobs (elastic#65696) restore index pattern management data-test-subj's (elastic#64697) [Discover] Prevent whitespace wrapping of doc table header (elastic#52861) [SIEM] Fixes a CSS issue with Timeline field truncation (elastic#65789) Skipping failing tests. elastic#65867 elastic#65866 elastic#65865 [Discover] Deangularize the hits counter and create a react component (elastic#65631) Tsvb less update (elastic#65467) [TSVB] Remove remaining lodash.set usage (elastic#65846) [Uptime] Add `a11y` tests (elastic#65514) [Uptime] Enable loading on monitor list (elastic#65670) ...
Summary
Improves legacy doc table whitespace wrapping used in Discover and Dashboard. Will be redundant with #51531, but since it's a pretty simple fix, and looks much better this way, let's improve it a bit earlier.
Before:
After:
Fixes: #56529