[Uptime] Settings threshold validation#65454
Merged
shahzad31 merged 7 commits intoelastic:masterfrom May 10, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
justinkambic
requested changes
May 6, 2020
Contributor
justinkambic
left a comment
There was a problem hiding this comment.
Client code looks good. We probably want to update the server to validate against this case as well and return an error if it receives a bad request. I can still save invalid settings values for these fields by posting to the API directly.
| }); | ||
|
|
||
| export const VALID_STR = i18n.translate('xpack.uptime.settings.invalid.error', { | ||
| defaultMessage: 'Not a valid value.', |
Contributor
There was a problem hiding this comment.
Maybe this should say "Must be greater than 0."
Contributor
Author
|
@justinkambic added validation on API |
justinkambic
approved these changes
May 8, 2020
Contributor
justinkambic
left a comment
There was a problem hiding this comment.
LGTM WFG
I tested this for both values, validation is working great. Thanks!
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
user doesn't have permission to update head repository |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 11, 2020
* master: (58 commits) [Drilldowns][chore] import dashboard url generator from plugin contract (elastic#64628) fix double flyouts in add panel flow (elastic#65861) Point 7.x to 7.9.0 in .backportrc.json Mount ui/new_platform applications in same div structure as Core (elastic#63930) [Uptime] Settings threshold validation (elastic#65454) Fix edit alert flyout to update initialAlert after edit (elastic#65359) Fix anomalies display on focused APM service map (elastic#65882) [SIEM][Detection Engine] Increases the template limit for ECS mappings [SIEM][CASE] Moves functional tests from "legacyEs" to "Es" (elastic#65851) [Metrics UI] Fix p95/p99 charts and alerting error (elastic#65579) [ML] Add job timing stats to anomaly jobs (elastic#65696) restore index pattern management data-test-subj's (elastic#64697) [Discover] Prevent whitespace wrapping of doc table header (elastic#52861) [SIEM] Fixes a CSS issue with Timeline field truncation (elastic#65789) Skipping failing tests. elastic#65867 elastic#65866 elastic#65865 [Discover] Deangularize the hits counter and create a react component (elastic#65631) Tsvb less update (elastic#65467) [TSVB] Remove remaining lodash.set usage (elastic#65846) [Uptime] Add `a11y` tests (elastic#65514) [Uptime] Enable loading on monitor list (elastic#65670) ...
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
May 12, 2020
shahzad31
added a commit
to shahzad31/kibana
that referenced
this pull request
May 12, 2020
shahzad31
added a commit
that referenced
this pull request
May 12, 2020
Contributor
|
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
shahzad31
added a commit
that referenced
this pull request
May 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #65381
Prevent user from adding negative values in certificate expiration and ge threshold.