[Metrics UI] Fix p95/p99 charts and alerting error#65579
Merged
simianhacker merged 4 commits intoelastic:masterfrom May 8, 2020
Merged
[Metrics UI] Fix p95/p99 charts and alerting error#65579simianhacker merged 4 commits intoelastic:masterfrom
simianhacker merged 4 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
Zacqary
requested changes
May 7, 2020
Contributor
Zacqary
left a comment
There was a problem hiding this comment.
Changes look good, I'd just like to see test coverage on P95, also small code style nit
x-pack/plugins/infra/server/lib/alerting/metric_threshold/metric_threshold_executor.test.ts
Show resolved
Hide resolved
x-pack/plugins/infra/server/lib/alerting/metric_threshold/metric_threshold_executor.ts
Show resolved
Hide resolved
Zacqary
requested changes
May 7, 2020
Contributor
Zacqary
left a comment
There was a problem hiding this comment.
Also, looks like the percentile aggregators aren't showing up in the Alert Flyout for me:
They are available in the metrics explorer, but when I select it and try to create an alert using the Actions menu:
Member
Author
|
@Zacqary Did you refresh the browser? It's showing up for me.
|
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Member
Author
|
@Zacqary This is ready for another look |
Zacqary
reviewed
May 8, 2020
Contributor
Zacqary
left a comment
There was a problem hiding this comment.
Code changes look good, doing another test to confirm that the frontend works
Zacqary
approved these changes
May 8, 2020
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
May 8, 2020
* [Metrics UI] Fix p95/p99 charts and alerting error - Fixes elastic#65561 * Fixing open in visualize for percentiles * Adding test for P95; refactoring to use first consitently
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
May 8, 2020
* [Metrics UI] Fix p95/p99 charts and alerting error - Fixes elastic#65561 * Fixing open in visualize for percentiles * Adding test for P95; refactoring to use first consitently
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 11, 2020
* master: (58 commits) [Drilldowns][chore] import dashboard url generator from plugin contract (elastic#64628) fix double flyouts in add panel flow (elastic#65861) Point 7.x to 7.9.0 in .backportrc.json Mount ui/new_platform applications in same div structure as Core (elastic#63930) [Uptime] Settings threshold validation (elastic#65454) Fix edit alert flyout to update initialAlert after edit (elastic#65359) Fix anomalies display on focused APM service map (elastic#65882) [SIEM][Detection Engine] Increases the template limit for ECS mappings [SIEM][CASE] Moves functional tests from "legacyEs" to "Es" (elastic#65851) [Metrics UI] Fix p95/p99 charts and alerting error (elastic#65579) [ML] Add job timing stats to anomaly jobs (elastic#65696) restore index pattern management data-test-subj's (elastic#64697) [Discover] Prevent whitespace wrapping of doc table header (elastic#52861) [SIEM] Fixes a CSS issue with Timeline field truncation (elastic#65789) Skipping failing tests. elastic#65867 elastic#65866 elastic#65865 [Discover] Deangularize the hits counter and create a react component (elastic#65631) Tsvb less update (elastic#65467) [TSVB] Remove remaining lodash.set usage (elastic#65846) [Uptime] Add `a11y` tests (elastic#65514) [Uptime] Enable loading on monitor list (elastic#65670) ...
simianhacker
added a commit
that referenced
this pull request
May 11, 2020
* [Metrics UI] Fix p95/p99 charts and alerting error - Fixes #65561 * Fixing open in visualize for percentiles * Adding test for P95; refactoring to use first consitently Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
simianhacker
added a commit
that referenced
this pull request
May 11, 2020
* [Metrics UI] Fix p95/p99 charts and alerting error - Fixes #65561 * Fixing open in visualize for percentiles * Adding test for P95; refactoring to use first consitently Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes #65561 by restoring changes to the series chart that was overridden in a bad merge. This also add support for p95/p99 aggregations for alerts. There was a fatal exception that was being thrown when the user tried to create an alerts while the user had percentiles selected in Metrics Explorer.
Checklist
Delete any items that are not applicable to this PR.