[Lens] Type safe migrations#65576
Merged
wylieconlon merged 6 commits intoelastic:masterfrom May 7, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
pgayvallet
approved these changes
May 7, 2020
Contributor
pgayvallet
left a comment
There was a problem hiding this comment.
LGTM.
Would superseed #65569.
rudolf
reviewed
May 7, 2020
Contributor
rudolf
left a comment
There was a problem hiding this comment.
It seems like the code is often more defensive than the type by using optional chaining even if the type says it should always be defined. I don't think we should relax the code, better to be defensive, but if there's any doubt that these properties might not exist I think it's better to reflect that in the type too.
mbondyra
approved these changes
May 7, 2020
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@rudolf The chaining operations are there because they used to be needed, but you're right that they are no longer necessary. They are there because I didn't rewrite the migrations entirely. I can update. |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
wylieconlon
pushed a commit
to wylieconlon/kibana
that referenced
this pull request
May 7, 2020
* [Lens] Type safe migrations * Commit API changes * Remove optional chaining for required properties Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
wylieconlon
pushed a commit
that referenced
this pull request
May 7, 2020
* [Lens] Type safe migrations * Commit API changes * Remove optional chaining for required properties Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
May 8, 2020
…or-part-mvp-2 * 'master' of github.com:elastic/kibana: (259 commits) SavedObjects bulkCreate API should return migrationVersion and strip the type & namespace from the id (elastic#65150) Drilldown count tooltip (elastic#65105) plugins logs start with "plugins." prefix (elastic#65710) [ML] Fix pagination reset on search query update. (elastic#65668) [SIEM] Add types to the mappings objects so extra keys cannot be introduced [apm] Update machine learning flyout and service maps docs (elastic#65517) change api endpoint and throw error (elastic#65790) [Maps] remove SLA percentage metric (elastic#65718) [Reporting] APM integration for baseline performance measurements (elastic#59967) fix(NA): noParse regex for windows on kbn optimizer (elastic#65755) [ML] DFA: ensure at least one field is included in analysis before job can be created (elastic#65320) [Data plugin] cleanup - remove unused getRoutes / routes from indexPattern object (elastic#65683) Removed skip to enable test. (elastic#65575) [Lens] Type safe migrations (elastic#65576) [Canvas] Fix nav link behavior in Canvas (elastic#65590) [Event log] Fix flaky test (elastic#65658) [Alerting] changes preconfigured actions config from array to object (elastic#65397) remove immediate functions from esqueue worker cycles (elastic#65375) [Metrics UI] Fix isAbove to only display when threshold set (elastic#65540) draft search profiler accessibility tests (elastic#62357) ... # Conflicts: # x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #64748
Checklist