-
Notifications
You must be signed in to change notification settings - Fork 8.6k
Add attributes types in SavedObjects migration #64748
Copy link
Copy link
Closed
Labels
Feature:Saved ObjectsTeam:VisualizationsTeam label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//choreimpact:lowAddressing this issue will have a low level of impact on the quality/strength of our product.Addressing this issue will have a low level of impact on the quality/strength of our product.loe:smallSmall Level of EffortSmall Level of Efforttechnical debtImprovement of the software architecture and operational architectureImprovement of the software architecture and operational architecture
Metadata
Metadata
Assignees
Labels
Feature:Saved ObjectsTeam:VisualizationsTeam label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t//choreimpact:lowAddressing this issue will have a low level of impact on the quality/strength of our product.Addressing this issue will have a low level of impact on the quality/strength of our product.loe:smallSmall Level of EffortSmall Level of Efforttechnical debtImprovement of the software architecture and operational architectureImprovement of the software architecture and operational architecture
Type
Fields
Give feedbackNo fields configured for issues without a type.
In #63943 we added generic types for
SavedObjectMigrationFninput and output doc attributes. As these attributes were previously typed asany, some explicit<any, any>were added in existing plugins migrations as a temporary measure.Now that
SavedObjectMigrationFnallows type checking, the existing migrations should leverage it to ensure that migrated docs are correctly typed.The initial PR introduced
<any, any>changes in the following files:@elastic/kibana-app
src/plugins/vis_type_timeseries/server/saved_objects/tsvb_telemetry.tsx-pack/plugins/graph/server/saved_objects/migrations.tsx-pack/plugins/lens/server/migrations.ts@elastic/kibana-presentation
src/plugins/dashboard/server/saved_objects/dashboard_migrations.tssrc/plugins/dashboard/server/saved_objects/migrate_match_all_query.ts@elastic/kibana-app-arch
src/plugins/visualizations/server/saved_objects/visualization_migrations.tssrc/plugins/data/server/saved_objects/index_pattern_migrations.tssrc/plugins/data/server/saved_objects/search_migrations.ts@elastic/kibana-security
x-pack/plugins/spaces/server/saved_objects/migrations/migrate_6x.ts