Skip to content

[apm] Update machine learning flyout and service maps docs#65517

Merged
bmorelli25 merged 4 commits intoelastic:masterfrom
bmorelli25:7.8-service-maps
May 8, 2020
Merged

[apm] Update machine learning flyout and service maps docs#65517
bmorelli25 merged 4 commits intoelastic:masterfrom
bmorelli25:7.8-service-maps

Conversation

@bmorelli25
Copy link
Copy Markdown
Member

@bmorelli25 bmorelli25 commented May 6, 2020 •
edited
Loading

Summary

This PR updates the machineLearningFlyout, screenshots and documentation for Service maps anomaly detection, and documentation for machine learning.

Before
Screen Shot 2020-05-06 at 8 38 27 AM

After
Screen Shot 2020-05-06 at 8 43 33 AM

Docs
Screen Shot 2020-05-06 at 10 15 42 AM

Closes elastic/apm#261.

@bmorelli25 bmorelli25 added Team:APM - DEPRECATED Use Team:obs-ux-infra_services. release_note:skip Skip the PR/issue when compiling release notes v7.8.0 labels May 6, 2020
@bmorelli25 bmorelli25 requested a review from a team May 6, 2020 17:04
@bmorelli25 bmorelli25 self-assigned this May 6, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented May 6, 2020

Pinging @elastic/apm-ui (Team:apm)

@bmorelli25
Copy link
Copy Markdown
Member Author

bmorelli25 commented May 6, 2020

Hmm. I know there's something I need to do to fix the internationalization check, but I don't remember what.

As for the other test, I'm assuming I broke something by changing the flyout panel text, but I'm not sure what:

  1) machine learning
       anomaly detection
         single metric
           job cloning creates the job and finishes processing:
     Error: expected testSubject(mlJobWizardButtonCreateJob) to exist
      at TestSubjects.existOrFail (/dev/shm/workspace/kibana/test/functional/services/test_subjects.ts:62:15)

               └- ✖ fail: "machine learning anomaly detection single metric job cloning creates the job and finishes processing"
               │
             └-> "after all" hook
             └-> "after all" hook
           └-> "after all" hook
         └-> "after all" hook
         └-> "after all" hook

@smith
Copy link
Copy Markdown
Contributor

smith commented May 6, 2020

You can run the i18n check with node ./scripts/i18n_check.js --fix

As for that failure, I'm guessing that it looks related but might not be, so I would try retesting this and see if it passes. It'll run them all again anyway if you push up i18n fixes.

@bmorelli25
Copy link
Copy Markdown
Member Author

bmorelli25 commented May 7, 2020

@elasticmachine merge upstream

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented May 7, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sorenlouv
sorenlouv approved these changes May 7, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@bmorelli25 bmorelli25 merged commit 23e7cc7 into elastic:master May 8, 2020
@bmorelli25 bmorelli25 deleted the 7.8-service-maps branch May 8, 2020 00:54
@bmorelli25 bmorelli25 mentioned this pull request May 8, 2020
Merged
bmorelli25 added a commit to bmorelli25/kibana that referenced this pull request May 8, 2020
@bmorelli25
[apm] Update machine learning flyout and service maps docs (elastic#6…
f2bb5e0 
…5517)
bmorelli25 added a commit to bmorelli25/kibana that referenced this pull request May 8, 2020
@bmorelli25
[apm] Update machine learning flyout and service maps docs (elastic#6…
4e24046 
…5517)
@bmorelli25 bmorelli25 mentioned this pull request May 8, 2020
Merged
jloleysens added a commit to jloleysens/kibana that referenced this pull request May 8, 2020
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into pipeline-edit…
c7fe2db 
…or-part-mvp-2

* 'master' of github.com:elastic/kibana: (259 commits)
  SavedObjects bulkCreate API should return migrationVersion and strip the type & namespace from the id (elastic#65150)
  Drilldown count tooltip (elastic#65105)
  plugins logs start with "plugins." prefix (elastic#65710)
  [ML] Fix pagination reset on search query update. (elastic#65668)
  [SIEM] Add types to the mappings objects so extra keys cannot be introduced
  [apm] Update machine learning flyout and service maps docs (elastic#65517)
  change api endpoint and throw error (elastic#65790)
  [Maps] remove SLA percentage metric (elastic#65718)
  [Reporting] APM integration for baseline performance measurements (elastic#59967)
  fix(NA): noParse regex for windows on kbn optimizer (elastic#65755)
  [ML] DFA: ensure at least one field is included in analysis before job can be created (elastic#65320)
  [Data plugin] cleanup - remove unused getRoutes / routes from indexPattern object (elastic#65683)
  Removed skip to enable test. (elastic#65575)
  [Lens] Type safe migrations (elastic#65576)
  [Canvas] Fix nav link behavior in Canvas  (elastic#65590)
  [Event log] Fix flaky test (elastic#65658)
  [Alerting] changes preconfigured actions config from array to object (elastic#65397)
  remove immediate functions from esqueue worker cycles (elastic#65375)
  [Metrics UI] Fix isAbove to only display when threshold set (elastic#65540)
  draft search profiler accessibility tests (elastic#62357)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx
bmorelli25 added a commit that referenced this pull request May 8, 2020
@bmorelli25
[apm] Update machine learning flyout and service maps docs (#65517) (#…
33544c8 
…65805)
bmorelli25 added a commit that referenced this pull request May 8, 2020
@bmorelli25
[apm] Update machine learning flyout and service maps docs (#65517) (#…
ed5dcf1 
…65806)
@sorenlouv sorenlouv added the apm:test-plan-done Pull request that was successfully tested during the test plan label May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sorenlouv sorenlouv sorenlouv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

apm:test-plan-done Pull request that was successfully tested during the test plan release_note:skip Skip the PR/issue when compiling release notes Team:APM - DEPRECATED Use Team:obs-ux-infra_services. v7.8.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[docs] Document health indicators on service maps

5 participants

@bmorelli25 @elasticmachine @smith @kibanamachine @sorenlouv