Skip to content

fix(NA): noParse regex for windows on kbn optimizer#65755

Merged
mistic merged 1 commit intoelastic:masterfrom
mistic:fix-regex-for-windos-on-optimizer-worker
May 7, 2020
Merged

fix(NA): noParse regex for windows on kbn optimizer#65755
mistic merged 1 commit intoelastic:masterfrom
mistic:fix-regex-for-windos-on-optimizer-worker

Conversation

@mistic
Copy link
Copy Markdown
Contributor

@mistic mistic commented May 7, 2020

That fixes the regex with the correct path separator for windows otherwise the warning we found on #63849 will throw on that OS.

@mistic mistic added chore Team:Operations Kibana-Operations Team build v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.9.0 v7.8.1 labels May 7, 2020
@mistic mistic requested a review from peteharverson May 7, 2020 19:10
@mistic mistic requested a review from a team as a code owner May 7, 2020 19:10
@mistic mistic self-assigned this May 7, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM

Copy link
Copy Markdown
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🤦

@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mistic mistic merged commit d7f847e into elastic:master May 7, 2020
@mistic
Copy link
Copy Markdown
Contributor Author

mistic commented May 7, 2020

7.x: 9d7e0d9
7.8: aec8f55

mistic added a commit to mistic/kibana that referenced this pull request May 7, 2020
mistic added a commit to mistic/kibana that referenced this pull request May 7, 2020
jloleysens added a commit to jloleysens/kibana that referenced this pull request May 8, 2020
…or-part-mvp-2

* 'master' of github.com:elastic/kibana: (259 commits)
  SavedObjects bulkCreate API should return migrationVersion and strip the type & namespace from the id (elastic#65150)
  Drilldown count tooltip (elastic#65105)
  plugins logs start with "plugins." prefix (elastic#65710)
  [ML] Fix pagination reset on search query update. (elastic#65668)
  [SIEM] Add types to the mappings objects so extra keys cannot be introduced
  [apm] Update machine learning flyout and service maps docs (elastic#65517)
  change api endpoint and throw error (elastic#65790)
  [Maps] remove SLA percentage metric (elastic#65718)
  [Reporting] APM integration for baseline performance measurements (elastic#59967)
  fix(NA): noParse regex for windows on kbn optimizer (elastic#65755)
  [ML] DFA: ensure at least one field is included in analysis before job can be created (elastic#65320)
  [Data plugin] cleanup - remove unused getRoutes / routes from indexPattern object (elastic#65683)
  Removed skip to enable test. (elastic#65575)
  [Lens] Type safe migrations (elastic#65576)
  [Canvas] Fix nav link behavior in Canvas  (elastic#65590)
  [Event log] Fix flaky test (elastic#65658)
  [Alerting] changes preconfigured actions config from array to object (elastic#65397)
  remove immediate functions from esqueue worker cycles (elastic#65375)
  [Metrics UI] Fix isAbove to only display when threshold set (elastic#65540)
  draft search profiler accessibility tests (elastic#62357)
  ...

# Conflicts:
#	x-pack/plugins/ingest_pipelines/public/application/components/pipeline_form/pipeline_form_fields.tsx
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build chore release_note:skip Skip the PR/issue when compiling release notes Team:Operations Kibana-Operations Team v7.8.1 v7.9.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants