Change the copy from blacklist to blocklist#65419
Conversation
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
9c8eb39 to
0df2899
Compare
|
yey! First PR 🥳 |
flash1293
left a comment
There was a problem hiding this comment.
Tested in Chrome and works as expected. I'm not 100% sure whether "blocklist" is a proper verb - another option would be "Block selection from return to workspace" or "Exclude selection from return to workspace".
@gchaps What do you think? Are you fine with "Blocklist selection from return to workspace"?
@stratoula Sorry, completely missed this in the issue description, it wasn't really clear.
No prob at all! Let's agree on the final message and I will change it :) |
|
@stratoula Can you please include a screenshot of the revised copy? |
|
@gchaps here it is |
|
Thanks, @stratoula. I'm confused by what "return to workspace" means. Can it be simplified to "Block selection from graph" |
|
@gchaps ”Return to workspace” means if you are searching for new data or expanding selections, this term won’t show up again. |
|
Maybe one of the following? Block selection from appearing in workspace. OR the original Block selection from returning to workspace |
|
I like “ Block selection from appearing in workspace” - that’s explaining it well in simple terms. Thanks @gchaps ! @stratoula could you update the PR? |
0df2899 to
564467e
Compare
|
Sure @flash1293 @gchaps, I have updated the PR! |
flash1293
left a comment
There was a problem hiding this comment.
LGTM once green, didn't test again.
|
@elasticmachine merge upstream |
timroes
left a comment
There was a problem hiding this comment.
Reviewed code change only. LGTM
…ttional-flaky * upstream/master: (49 commits) Move remaining home assets to the new platform (elastic#65053) Change the copy and the id from blacklist to block list for consistency (elastic#65419) [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522) [ML] Fix the limit control on the Anomaly explorer page (elastic#65459) [Mappings editor] Add component integration tests (elastic#63853) [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456) [Logs UI] Disable search bar when live stream is on. (elastic#65491) fix SavedObjectMigrationMap type (elastic#65569) [Uptime] Improve cert flaky test (elastic#65458) [Uptime] Fix monitor list result runtime type, ip can be null (elastic#65532) [APM] Agent configuration: Bug makes it possible to create invalid configurations (elastic#65508) [APM] Remove link from active page in the breadcrumb (elastic#65473) [SIEM] Fixes test flakiness (elastic#65510) [ESLint] update @kbn/eslint/no-restricted-paths rule to allow imports mocks from folder (elastic#65471) Migrate test plugins ⇒ NP (kbn_tp_run_pipeline) (elastic#64780) move core provier to NP. allows to run tests on every page (elastic#64929) Extended alerting documentation with information about using Kibana keystore and action types for preconfigured connectors (elastic#65201) [functional tests] add some missing awaits (elastic#65566) Fixed create new connector from alert flyout form throw an error messages in external plugins. (elastic#65539) [SIEM] [Cases] External services not getting all comments bug fix (elastic#65307) ...
…cy (elastic#65419) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* master: [ML] Transforms: Fix API error message display for edit flyout. (elastic#65494) [SIEM][Detection Engine] Fixes import bug with non existent signals index (elastic#65595) [Lens] Use rules of hooks with linting (elastic#65593) [ML] Migrate server side Mocha tests to Jest. (elastic#65651) Fixes the client to setup SSL with the CA certificates for testing (elastic#65598) reduce uptime plugin initial bundle size (elastic#65257) [ML] Consolidating shared types and util functions (elastic#65247) [Drilldowns] Preserve state when selecting different action factory (elastic#65074) Migrate test plugins ⇒ NP (kbn_tp_embeddable_explorer) (elastic#64756) Move remaining home assets to the new platform (elastic#65053) Change the copy and the id from blacklist to block list for consistency (elastic#65419) [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522) [ML] Fix the limit control on the Anomaly explorer page (elastic#65459) [Mappings editor] Add component integration tests (elastic#63853) [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456) [Logs UI] Disable search bar when live stream is on. (elastic#65491)
…ponents * alerting/lazy-load-actions: align and style loading indicator [ML] Transforms: Fix API error message display for edit flyout. (elastic#65494) [SIEM][Detection Engine] Fixes import bug with non existent signals index (elastic#65595) [Lens] Use rules of hooks with linting (elastic#65593) [ML] Migrate server side Mocha tests to Jest. (elastic#65651) Fixes the client to setup SSL with the CA certificates for testing (elastic#65598) reduce uptime plugin initial bundle size (elastic#65257) [ML] Consolidating shared types and util functions (elastic#65247) [Drilldowns] Preserve state when selecting different action factory (elastic#65074) Migrate test plugins ⇒ NP (kbn_tp_embeddable_explorer) (elastic#64756) Move remaining home assets to the new platform (elastic#65053) Change the copy and the id from blacklist to block list for consistency (elastic#65419) [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522) [ML] Fix the limit control on the Anomaly explorer page (elastic#65459) [Mappings editor] Add component integration tests (elastic#63853) [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456) [Logs UI] Disable search bar when live stream is on. (elastic#65491)
Fixes #62133
Fix inconsistent copy introduced from #62133