[SIEM] [Cases] External services not getting all comments bug fix#65307
Merged
stephmilovic merged 9 commits intoelastic:masterfrom May 6, 2020
Merged
[SIEM] [Cases] External services not getting all comments bug fix#65307stephmilovic merged 9 commits intoelastic:masterfrom
stephmilovic merged 9 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
cnasikas
reviewed
May 5, 2020
x-pack/plugins/siem/public/containers/case/use_get_case_user_actions.tsx
Outdated
Show resolved
Hide resolved
cnasikas
reviewed
May 5, 2020
x-pack/plugins/siem/public/containers/case/use_get_case_user_actions.tsx
Outdated
Show resolved
Hide resolved
stephmilovic
commented
May 5, 2020
x-pack/plugins/siem/public/containers/case/use_get_case_user_actions.tsx
Outdated
Show resolved
Hide resolved
Member
|
I found this bug. It occurs randomly and I cannot reproduce it every time. The push button is not being shown always when you change connectors.
|
Contributor
Author
|
|
cnasikas
approved these changes
May 6, 2020
Member
cnasikas
left a comment
There was a problem hiding this comment.
LGTM! Great job! I tested locally and everything is working fine.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
user doesn't have permission to update head repository |
Contributor
💛 Build succeeded, but was flaky
History
To update your PR or re-run it, just comment with: |
stephmilovic
added a commit
to stephmilovic/kibana
that referenced
this pull request
May 6, 2020
stephmilovic
added a commit
to stephmilovic/kibana
that referenced
this pull request
May 6, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 7, 2020
* master: (42 commits) fix SavedObjectMigrationMap type (elastic#65569) [Uptime] Improve cert flaky test (elastic#65458) [Uptime] Fix monitor list result runtime type, ip can be null (elastic#65532) [APM] Agent configuration: Bug makes it possible to create invalid configurations (elastic#65508) [APM] Remove link from active page in the breadcrumb (elastic#65473) [SIEM] Fixes test flakiness (elastic#65510) [ESLint] update @kbn/eslint/no-restricted-paths rule to allow imports mocks from folder (elastic#65471) Migrate test plugins ⇒ NP (kbn_tp_run_pipeline) (elastic#64780) move core provier to NP. allows to run tests on every page (elastic#64929) Extended alerting documentation with information about using Kibana keystore and action types for preconfigured connectors (elastic#65201) [functional tests] add some missing awaits (elastic#65566) Fixed create new connector from alert flyout form throw an error messages in external plugins. (elastic#65539) [SIEM] [Cases] External services not getting all comments bug fix (elastic#65307) Migrate Coordinate Maps to NP (elastic#64668) Updating Canvas location in nav (elastic#65519) [SIEM][Lists] Fixes up contracts to work outside of requests [Lens] Remove "inside only" option for treemap labels (elastic#65363) [Uptime] Add TLS alert functional test (elastic#65303) Fix z-index of kbnLoadingIndicator (elastic#65521) Fixed indice assertion to loop through expected keys (elastic#64684) ...
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 7, 2020
…ttional-flaky * upstream/master: (49 commits) Move remaining home assets to the new platform (elastic#65053) Change the copy and the id from blacklist to block list for consistency (elastic#65419) [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522) [ML] Fix the limit control on the Anomaly explorer page (elastic#65459) [Mappings editor] Add component integration tests (elastic#63853) [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456) [Logs UI] Disable search bar when live stream is on. (elastic#65491) fix SavedObjectMigrationMap type (elastic#65569) [Uptime] Improve cert flaky test (elastic#65458) [Uptime] Fix monitor list result runtime type, ip can be null (elastic#65532) [APM] Agent configuration: Bug makes it possible to create invalid configurations (elastic#65508) [APM] Remove link from active page in the breadcrumb (elastic#65473) [SIEM] Fixes test flakiness (elastic#65510) [ESLint] update @kbn/eslint/no-restricted-paths rule to allow imports mocks from folder (elastic#65471) Migrate test plugins ⇒ NP (kbn_tp_run_pipeline) (elastic#64780) move core provier to NP. allows to run tests on every page (elastic#64929) Extended alerting documentation with information about using Kibana keystore and action types for preconfigured connectors (elastic#65201) [functional tests] add some missing awaits (elastic#65566) Fixed create new connector from alert flyout form throw an error messages in external plugins. (elastic#65539) [SIEM] [Cases] External services not getting all comments bug fix (elastic#65307) ...
stephmilovic
added a commit
that referenced
this pull request
May 7, 2020
stephmilovic
added a commit
that referenced
this pull request
May 7, 2020
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
There was a bug where when a comment had already been pushed to Service A, it did not get pushed to Service B. This PR refactors the section where the comments to push are filtered. It also corrects some translations that did not get caught the first time around.
Checklist
Delete any items that are not applicable to this PR.