[Lens] Remove "inside only" option for treemap labels#65363
Merged
wylieconlon merged 4 commits intoelastic:masterfrom May 6, 2020
Merged
[Lens] Remove "inside only" option for treemap labels#65363wylieconlon merged 4 commits intoelastic:masterfrom
wylieconlon merged 4 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
|
Thanks for tackling this so quickly. The only thing I'm noticing is that the outside labels aren't hiding in dark mode. |
mbondyra
approved these changes
May 6, 2020
Contributor
mbondyra
left a comment
There was a problem hiding this comment.
Nit: I'm not quite convinced about the copy, I feel like either we should put show and hide or show labels and hide labels. WDYT?
Contributor
Author
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
cchaos
approved these changes
May 6, 2020
Contributor
cchaos
left a comment
There was a problem hiding this comment.
👍 LGTM. Tested in Chrome only but I'm glad you were able to get the groove labels to hide completly vs just transparent text
wylieconlon
pushed a commit
to wylieconlon/kibana
that referenced
this pull request
May 6, 2020
* [Lens] Remove "inside only" option for treemap labels * Fix type error * Update from feedback
wylieconlon
pushed a commit
to wylieconlon/kibana
that referenced
this pull request
May 6, 2020
* [Lens] Remove "inside only" option for treemap labels * Fix type error * Update from feedback
wylieconlon
pushed a commit
that referenced
this pull request
May 6, 2020
wylieconlon
pushed a commit
that referenced
this pull request
May 6, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 7, 2020
* master: (42 commits) fix SavedObjectMigrationMap type (elastic#65569) [Uptime] Improve cert flaky test (elastic#65458) [Uptime] Fix monitor list result runtime type, ip can be null (elastic#65532) [APM] Agent configuration: Bug makes it possible to create invalid configurations (elastic#65508) [APM] Remove link from active page in the breadcrumb (elastic#65473) [SIEM] Fixes test flakiness (elastic#65510) [ESLint] update @kbn/eslint/no-restricted-paths rule to allow imports mocks from folder (elastic#65471) Migrate test plugins ⇒ NP (kbn_tp_run_pipeline) (elastic#64780) move core provier to NP. allows to run tests on every page (elastic#64929) Extended alerting documentation with information about using Kibana keystore and action types for preconfigured connectors (elastic#65201) [functional tests] add some missing awaits (elastic#65566) Fixed create new connector from alert flyout form throw an error messages in external plugins. (elastic#65539) [SIEM] [Cases] External services not getting all comments bug fix (elastic#65307) Migrate Coordinate Maps to NP (elastic#64668) Updating Canvas location in nav (elastic#65519) [SIEM][Lists] Fixes up contracts to work outside of requests [Lens] Remove "inside only" option for treemap labels (elastic#65363) [Uptime] Add TLS alert functional test (elastic#65303) Fix z-index of kbnLoadingIndicator (elastic#65521) Fixed indice assertion to loop through expected keys (elastic#64684) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because all text is inside the treemap, this setting did not make sense. When switching from the pie to treemap visualization, we need to remove the
insidesetting.Checklist