[Drilldowns] Preserve state when switching between action factories#65074
Merged
Dosant merged 3 commits intoelastic:masterfrom May 7, 2020
Merged
[Drilldowns] Preserve state when switching between action factories#65074Dosant merged 3 commits intoelastic:masterfrom
Dosant merged 3 commits intoelastic:masterfrom
Conversation
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
merge conflict between base and head |
ebe3d62 to
09599fd
Compare
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Contributor
Author
|
@elasticmachine merge upstream |
streamich
approved these changes
May 6, 2020
Contributor
streamich
left a comment
There was a problem hiding this comment.
See comment about reusing existing state below, otherwise LGTM.
| name: '', | ||
| } | ||
| ); | ||
| const [actionConfigCache, setActionConfigCache] = useState<Record<string, object>>( |
Contributor
There was a problem hiding this comment.
What do you think about having all configs in DrilldownWizardConfig instead of introducing actionConfigCache?
export interface DrilldownWizardConfig {
name: string;
actionFactory?: ActionFactory;
configs?: Record<string, object>;
}
Contributor
Author
There was a problem hiding this comment.
I think I like the current version more, because we leave api of this component simpler, but still have this nice UX touch of not losing changes when switching between factories.
I wouldn't do it unless we really want to preserve those internal states longer then component lifecycle.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Dosant
added a commit
to Dosant/kibana
that referenced
this pull request
May 7, 2020
…lastic#65074) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 7, 2020
* master: [ML] Transforms: Fix API error message display for edit flyout. (elastic#65494) [SIEM][Detection Engine] Fixes import bug with non existent signals index (elastic#65595) [Lens] Use rules of hooks with linting (elastic#65593) [ML] Migrate server side Mocha tests to Jest. (elastic#65651) Fixes the client to setup SSL with the CA certificates for testing (elastic#65598) reduce uptime plugin initial bundle size (elastic#65257) [ML] Consolidating shared types and util functions (elastic#65247) [Drilldowns] Preserve state when selecting different action factory (elastic#65074) Migrate test plugins ⇒ NP (kbn_tp_embeddable_explorer) (elastic#64756) Move remaining home assets to the new platform (elastic#65053) Change the copy and the id from blacklist to block list for consistency (elastic#65419) [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522) [ML] Fix the limit control on the Anomaly explorer page (elastic#65459) [Mappings editor] Add component integration tests (elastic#63853) [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456) [Logs UI] Disable search bar when live stream is on. (elastic#65491)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 7, 2020
…ponents * alerting/lazy-load-actions: align and style loading indicator [ML] Transforms: Fix API error message display for edit flyout. (elastic#65494) [SIEM][Detection Engine] Fixes import bug with non existent signals index (elastic#65595) [Lens] Use rules of hooks with linting (elastic#65593) [ML] Migrate server side Mocha tests to Jest. (elastic#65651) Fixes the client to setup SSL with the CA certificates for testing (elastic#65598) reduce uptime plugin initial bundle size (elastic#65257) [ML] Consolidating shared types and util functions (elastic#65247) [Drilldowns] Preserve state when selecting different action factory (elastic#65074) Migrate test plugins ⇒ NP (kbn_tp_embeddable_explorer) (elastic#64756) Move remaining home assets to the new platform (elastic#65053) Change the copy and the id from blacklist to block list for consistency (elastic#65419) [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522) [ML] Fix the limit control on the Anomaly explorer page (elastic#65459) [Mappings editor] Add component integration tests (elastic#63853) [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456) [Logs UI] Disable search bar when live stream is on. (elastic#65491)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of: #42845
Chore UX improvement.
When switching between action factories state is preserved now.
State is stored inside "create drilldown" component. So closing Drilldowns panel and getting back won't preserve state. (I think this is expected)
Checklist
Delete any items that are not applicable to this PR.
For maintainers