[SIEM][Detection Engine] Fixes import bug with non existent signals index#65595
Merged
FrankHassanabad merged 2 commits intoelastic:masterfrom May 7, 2020
Merged
[SIEM][Detection Engine] Fixes import bug with non existent signals index#65595FrankHassanabad merged 2 commits intoelastic:masterfrom
FrankHassanabad merged 2 commits intoelastic:masterfrom
Conversation
…ill creates the rules and activates them
FrankHassanabad
commented
May 6, 2020
| if (parsedRule instanceof Error) { | ||
| // If the JSON object had a validation or parse error then we return | ||
| // early with the error and an (unknown) for the ruleId | ||
| const importsWorkerPromise = new Promise<ImportRuleResponse>(async resolve => { |
Contributor
Author
There was a problem hiding this comment.
NOTE: formatting is all messed up because I removed the dead variable reject
FrankHassanabad
commented
May 6, 2020
| message: `To create a rule, the index must exist first. Index ${signalsIndex} does not exist`, | ||
| }) | ||
| ); | ||
| return null; |
Contributor
Author
There was a problem hiding this comment.
NOTE: Ignore what the diff says, this return null is what I added and only what I added.
Contributor
There was a problem hiding this comment.
FYI You can always add ?w=1 to diff URIs, or select "Hide whitespaces changes" from the cog dropdown on the diff view.
Contributor
Author
There was a problem hiding this comment.
Ah of course! I used to do that before. Totally forgot about that feature. Thank you!
Contributor
|
Pinging @elastic/siem (Team:SIEM) |
dhurley14
reviewed
May 7, 2020
x-pack/plugins/siem/server/lib/detection_engine/routes/rules/import_rules_route.ts
Outdated
Show resolved
Hide resolved
dhurley14
approved these changes
May 7, 2020
Contributor
dhurley14
left a comment
There was a problem hiding this comment.
LGTM - I think moving the index check above the while loop would be a minor improvement but not necessary. Thanks for the 🚫🐛
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
FrankHassanabad
added a commit
to FrankHassanabad/kibana
that referenced
this pull request
May 7, 2020
…ndex (elastic#65595) See: elastic#65565 * Fixes it to where if there is an import without an index then the rule is not created ### Checklist - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 7, 2020
* master: [ML] Transforms: Fix API error message display for edit flyout. (elastic#65494) [SIEM][Detection Engine] Fixes import bug with non existent signals index (elastic#65595) [Lens] Use rules of hooks with linting (elastic#65593) [ML] Migrate server side Mocha tests to Jest. (elastic#65651) Fixes the client to setup SSL with the CA certificates for testing (elastic#65598) reduce uptime plugin initial bundle size (elastic#65257) [ML] Consolidating shared types and util functions (elastic#65247) [Drilldowns] Preserve state when selecting different action factory (elastic#65074) Migrate test plugins ⇒ NP (kbn_tp_embeddable_explorer) (elastic#64756) Move remaining home assets to the new platform (elastic#65053) Change the copy and the id from blacklist to block list for consistency (elastic#65419) [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522) [ML] Fix the limit control on the Anomaly explorer page (elastic#65459) [Mappings editor] Add component integration tests (elastic#63853) [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456) [Logs UI] Disable search bar when live stream is on. (elastic#65491)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 7, 2020
…ponents * alerting/lazy-load-actions: align and style loading indicator [ML] Transforms: Fix API error message display for edit flyout. (elastic#65494) [SIEM][Detection Engine] Fixes import bug with non existent signals index (elastic#65595) [Lens] Use rules of hooks with linting (elastic#65593) [ML] Migrate server side Mocha tests to Jest. (elastic#65651) Fixes the client to setup SSL with the CA certificates for testing (elastic#65598) reduce uptime plugin initial bundle size (elastic#65257) [ML] Consolidating shared types and util functions (elastic#65247) [Drilldowns] Preserve state when selecting different action factory (elastic#65074) Migrate test plugins ⇒ NP (kbn_tp_embeddable_explorer) (elastic#64756) Move remaining home assets to the new platform (elastic#65053) Change the copy and the id from blacklist to block list for consistency (elastic#65419) [ML] Hide selector helper in Anomaly Explorer swimlane (elastic#65522) [ML] Fix the limit control on the Anomaly explorer page (elastic#65459) [Mappings editor] Add component integration tests (elastic#63853) [Logs + Metrics UI] Prevent component errors from breaking the whole UI (elastic#65456) [Logs UI] Disable search bar when live stream is on. (elastic#65491)
FrankHassanabad
added a commit
that referenced
this pull request
May 7, 2020
…ndex (#65595) (#65690) See: #65565 * Fixes it to where if there is an import without an index then the rule is not created ### Checklist - [x] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: #65565
Checklist