Skip to content

[EPM] update endpoint to restrict removing with datasources#64978

Merged
neptunian merged 1 commit intoelastic:masterfrom
neptunian:64976-restrict-remove-package-endpoint
May 4, 2020
Merged

[EPM] update endpoint to restrict removing with datasources#64978
neptunian merged 1 commit intoelastic:masterfrom
neptunian:64976-restrict-remove-package-endpoint

Conversation

@neptunian
Copy link
Copy Markdown
Contributor

#64976

This slipped by me when creating the UI. We do not allow users to uninstall a package if datasources for the package exist. The endpoint needs to have the same behavior

To test:

  1. Create a datasource using Ingest Manager UI
  2. Try to delete via the endpoint:

Screen Shot 2020-04-30 at 6 38 41 PM

  1. Install a package using the settings page or endpoint and do not add datasources
  2. Try to delete it through the endpoint or UI

Screen Shot 2020-04-30 at 6 40 40 PM

@neptunian neptunian added v8.0.0 Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project v7.8.0 Team:Fleet Team label for Observability Data Collection Fleet team labels Apr 30, 2020
@neptunian neptunian requested a review from a team April 30, 2020 22:42
@neptunian neptunian self-assigned this Apr 30, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ingest-management (Feature:EPM)

@neptunian neptunian added the release_note:skip Skip the PR/issue when compiling release notes label Apr 30, 2020
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@neptunian neptunian merged commit 3356a19 into elastic:master May 4, 2020
neptunian added a commit to neptunian/kibana that referenced this pull request May 4, 2020
gmmorris added a commit to gmmorris/kibana that referenced this pull request May 4, 2020
…ana into alerting/np-tests-migration

* 'alerting/np-tests-migration' of github.com:gmmorris/kibana:
  [APM] Agent remote config: validation for Java agent configs (elastic#63956)
  [APM] Fix duplicate index patterns (elastic#64883)
  Drilldowns (elastic#61219)
  [Alerting] fix labels and links in PagerDuty action ui and docs (elastic#64032)
  [Event Log] Ensure sorting tests are less flaky (elastic#64781)
  update endpoint to restrict removing with datasources (elastic#64978)
  [Logs UI] [Alerting] Alerts management page enhancements (elastic#64654)
  Adjust kibana app owning files (elastic#65064)
  Migrate tutorial resources (elastic#64298)
  [Logs UI] Tweak copy in log alerts dialog (elastic#64645)
  [Logs UI] [Alerting] Documentation (elastic#64886)
  [Logs UI] Add dataset filter to ML module setup screen (elastic#64470)
  [TSVB] Fixing memory leak (elastic#64918)
  Bump backport to 5.4.1 (elastic#65041)
neptunian added a commit that referenced this pull request May 4, 2020
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v7.8.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants