[Logs UI] Add dataset filter to ML module setup screen#64470
[Logs UI] Add dataset filter to ML module setup screen#64470weltenwort merged 21 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
|
@elasticmachine merge upstream |
|
Test failures look unrelated... @elasticmachine merge upstream |
|
@elasticmachine merge upstream |
Kerry350
left a comment
There was a problem hiding this comment.
Great job. Code looks good, and I was able to setup my jobs with "All" as well as a filter for the datasets 👍 One small comment.
| startTime: number, | ||
| endTime: number | ||
| ) => { | ||
| const response = await npStart.http.fetch(LOG_ANALYSIS_VALIDATE_DATASETS_PATH, { |
There was a problem hiding this comment.
Can this be changed so as to not use the legacy_singletons, e.g. callValidateDatasetsAPI taking fetch as an argument?
There was a problem hiding this comment.
Absolutely - I just kept it in sync with the other API calls so far. Would it be ok to switch all of them over at once in a separate PR (that is not subject to a close deadline)?
| "query": { | ||
| "bool": { | ||
| "filter": [ | ||
| { | ||
| "exists": { | ||
| "field": "message" | ||
| } | ||
| } | ||
| ] | ||
| } | ||
| } |
There was a problem hiding this comment.
ℹ️ Since the setup API doesn't merge this and any queries supplied at setup time, the query is now only defined via the API.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This adds the ability to filter the datasets to be processed by the ML jobs on the setup screen.
…ana into alerting/np-tests-migration * 'alerting/np-tests-migration' of github.com:gmmorris/kibana: [APM] Agent remote config: validation for Java agent configs (elastic#63956) [APM] Fix duplicate index patterns (elastic#64883) Drilldowns (elastic#61219) [Alerting] fix labels and links in PagerDuty action ui and docs (elastic#64032) [Event Log] Ensure sorting tests are less flaky (elastic#64781) update endpoint to restrict removing with datasources (elastic#64978) [Logs UI] [Alerting] Alerts management page enhancements (elastic#64654) Adjust kibana app owning files (elastic#65064) Migrate tutorial resources (elastic#64298) [Logs UI] Tweak copy in log alerts dialog (elastic#64645) [Logs UI] [Alerting] Documentation (elastic#64886) [Logs UI] Add dataset filter to ML module setup screen (elastic#64470) [TSVB] Fixing memory leak (elastic#64918) Bump backport to 5.4.1 (elastic#65041)
Summary
This adds the ability to filter the datasets to be processed by the ML jobs on the setup screen. When no dataset is selected for an index group, no filtering is applied. As soon as one dataset is selected, the datafeed applies a terms filter to the incoming documents.
Note: Even though the datasets are displayed for each index group, the datafeed can't apply the dataset filters selectively when it pushes the data to the ML job. The grouping only serves as an indication of occurrence of the dataset terms.
closes #60390
Previews
Testing
Task breakdown