[Alerting] fix labels and links in PagerDuty action ui and docs#64032
Merged
pmuellr merged 2 commits intoelastic:masterfrom May 4, 2020
Merged
[Alerting] fix labels and links in PagerDuty action ui and docs#64032pmuellr merged 2 commits intoelastic:masterfrom
pmuellr merged 2 commits intoelastic:masterfrom
Conversation
resolves elastic#63222, resolves elastic#63768, resolves elastic#63223 ui changes: - adds an "(optional)" label after the API URL label - changes help link to go to alerting docs and not watcher docs - changes the label "Routing key" to "Integration key" to match other docs - changes the order of the severity options to match other docs doc changes: - changes the reference of "Routing key" to "Integration key" to match other docs - makes clearer that the API URL is optional
Contributor
|
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
pmuellr
commented
Apr 21, 2020
| @@ -175,20 +175,20 @@ const PagerDutyParamsFields: React.FunctionComponent<ActionParamsProps<PagerDuty | |||
| } = actionParams; | |||
| const severityOptions = [ | |||
| { | |||
Contributor
Author
There was a problem hiding this comment.
The changes below are a re-ordering of the critical/error/warning/info severities, which changes the order displayed in the UI to match the same ordering I've seen on PD's site.
gmmorris
approved these changes
Apr 21, 2020
Contributor
gmmorris
left a comment
There was a problem hiding this comment.
LGTM.
While we're there it might be worth considering ways of making the Summery field stand out (it's weird to me having optional fields with one required field in the middle that's easily overlooked), but it doesn't have to be in this PR. 🤷
Contributor
Author
I noticed that as well, and it bugged me enough I had a very, very brief thought about fixing that, but ... I'll open a new issue instead :-) |
Contributor
Author
|
I plan on waiting to merge this to 7.7, 7.x, and master once the 7.7.0 tag is cut; it's going to be confusing to me to only merge it to some branches right now, and I think the potential for conflicting changes in between is small, and price to fix conflicts should be small anyway. |
Contributor
Author
|
I just opened #64112 for the re-arrangement of the Summary field that Gidi mentioned ^^^ |
Contributor
Author
|
@elasticmachine merge upstream |
pmuellr
added a commit
to pmuellr/kibana
that referenced
this pull request
May 4, 2020
…tic#64032) resolves elastic#63222, resolves elastic#63768, resolves elastic#63223 ui changes: - adds an "(optional)" label after the API URL label - changes help link to go to alerting docs and not watcher docs - changes the label "Routing key" to "Integration key" to match other docs - changes the order of the severity options to match other docs doc changes: - changes the reference of "Routing key" to "Integration key" to match other docs - makes clearer that the API URL is optional
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 4, 2020
…ana into alerting/np-tests-migration * 'alerting/np-tests-migration' of github.com:gmmorris/kibana: [APM] Agent remote config: validation for Java agent configs (elastic#63956) [APM] Fix duplicate index patterns (elastic#64883) Drilldowns (elastic#61219) [Alerting] fix labels and links in PagerDuty action ui and docs (elastic#64032) [Event Log] Ensure sorting tests are less flaky (elastic#64781) update endpoint to restrict removing with datasources (elastic#64978) [Logs UI] [Alerting] Alerts management page enhancements (elastic#64654) Adjust kibana app owning files (elastic#65064) Migrate tutorial resources (elastic#64298) [Logs UI] Tweak copy in log alerts dialog (elastic#64645) [Logs UI] [Alerting] Documentation (elastic#64886) [Logs UI] Add dataset filter to ML module setup screen (elastic#64470) [TSVB] Fixing memory leak (elastic#64918) Bump backport to 5.4.1 (elastic#65041)
pmuellr
added a commit
that referenced
this pull request
May 4, 2020
…) (#65075) resolves #63222, resolves #63768, resolves #63223 ui changes: - adds an "(optional)" label after the API URL label - changes help link to go to alerting docs and not watcher docs - changes the label "Routing key" to "Integration key" to match other docs - changes the order of the severity options to match other docs doc changes: - changes the reference of "Routing key" to "Integration key" to match other docs - makes clearer that the API URL is optional
Contributor
Author
|
I merged this to master and 7.x for 7.8 - I was originally planning on waiting till the 7.7.0 tag was created to merge to 7.7 for the 7.7.1 release, but it hasn't been created yet. |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
pmuellr
added a commit
to pmuellr/kibana
that referenced
this pull request
May 18, 2020
…tic#64032) resolves elastic#63222, resolves elastic#63768, resolves elastic#63223 ui changes: - adds an "(optional)" label after the API URL label - changes help link to go to alerting docs and not watcher docs - changes the label "Routing key" to "Integration key" to match other docs - changes the order of the severity options to match other docs doc changes: - changes the reference of "Routing key" to "Integration key" to match other docs - makes clearer that the API URL is optional
pmuellr
added a commit
that referenced
this pull request
May 18, 2020
…) (#66895) resolves #63222, resolves #63768, resolves #63223 ui changes: - adds an "(optional)" label after the API URL label - changes help link to go to alerting docs and not watcher docs - changes the label "Routing key" to "Integration key" to match other docs - changes the order of the severity options to match other docs doc changes: - changes the reference of "Routing key" to "Integration key" to match other docs - makes clearer that the API URL is optional
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #63222, resolves #63768, resolves #63223
ui changes:
doc changes:
Checklist