Migrate tutorial resources by DianaDerevyankina · Pull Request #64298 · elastic/kibana

DianaDerevyankina · 2020-04-23T11:35:33Z

Summary

Moved apm assets into the apm plugin, ems assets into the maps plugin, other tutorial resources were moved into home/public/assets.

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser
This was checked for cross-browser compatibility, including a check against IE11

For maintainers

This was checked for breaking API changes and was labeled appropriately

Closes elastic#55710

alexwizp · 2020-04-24T15:08:50Z

x-pack/plugins/apm/public/index.ts

+ * you may not use this file except in compliance with the Elastic License.
+ */
+
+import { ApmPlugin } from './plugin';


I prefer to see the file and content structure of the new plugin created using the scripts/generate_plugin

DianaDerevyankina · 2020-04-24T15:52:56Z

I've found out that screenshot from azure_metrics folder isn't used at all as well as it's icon azure.svg. The same is for oracle.svg.
And there're some commented lines with previewImagePath for php_fpm_metrics, uptime_monitors, envoyproxy_metrics, postgresql_metrics, traefik_metrics and vsphere_metrics. Do we need to keep these assets and comments?

elasticmachine · 2020-04-29T11:27:56Z

Pinging @elastic/kibana-app (Team:KibanaApp)

DianaDerevyankina · 2020-04-29T11:28:45Z

@elasticmachine merge upstream

…nto 55710

nreese

maps changes lgtm
code review

flash1293

Tested in Chrome and the logos and screenshots still seem to be in place, LGTM.

# Conflicts: # x-pack/plugins/apm/kibana.json # x-pack/plugins/apm/public/index.ts # x-pack/plugins/apm/public/plugin.ts

sorenlouv

Code changes look good 👍
After the APM tutorial was moved into x-pack will OSS users still be able to see it?

DianaDerevyankina · 2020-05-04T09:56:22Z

After the APM tutorial was moved into x-pack will OSS users still be able to see it?

@sqren There's no apm tutorial at Home/Add data page for OSS users, so these changes won't affect them

kibanamachine · 2020-05-04T10:51:16Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: ba89479

History

💔 Build #44849 failed 08b9e67
💚 Build #44342 succeeded 84bde78
💔 Build #44045 failed b5c3cd4
💚 Build #43135 succeeded e065e10
💔 Build #43117 failed 0e4d4ab

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

sorenlouv · 2020-05-04T14:20:22Z

There's no apm tutorial at Home/Add data page for OSS users, so these changes won't affect them

@dziyanadzeraviankina was this always the case? And what's the reasoning for not making the tutorials available for OSS users?

flash1293 · 2020-05-04T14:30:37Z

@dziyanadzeraviankina I synced with @sqren and sorted it out. I will prepare a separate PR to fix the issue.

* Migrate tutorial resources Closes elastic#55710 * Added type to context in apm plugin index * Removed context parameter from ApmPlugin * Generated apm plugin by generate_plugin script * Removed getGreeting declaration * Remove unused assets and comment previewImagePaths * Removed unnecessary types file Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…ana into alerting/np-tests-migration * 'alerting/np-tests-migration' of github.com:gmmorris/kibana: [APM] Agent remote config: validation for Java agent configs (elastic#63956) [APM] Fix duplicate index patterns (elastic#64883) Drilldowns (elastic#61219) [Alerting] fix labels and links in PagerDuty action ui and docs (elastic#64032) [Event Log] Ensure sorting tests are less flaky (elastic#64781) update endpoint to restrict removing with datasources (elastic#64978) [Logs UI] [Alerting] Alerts management page enhancements (elastic#64654) Adjust kibana app owning files (elastic#65064) Migrate tutorial resources (elastic#64298) [Logs UI] Tweak copy in log alerts dialog (elastic#64645) [Logs UI] [Alerting] Documentation (elastic#64886) [Logs UI] Add dataset filter to ML module setup screen (elastic#64470) [TSVB] Fixing memory leak (elastic#64918) Bump backport to 5.4.1 (elastic#65041)

* Migrate tutorial resources Closes elastic#55710 * Added type to context in apm plugin index * Removed context parameter from ApmPlugin * Generated apm plugin by generate_plugin script * Removed getGreeting declaration * Remove unused assets and comment previewImagePaths * Removed unnecessary types file Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* Migrate tutorial resources Closes #55710 * Added type to context in apm plugin index * Removed context parameter from ApmPlugin * Generated apm plugin by generate_plugin script * Removed getGreeting declaration * Remove unused assets and comment previewImagePaths * Removed unnecessary types file Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

Migrate tutorial resources

b547861

Closes elastic#55710

DianaDerevyankina self-assigned this Apr 23, 2020

DianaDerevyankina added 3 commits April 24, 2020 10:22

Merge branch 'DianaDerevyankina' into 55710

1a1c92f

Added type to context in apm plugin index

319dcc4

Removed context parameter from ApmPlugin

6a1713b

alexwizp reviewed Apr 24, 2020

View reviewed changes

Generated apm plugin by generate_plugin script

0e4d4ab

Removed getGreeting declaration

e065e10

DianaDerevyankina marked this pull request as ready for review April 29, 2020 11:25

DianaDerevyankina requested a review from a team April 29, 2020 11:25

DianaDerevyankina requested a review from a team as a code owner April 29, 2020 11:25

DianaDerevyankina added Feature:Home Kibana home application Feature:NP Migration Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// labels Apr 29, 2020

DianaDerevyankina added release_note:skip Skip the PR/issue when compiling release notes v7.8.0 v8.0.0 labels Apr 29, 2020

elasticmachine and others added 4 commits April 29, 2020 07:28

Merge branch 'master' into 55710

6cca383

Merge branch 'master' into 55710

4210699

Remove unused assets and comment previewImagePaths

3d12421

Merge branch '55710' of https://github.com/DianaDerevyankina/kibana i…

b5c3cd4

…nto 55710

nreese approved these changes Apr 29, 2020

View reviewed changes

Merge branch 'DianaDerevyankina' into 55710

84bde78

flash1293 approved these changes Apr 30, 2020

View reviewed changes

flash1293 mentioned this pull request May 1, 2020

Move remaining home assets to the new platform #64997

Closed

Merge branch 'DianaDerevyankina' into 55710

08b9e67

# Conflicts: # x-pack/plugins/apm/kibana.json # x-pack/plugins/apm/public/index.ts # x-pack/plugins/apm/public/plugin.ts

sorenlouv approved these changes May 4, 2020

View reviewed changes

Removed unnecessary types file

ba89479

DianaDerevyankina mentioned this pull request May 4, 2020

Move remaining home assets to the new platform #65053

Merged

7 tasks

DianaDerevyankina merged commit a854a1d into elastic:master May 4, 2020

DianaDerevyankina mentioned this pull request May 4, 2020

[7.x] Migrate tutorial resources (#64298) #65099

Closed

DianaDerevyankina mentioned this pull request May 5, 2020

[7.x] Migrate tutorial resources (#64298) #65231

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate tutorial resources#64298

Migrate tutorial resources#64298
DianaDerevyankina merged 13 commits intoelastic:masterfrom
DianaDerevyankina:55710

DianaDerevyankina commented Apr 23, 2020

Uh oh!

alexwizp Apr 24, 2020

Uh oh!

DianaDerevyankina commented Apr 24, 2020

Uh oh!

elasticmachine commented Apr 29, 2020

Uh oh!

DianaDerevyankina commented Apr 29, 2020

Uh oh!

nreese left a comment

Uh oh!

flash1293 left a comment

Uh oh!

sorenlouv left a comment

Uh oh!

DianaDerevyankina commented May 4, 2020 •

edited

Loading

Uh oh!

kibanamachine commented May 4, 2020

Uh oh!

sorenlouv commented May 4, 2020

Uh oh!

flash1293 commented May 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

DianaDerevyankina commented Apr 23, 2020

Summary

Checklist

For maintainers

Uh oh!

alexwizp Apr 24, 2020

Choose a reason for hiding this comment

Uh oh!

DianaDerevyankina commented Apr 24, 2020

Uh oh!

elasticmachine commented Apr 29, 2020

Uh oh!

DianaDerevyankina commented Apr 29, 2020

Uh oh!

nreese left a comment

Choose a reason for hiding this comment

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

sorenlouv left a comment

Choose a reason for hiding this comment

Uh oh!

DianaDerevyankina commented May 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kibanamachine commented May 4, 2020

💚 Build Succeeded

History

Uh oh!

sorenlouv commented May 4, 2020

Uh oh!

flash1293 commented May 4, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

DianaDerevyankina commented May 4, 2020 •

edited

Loading