[ML] DF Analytics - ensure destination index pattern created#62450
Merged
alvarezmelissa87 merged 4 commits intoelastic:masterfrom Apr 3, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
walterra
reviewed
Apr 3, 2020
|
|
||
| if (isAdvancedEditorEnabled) { | ||
| destinationIndex = Array.isArray(analyticsJobConfig.dest?.index) | ||
| ? analyticsJobConfig.dest?.index[0] |
Contributor
There was a problem hiding this comment.
wonder if this should be .join(',') instead?
Contributor
Author
There was a problem hiding this comment.
This is the dest index so shouldn't be multiple indices here.
alvarezmelissa87
commented
Apr 3, 2020
| const analyticsJobConfig = (isAdvancedEditorEnabled | ||
| ? jobConfig | ||
| : getJobConfigFromFormState(form); | ||
| : getJobConfigFromFormState(form)) as DataFrameAnalyticsConfig; |
Contributor
Author
There was a problem hiding this comment.
Set as DataFrameAnalyticsConfig as that type for the analysis config is still wrapped in a DeepPartial at this point but since it has passed validation we don't need that as it's complete.
peteharverson
approved these changes
Apr 3, 2020
Contributor
peteharverson
left a comment
There was a problem hiding this comment.
Tested latest edit and LGTM
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Apr 3, 2020
…#62450) * ensure destinationIndex name is defined * set array for destIndex as invalid * update type * reset destIndex already exists error when updating advanced editor
alvarezmelissa87
added a commit
to alvarezmelissa87/kibana
that referenced
this pull request
Apr 3, 2020
…#62450) * ensure destinationIndex name is defined * set array for destIndex as invalid * update type * reset destIndex already exists error when updating advanced editor
alvarezmelissa87
added a commit
that referenced
this pull request
Apr 3, 2020
alvarezmelissa87
added a commit
that referenced
this pull request
Apr 3, 2020
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 6, 2020
…into event-log/query-support * 'event-log/query-support' of github.com:gmmorris/kibana: (41 commits) [jenkins] refer to sizes in most pipeline code (elastic#62082) skip flaky suite (elastic#60470) [Discover] Fix flaky FT in field visualize (elastic#62418) [ML] Data Frame Analytics: Fix feature importance (elastic#61761) [Reporting] Use a shim for server config (elastic#62086) [Reporting] Fix reporting for non-default spaces (elastic#62226) Fix bug that coerced empty scaled float value to 0 (elastic#62251) [SIEM] [Detection Engine] Remove has manage api keys requireme… (elastic#62446) [Maps] Safely handle empty string and invalid strings from EuiColorPicker (elastic#62507) Reporting/bug more blacklisted headers (elastic#62389) [SIEM] Prevent undefined behavior in our ML popover (elastic#62498) [SIEM] [Detection Engine] remove all unknowns from all rules t… (elastic#62327) base changes for active/current node styling (elastic#62007) [kbn/ui-shared-deps] expand and split (elastic#62364) [ML] DF Analytics - ensure destination index pattern created (elastic#62450) Mark rule run as failure if there was an error (elastic#62383) Add docs for metric explorer alerts (elastic#62314) skip flaky suite (elastic#62281) [SIEM][Detection Engine] Fixes export of single rule and the icons fixes flakiness (elastic#62406) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #62431
Ensures destination index pattern is created when job created from advanced editor and
Create index patternswitch is toggled on.Fixes blank page when array is set as destination index by checking it is string type in validator.
Ensures
An index pattern with this title already exists.message is reset when advanced editor is edited.