[kbn/ui-shared-deps] expand and split by spalger · Pull Request #62364 · elastic/kibana

spalger · 2020-04-02T19:00:10Z

In order to work against #62238, this PR brings the elasticsearch client into the @kbn/ui-shared-deps pacakge as it is locked to a specific version and absolutely huge. Since the ui-shared-deps was already large, this also splits the file into two, sticking anything that's in the @elastic org into a separate chunk, which is loaded in parallel.

mshustov · 2020-04-02T19:28:22Z

packages/kbn-ui-shared-deps/entry.js

I'd expect to see lodash here. it's being ~~over~~used by every plugin literally

Yeah, the issue is that we don't have a single lodash version

ok. that's almost ~400kB per bundle 😞

Btw, is something like https://www.npmjs.com/package/babel-plugin-transform-imports already in place for libs like lodash?

No, sounds like a great plugin to add

elasticmachine · 2020-04-03T06:05:11Z

Pinging @elastic/kibana-operations (Team:Operations)

spalger · 2020-04-03T14:58:14Z

@elasticmachine merge upstream

packages/kbn-ui-shared-deps/entry.js

tylersmalley · 2020-04-03T17:20:29Z

Looks like this shaved off a considerable amount of JS 39.77 MB vs 27.87 MB!

mistic · 2020-04-03T17:21:07Z

@spalger good effort!

I just made a small find. We still have 2 little references in the DLL within respect to packages in the shared deps.

require('../../node_modules/react-dom/server.browser.js');
require('../../node_modules/@elastic/eui/lib/services/format/index.js');

I think we can also work to add those in the shared ui deps only

spalger · 2020-04-03T17:24:12Z

I'm sad that react-dom/server is used in the UI, but I'll add these to the shared deps

…stateful-deps

mistic · 2020-04-03T17:48:43Z

packages/kbn-ui-shared-deps/entry.js

+export const MonacoBare = require('monaco-editor/esm/vs/editor/editor.api');
 export const React = require('react');
 export const ReactDom = require('react-dom');
+export const ReactDomServer = require('react-dom/server');


maybe we could later investigate why is that being used in the client side code 😃

spalger · 2020-04-03T19:24:21Z

@elasticmachine merge upstream

spalger · 2020-04-03T19:27:15Z

Skipped flaky tests #62472 and #62494

kibanamachine · 2020-04-03T21:08:22Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 821499d

History

💔 Build #38500 failed 5a2bbf5
💚 Build #38446 succeeded 8ce6bb7
💚 Build #38325 succeeded 7c83d04
💚 Build #38318 succeeded 3e7a1e0512f80022a0d271ae5aa7e09c3482efbe
💔 Build #38303 failed b1c4f9ce2e2e45244377cff2b3e329ba0913a2a7

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* [kbn/ui-shared-deps] expand and split * add two import styles for eui/react-dom that are new Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* [kbn/ui-shared-deps] expand and split (#62364) * [kbn/ui-shared-deps] expand and split * add two import styles for eui/react-dom that are new Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * update yarn.lock file Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

* [kbn/ui-shared-deps] expand and split (#62364) * [kbn/ui-shared-deps] expand and split * add two import styles for eui/react-dom that are new Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * downgrade elasticsearch-browser and updated yarn.lock Co-authored-by: spalger <spalger@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…into event-log/query-support * 'event-log/query-support' of github.com:gmmorris/kibana: (41 commits) [jenkins] refer to sizes in most pipeline code (elastic#62082) skip flaky suite (elastic#60470) [Discover] Fix flaky FT in field visualize (elastic#62418) [ML] Data Frame Analytics: Fix feature importance (elastic#61761) [Reporting] Use a shim for server config (elastic#62086) [Reporting] Fix reporting for non-default spaces (elastic#62226) Fix bug that coerced empty scaled float value to 0 (elastic#62251) [SIEM] [Detection Engine] Remove has manage api keys requireme… (elastic#62446) [Maps] Safely handle empty string and invalid strings from EuiColorPicker (elastic#62507) Reporting/bug more blacklisted headers (elastic#62389) [SIEM] Prevent undefined behavior in our ML popover (elastic#62498) [SIEM] [Detection Engine] remove all unknowns from all rules t… (elastic#62327) base changes for active/current node styling (elastic#62007) [kbn/ui-shared-deps] expand and split (elastic#62364) [ML] DF Analytics - ensure destination index pattern created (elastic#62450) Mark rule run as failure if there was an error (elastic#62383) Add docs for metric explorer alerts (elastic#62314) skip flaky suite (elastic#62281) [SIEM][Detection Engine] Fixes export of single rule and the icons fixes flakiness (elastic#62406) ...

mshustov reviewed Apr 2, 2020

View reviewed changes

[kbn/ui-shared-deps] expand and split

7c83d04

spalger force-pushed the implement/ui-stateful-deps branch from 3e7a1e0 to 7c83d04 Compare April 3, 2020 06:03

spalger changed the title ~~split kbn/ui-shared-deps into two, include es client in bundle~~ [kbn/ui-shared-deps] expand and split Apr 3, 2020

spalger added Team:Operations Kibana-Operations Team v7.7.0 v7.8.0 v8.0.0 labels Apr 3, 2020

spalger added the release_note:skip Skip the PR/issue when compiling release notes label Apr 3, 2020

spalger marked this pull request as ready for review April 3, 2020 06:05

spalger requested a review from a team as a code owner April 3, 2020 06:05

Merge branch 'master' into implement/ui-stateful-deps

8ce6bb7

mshustov reviewed Apr 3, 2020

View reviewed changes

packages/kbn-ui-shared-deps/entry.js Show resolved Hide resolved

spalger mentioned this pull request Apr 3, 2020

Improve plugin bundle load time #55241

Closed

tylersmalley approved these changes Apr 3, 2020

View reviewed changes

spalger added 2 commits April 3, 2020 10:27

add two import styles for eui/react-dom that are new

7834964

Merge branch 'master' of github.com:elastic/kibana into implement/ui-…

5a2bbf5

…stateful-deps

mistic reviewed Apr 3, 2020

View reviewed changes

spalger mentioned this pull request Apr 3, 2020

7.7.0 general performance problems, blocking IE11 #62238

Closed

Merge branch 'master' into implement/ui-stateful-deps

821499d

spalger merged commit e6c23ea into elastic:master Apr 3, 2020

spalger mentioned this pull request Apr 3, 2020

[7.x] [kbn/ui-shared-deps] expand and split (#62364) #62522

Merged

spalger mentioned this pull request Apr 3, 2020

[7.7] [kbn/ui-shared-deps] expand and split (#62364) #62523

Merged

spalger deleted the implement/ui-stateful-deps branch April 5, 2020 05:56

elastic deleted a comment from elasticmachine Apr 6, 2020

mshustov mentioned this pull request Apr 20, 2020

[meta] Kibana loading performances optimizations #62263

Closed

17 tasks

Conversation

spalger commented Apr 2, 2020

Uh oh!

mshustov Apr 2, 2020

Choose a reason for hiding this comment

Uh oh!

spalger Apr 2, 2020

Choose a reason for hiding this comment

Uh oh!

mshustov Apr 3, 2020

Choose a reason for hiding this comment

Uh oh!

pgayvallet Apr 3, 2020

Choose a reason for hiding this comment

Uh oh!

spalger Apr 3, 2020

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Apr 3, 2020

Uh oh!

spalger commented Apr 3, 2020

Uh oh!

Uh oh!

tylersmalley commented Apr 3, 2020

Uh oh!

mistic commented Apr 3, 2020

Uh oh!

spalger commented Apr 3, 2020

Uh oh!

mistic Apr 3, 2020

Choose a reason for hiding this comment

Uh oh!

spalger commented Apr 3, 2020

Uh oh!

spalger commented Apr 3, 2020

Uh oh!

kibanamachine commented Apr 3, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants