[Discover] Fix flaky FT in field visualize#62418
Merged
sulemanof merged 8 commits intoelastic:masterfrom Apr 4, 2020
Merged
Conversation
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
nreese
reviewed
Apr 3, 2020
|
|
||
| it('should link geo_shape fields to Maps application', async () => { | ||
| await PageObjects.discover.selectIndexPattern('geo_shapes*'); | ||
| await PageObjects.discover.clickFieldListItem('geometry'); |
Contributor
There was a problem hiding this comment.
Should this call be replaced with calls to PageObjects.discover.findFieldByName like in the discover tests?
Contributor
Author
There was a problem hiding this comment.
Actually, that's not really necessary (even in discover tests), findFieldByName only types the field name in the search bar, to make a field to be in top of sidebar.
This was done in first attempt to fix flaky tests, assuming that failing was caused by a field was too low and goes out of visible screen.
Since that time findFieldByName stayed in tests, don't see a problem with that. @dmlemeshko what are your thoughts?
Contributor
There was a problem hiding this comment.
If these tests are not flaky and do not require pre-search (flaky-test-runner showed 42 times passed), I think we don't need it..
nreese
approved these changes
Apr 3, 2020
Contributor
nreese
left a comment
There was a problem hiding this comment.
maps changes lgtm
code review
dmlemeshko
approved these changes
Apr 3, 2020
Contributor
dmlemeshko
left a comment
There was a problem hiding this comment.
Tested with FTR, 42 passed 🎉
Contributor
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This was referenced Apr 4, 2020
sulemanof
added a commit
to sulemanof/kibana
that referenced
this pull request
Apr 4, 2020
* Unskip * Set only suite * Add field search * Use alternative flaky fix * Remove extra actions Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
sulemanof
added a commit
to sulemanof/kibana
that referenced
this pull request
Apr 4, 2020
* Unskip * Set only suite * Add field search * Use alternative flaky fix * Remove extra actions Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
sulemanof
added a commit
that referenced
this pull request
Apr 4, 2020
* Unskip * Set only suite * Add field search * Use alternative flaky fix * Remove extra actions Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Apr 6, 2020
…into event-log/query-support * 'event-log/query-support' of github.com:gmmorris/kibana: (41 commits) [jenkins] refer to sizes in most pipeline code (elastic#62082) skip flaky suite (elastic#60470) [Discover] Fix flaky FT in field visualize (elastic#62418) [ML] Data Frame Analytics: Fix feature importance (elastic#61761) [Reporting] Use a shim for server config (elastic#62086) [Reporting] Fix reporting for non-default spaces (elastic#62226) Fix bug that coerced empty scaled float value to 0 (elastic#62251) [SIEM] [Detection Engine] Remove has manage api keys requireme… (elastic#62446) [Maps] Safely handle empty string and invalid strings from EuiColorPicker (elastic#62507) Reporting/bug more blacklisted headers (elastic#62389) [SIEM] Prevent undefined behavior in our ML popover (elastic#62498) [SIEM] [Detection Engine] remove all unknowns from all rules t… (elastic#62327) base changes for active/current node styling (elastic#62007) [kbn/ui-shared-deps] expand and split (elastic#62364) [ML] DF Analytics - ensure destination index pattern created (elastic#62450) Mark rule run as failure if there was an error (elastic#62383) Add docs for metric explorer alerts (elastic#62314) skip flaky suite (elastic#62281) [SIEM][Detection Engine] Fixes export of single rule and the icons fixes flakiness (elastic#62406) ...
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #61714
The fix is based on making sure the selected field is in expanded state.
So the
clickFieldListItemVisualizechecks if the field is not collapsed before clicking theVisualizebutton and click if it is.Seems a failure was caused when field was collapsed and the "visualize" couldn't be clicked. A field could be collapsed by an extra click somewhere else on the page, including the selected field.
The
findFieldByNamewas added for search for a field in the sidebar.Checklist
Delete any items that are not applicable to this PR.
For maintainers